[V2] spi/pl022: Simplify use of runtime pm

Message ID 1348758396-25276-1-git-send-email-ulf.hansson@stericsson.com
State New
Headers show

Commit Message

Ulf Hansson Sept. 27, 2012, 3:06 p.m.
From: Ulf Hansson <ulf.hansson@linaro.org>

In probe the pm_runtime_resume is not needed since the amba bus
has already set the device in "resumed" state by using
pm_runtime_set_active.

Additionally more simplifications is done in probe by removing
pm_runtime_put_autosuspend. pm_runtime_put_autosuspend does in
probe functions have same effect as doing pm_runtime_put. This
due to upper layer in driver core is preventing the device from
being runtime suspended by a pm_runtime_get*.

Finally, removing pm_runtime_disable from the remove function
can be done since it is already handled by the amba bus.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---

V2: Clearification added in commit message

---
 drivers/spi/spi-pl022.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index f8568b4..e51a026 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -2188,8 +2188,6 @@  pl022_probe(struct amba_device *adev, const struct amba_id *id)
 	printk(KERN_INFO "pl022: mapped registers from 0x%08x to %p\n",
 	       adev->res.start, pl022->virtbase);
 
-	pm_runtime_resume(dev);
-
 	pl022->clk = clk_get(&adev->dev, NULL);
 	if (IS_ERR(pl022->clk)) {
 		status = PTR_ERR(pl022->clk);
@@ -2250,10 +2248,9 @@  pl022_probe(struct amba_device *adev, const struct amba_id *id)
 		pm_runtime_set_autosuspend_delay(dev,
 			platform_info->autosuspend_delay);
 		pm_runtime_use_autosuspend(dev);
-		pm_runtime_put_autosuspend(dev);
-	} else {
-		pm_runtime_put(dev);
 	}
+	pm_runtime_put(dev);
+
 	return 0;
 
  err_spi_register:
@@ -2302,7 +2299,6 @@  pl022_remove(struct amba_device *adev)
 	clk_disable(pl022->clk);
 	clk_unprepare(pl022->clk);
 	clk_put(pl022->clk);
-	pm_runtime_disable(&adev->dev);
 	iounmap(pl022->virtbase);
 	amba_release_regions(adev);
 	tasklet_disable(&pl022->pump_transfers);