[3.10,135/139] IB/qib: fix false-postive maybe-uninitialized warning

Message ID 1509571624-5001-36-git-send-email-w@1wt.eu
State New
Headers show
  • Untitled series #5659
Related show

Commit Message

Willy Tarreau Nov. 1, 2017, 9:27 p.m.
From: Arnd Bergmann <arnd@arndb.de>

commit f6aafac184a3e46e919769dd4faa8bf0dc436534 upstream.

aarch64-linux-gcc-7 complains about code it doesn't fully understand:

drivers/infiniband/hw/qib/qib_iba7322.c: In function 'qib_7322_txchk_change':
include/asm-generic/bitops/non-atomic.h:105:35: error: 'shadow' may be used uninitialized in this function [-Werror=maybe-uninitialized]

The code is right, and despite trying hard, I could not come up with a version
that I liked better than just adding a fake initialization here to shut up the

Fixes: f931551bafe1 ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand adapters")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Ira Weiny <ira.weiny@intel.com>

Signed-off-by: Doug Ledford <dledford@redhat.com>

Signed-off-by: Willy Tarreau <w@1wt.eu>

 drivers/infiniband/hw/qib/qib_iba7322.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c b/drivers/infiniband/hw/qib/qib_iba7322.c
index 5f5f20f..c61f3e7 100644
--- a/drivers/infiniband/hw/qib/qib_iba7322.c
+++ b/drivers/infiniband/hw/qib/qib_iba7322.c
@@ -6670,7 +6670,7 @@  static void qib_7322_txchk_change(struct qib_devdata *dd, u32 start,
 	unsigned long flags;
 	while (wait) {
-		unsigned long shadow;
+		unsigned long shadow = 0;
 		int cstart, previ = -1;