| Message ID | 20171102114209.1686507-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 474f5da2354e9fd5376b968e4c5a0f1807dc19e8 |
| Headers | show |
| Series | skd: use ktime_get_real_seconds() | expand |
On 11/02/2017 05:42 AM, Arnd Bergmann wrote: > Like many storage drivers, skd uses an unsigned 32-bit number for > interchanging the current time with the firmware. This will overflow in > y2106 and is otherwise safe. > > However, the get_seconds() function is generally considered deprecated > since the behavior is different between 32-bit and 64-bit architectures, > and using it may indicate a bigger problem. > > To annotate that we've thought about this, let's add a comment here > and migrate to the ktime_get_real_seconds() function that consistently > returns a 64-bit number. Thanks Arnd, applied. -- Jens Axboe
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 64d0fc17c174..2819f23e8bf2 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -1967,7 +1967,8 @@ static void skd_isr_msg_from_dev(struct skd_device *skdev) break; case FIT_MTD_CMD_LOG_HOST_ID: - skdev->connect_time_stamp = get_seconds(); + /* hardware interface overflows in y2106 */ + skdev->connect_time_stamp = (u32)ktime_get_real_seconds(); data = skdev->connect_time_stamp & 0xFFFF; mtd = FIT_MXD_CONS(FIT_MTD_CMD_LOG_TIME_STAMP_LO, 0, data); SKD_WRITEL(skdev, mtd, FIT_MSG_TO_DEVICE);
Like many storage drivers, skd uses an unsigned 32-bit number for interchanging the current time with the firmware. This will overflow in y2106 and is otherwise safe. However, the get_seconds() function is generally considered deprecated since the behavior is different between 32-bit and 64-bit architectures, and using it may indicate a bigger problem. To annotate that we've thought about this, let's add a comment here and migrate to the ktime_get_real_seconds() function that consistently returns a 64-bit number. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/block/skd_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.9.0