| Message ID | 20171102114320.1729239-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | c0041d40ba6a352e5a5304d656e8a26e2fba1f63 |
| Headers | show |
| Series | APEI/ERST: use 64-bit timestamps | expand |
On Thu, 2 Nov 2017, Arnd Bergmann wrote: > 32-bit timestamps are deprecated in the kernel, so we should not use > get_seconds(). In this case, the 'struct cper_record_header' structure > already contains a 64-bit field, so the only required change is to use > the safe ktime_get_real_seconds() interface as a replacement. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Thomas Gleixner <tglx@linutronix.de> > --- > drivers/acpi/apei/erst.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c > index 2c462beee551..6742f6c68034 100644 > --- a/drivers/acpi/apei/erst.c > +++ b/drivers/acpi/apei/erst.c > @@ -1061,7 +1061,7 @@ static int erst_writer(struct pstore_record *record) > rcd->hdr.error_severity = CPER_SEV_FATAL; > /* timestamp valid. platform_id, partition_id are invalid */ > rcd->hdr.validation_bits = CPER_VALID_TIMESTAMP; > - rcd->hdr.timestamp = get_seconds(); > + rcd->hdr.timestamp = ktime_get_real_seconds(); > rcd->hdr.record_length = sizeof(*rcd) + record->size; > rcd->hdr.creator_id = CPER_CREATOR_PSTORE; > rcd->hdr.notification_type = CPER_NOTIFY_MCE; > -- > 2.9.0 > > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c index 2c462beee551..6742f6c68034 100644 --- a/drivers/acpi/apei/erst.c +++ b/drivers/acpi/apei/erst.c @@ -1061,7 +1061,7 @@ static int erst_writer(struct pstore_record *record) rcd->hdr.error_severity = CPER_SEV_FATAL; /* timestamp valid. platform_id, partition_id are invalid */ rcd->hdr.validation_bits = CPER_VALID_TIMESTAMP; - rcd->hdr.timestamp = get_seconds(); + rcd->hdr.timestamp = ktime_get_real_seconds(); rcd->hdr.record_length = sizeof(*rcd) + record->size; rcd->hdr.creator_id = CPER_CREATOR_PSTORE; rcd->hdr.notification_type = CPER_NOTIFY_MCE;
32-bit timestamps are deprecated in the kernel, so we should not use get_seconds(). In this case, the 'struct cper_record_header' structure already contains a 64-bit field, so the only required change is to use the safe ktime_get_real_seconds() interface as a replacement. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/acpi/apei/erst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html