| Message ID | 20171102115712.3392843-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 2b88212c4cc67ff33dec5bb4d690044b97a5f979 |
| Headers | show |
| Series | phy: rcar-gen3-usb2: select USB_COMMON | expand |
Hi Arnd, > From: Arnd Bergmann, Sent: Thursday, November 2, 2017 8:57 PM > > When USB is disabled, we get a link error for this driver > because of the added OTG support > > drivers/phy/renesas/phy-rcar-gen3-usb2.o: In function `rcar_gen3_phy_usb2_probe': > phy-rcar-gen3-usb2.c:(.text+0x250): undefined reference to `of_usb_get_dr_mode_by_phy' > > Other phy drivers select USB_COMMON for this, so let's do the same > here. > > Fixes: 7e0540f41332 ("phy: rcar-gen3-usb2: check dr_mode for otg mode") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thank you for the patch! Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda
diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig index cb09245e9b4c..c845facacb06 100644 --- a/drivers/phy/renesas/Kconfig +++ b/drivers/phy/renesas/Kconfig @@ -12,7 +12,9 @@ config PHY_RCAR_GEN3_USB2 tristate "Renesas R-Car generation 3 USB 2.0 PHY driver" depends on ARCH_RENESAS depends on EXTCON + depends on USB_SUPPORT select GENERIC_PHY + select USB_COMMON help Support for USB 2.0 PHY found on Renesas R-Car generation 3 SoCs.
When USB is disabled, we get a link error for this driver because of the added OTG support drivers/phy/renesas/phy-rcar-gen3-usb2.o: In function `rcar_gen3_phy_usb2_probe': phy-rcar-gen3-usb2.c:(.text+0x250): undefined reference to `of_usb_get_dr_mode_by_phy' Other phy drivers select USB_COMMON for this, so let's do the same here. Fixes: 7e0540f41332 ("phy: rcar-gen3-usb2: check dr_mode for otg mode") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/phy/renesas/Kconfig | 2 ++ 1 file changed, 2 insertions(+) -- 2.9.0