| Message ID | 20171102164933.110292-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | platform/x86: intel_telemetry: add back linux/io.h inclusion | expand |
On Thu, Nov 02, 2017 at 05:49:27PM +0100, Arnd Bergmann wrote: > This one wasn't redundant after all, as shown by this randconfig > build error: > > drivers/platform/x86/intel_telemetry_pltdrv.c: In function 'telem_evtlog_read': > drivers/platform/x86/intel_telemetry_pltdrv.c:900:20: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration] > > We should generally include exactly the set of headers that declare > the interfaces we use, so this adds back the missing include to > get it to compile again. Thanks Arnd, Andy already caught this and has it queued. -- Darren Hart VMware Open Source Technology Center
diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c index 678abf2e9e92..45f790a22ca2 100644 --- a/drivers/platform/x86/intel_telemetry_pltdrv.c +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c @@ -16,6 +16,7 @@ * It used the PUNIT and PMC IPC interfaces for configuring the counters. * The accumulated results are fetched from SRAM. */ +#include <linux/io.h> #include <linux/module.h> #include <linux/platform_device.h>
This one wasn't redundant after all, as shown by this randconfig build error: drivers/platform/x86/intel_telemetry_pltdrv.c: In function 'telem_evtlog_read': drivers/platform/x86/intel_telemetry_pltdrv.c:900:20: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration] We should generally include exactly the set of headers that declare the interfaces we use, so this adds back the missing include to get it to compile again. Fixes: a5e50220edbd ("platform/x86: intel_telemetry: cleanup redundant headers") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/platform/x86/intel_telemetry_pltdrv.c | 1 + 1 file changed, 1 insertion(+) -- 2.9.0