From patchwork Fri Nov 3 03:10:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Nhan Ngoc. Nguyen" X-Patchwork-Id: 117848 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp2929247qgn; Thu, 2 Nov 2017 20:10:20 -0700 (PDT) X-Google-Smtp-Source: ABhQp+RtSYWpu9e/7gAz4lniWpmvy7BMkBSmzXKC8Sza62+vG6JBvYcMCebjQTDQDfgFrglzRUff X-Received: by 10.98.206.68 with SMTP id y65mr6165581pfg.138.1509678620105; Thu, 02 Nov 2017 20:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509678620; cv=none; d=google.com; s=arc-20160816; b=gp+ERUs+OvpDTwv73A6QH9JMv+yXrgQ3W6CycFAqmfFLl32aGkphOHw0Ygx/Ug8Z9d GOR5fjmMAWxlOJ9gqK6+lD63S/DfnSEwZWEkZ0DGnnoLnBCyxNQvgzdY8EJ12mJtn9TJ R+YbHxamJoexOJ4WmFsugT34WX9tCkLy35x6PWa6UV5VkfrwQhh6E8cJb9HAxgh1R76M U8XJfgING834JVPjhhgcZnI+U9S8LQjldQFLB9oq/LhdsFQtutHgH7VOvPBuJQSZtqzm zVS+qsR9tuzVSJCoOMuLsno5EpdhzIYYIIzVa4+xQCOSE9P3oX+dgEQ++1eMSZy6P7nw cZvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:message-id:date:subject:cc:to :from:dkim-signature:arc-authentication-results; bh=QdaeBohb3/t+TyC8a4NL4iDCUjYyRWbBm0EUdGFs4bI=; b=DskE8rtRlLimyx01d7b5OovSKqaumnZMo4IgNsZpgis8kBlcbJC0sgfQm7kC0F73Qq JIamgqP+qhuFsQRafbYGi7R5e42US9lFBJI0EzYIKUDwojlcrHBCMasVx5hMRYSoOm3J 77ppCy4fkiZsfs4y6xN2K4FCU2o5uPhfXasYBusGvYq8NfbfWdyKIA7rCS454nxSsau+ qegmoSsiLlYx4LAUQYBLkj3SD3X92o0JgsyPPlQknaaQRaSWe7F7x7usxYWD4hH12QU2 9PcQwVT1USGpTZ3AdsxiK9+dpbc8L3Gpdv+DOZ7TJ1TEGQzgQ4JLQPOqxjDQqwSrY6Ug urmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@renesasgroup.onmicrosoft.com header.s=selector1-renesas-com header.b=pTYgSedN; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z72si5332730pff.170.2017.11.02.20.10.19; Thu, 02 Nov 2017 20:10:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@renesasgroup.onmicrosoft.com header.s=selector1-renesas-com header.b=pTYgSedN; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934708AbdKCDKS (ORCPT + 9 others); Thu, 2 Nov 2017 23:10:18 -0400 Received: from relmlor2.renesas.com ([210.160.252.172]:64733 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751507AbdKCDKR (ORCPT ); Thu, 2 Nov 2017 23:10:17 -0400 Received: from unknown (HELO relmlir4.idc.renesas.com) ([10.200.68.154]) by relmlie1.idc.renesas.com with ESMTP; 03 Nov 2017 12:10:15 +0900 Received: from relmlii1.idc.renesas.com (relmlii1.idc.renesas.com [10.200.68.65]) by relmlir4.idc.renesas.com (Postfix) with ESMTP id 6DF7D5DAE0; Fri, 3 Nov 2017 12:10:15 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.44,336,1505746800"; d="scan'208";a="261197307" Received: from mail-hk2apc01lp0212.outbound.protection.outlook.com (HELO APC01-HK2-obe.outbound.protection.outlook.com) ([65.55.88.212]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 03 Nov 2017 12:10:14 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QdaeBohb3/t+TyC8a4NL4iDCUjYyRWbBm0EUdGFs4bI=; b=pTYgSedNqoVfpI9w9Sbd6tUECJNXHzgvDuokdosoOUFuOxriLOMx8fZdQslfZ4Lk7A6aWCCDmmb0szd5iyUeuhRMI7O8IdjSy+2LgP2mTW3Niy+cEz5yYO7A2ht5dNc0U1RR5/hm39pNQC/4qYImbLRtr97jn3aYHvYX64big2w= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=nhan.nguyen.yb@renesas.com; Received: from RVC-LT-408230.rvc.renesas.com (210.245.28.11) by PS1PR0601MB1337.apcprd06.prod.outlook.com (2a01:111:e400:7a37::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Fri, 3 Nov 2017 03:10:07 +0000 From: Nhan Nguyen To: gregkh@linuxfoundation.org Cc: toru.oishi.zj@renesas.com, John Stultz , David Airlie , Archit Taneja , Wolfram Sang , Lars-Peter Clausen , Laurent Pinchart , dri-devel@lists.freedesktop.org, stable@vger.kernel.org, Thong Ho , Nhan Nguyen Subject: [PATCH 4.9.y 1/3] drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be reused internally Date: Fri, 3 Nov 2017 10:10:26 +0700 Message-Id: <20171103031026.11224-1-nhan.nguyen.yb@renesas.com> X-Mailer: git-send-email 2.9.3.windows.1 MIME-Version: 1.0 X-Originating-IP: [210.245.28.11] X-ClientProxiedBy: SG2PR01CA0089.apcprd01.prod.exchangelabs.com (2603:1096:3:15::15) To PS1PR0601MB1337.apcprd06.prod.outlook.com (2a01:111:e400:7a37::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9fa309ff-c726-4e5d-ea50-08d522686414 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603199); SRVR:PS1PR0601MB1337; X-Microsoft-Exchange-Diagnostics: 1; PS1PR0601MB1337; 3:+OOJXcTTbihC7fK//C1vivlpwlJDztcg5/MYPZDcVYiNVVmlJYJH9YlRMivlZqGbSgg7Xg/0P2f/mTBc+asMHT/lyVllABh3fZT/EVNrW20WVL+T21zBVL6UnOrwaCslJqLuVUXvVQkX2hNmw3j4YCw8xxd7BQUC2z6YGNq2C7i0V5s4eIQ0NHahaTDyOHm+aPuULNIwWfuTmI9N1EC6VdrBeqIPBw/5KOMZymMwCCMAaUoXOO91U9wvDL1+4w6O; 25:EICgXpcAPXYXYptmoesCLvlk7Q0sYgsv6O6+hwNyufp5pSABttqeuzhqEQw+QU0Wv87rHhY4XU8R8S1JL2K5hXrTmsphhWudFOYXGxPs6/8T5UtgJKxtveDd4wTI2cIiagqeKjdZnbhz/YoyQGkBDNNnorKFB9IxNol6XpooII9HA4hTOhKEQ4IGJLXv+jvp0nX1qwLOFdcQd12t05lIek2jsGXQJ0eDSvru0IvbAupoVzo9Z+D08sjB9irdamlgvipikgqs1PBBmcT6WiSivj+Z63clTvmm1W2hEkNtHragowJL2jKvDPIpXC9zLbDafO0iUrJDwkiUMi1r66WIfg==; 31:j0DauHdsq2timD/ilIwle4vDfcYpZrxb/r02mTDh8oIrT4m4tyumxcmvZtEsL0DYfCPSUlcbpYVZN+dsSUqeVDwAByTXE+GG5Fk5+/dekYtVHPMXEYpketxHMefOwR3fL6wyZJ/iIm29jtO/f4xUmkek83hrap/J8bX22Xj/YDJ7cmXl7vgdDn8HPSTDUI7YXdPy9rS/QGMkLyqm0dvsEg26g5D24iTg5zH3GCNtQlo= X-MS-TrafficTypeDiagnostic: PS1PR0601MB1337: X-Microsoft-Exchange-Diagnostics: 1; PS1PR0601MB1337; 20:asY7SayvMNeZ3Ojb9xGKGKFUHCzNNzVsJvp812uv6iQjJN9XdmPhVz0ukdNjR/1DPjELzJ6xjOjkf/Sw9pYwXt6EyoRjWsppjzqgIp8Sihv5NT++/yFsngMlHDKTpWPs9D0weeQywIoGvgG94Jkuqx3vCjlkrHH58/LRCsTRqZZToDy9emY/sr63EASYZFBLt0LDtfhtUNbcpEOHOYzIuvPmBteSkwnmQSQEtfHSPQxqkwAzwzkXS8ulbh58tFEeZuFU1slhLqCQLiA7Fs4d9EGFAXpxzDVqGtkz7AsnKqKyp7Vj9yzm6PKZ0OcMli6/x9RRYxEibTg/bOJ+P5Cax4xnt7eyZ8bIPPGesmfWnfQafBSXajjEI9mDLlfhg82tQzear6rWb2MI5YSeoO0C8Q/NywzOldUlsMI6klVFHlIdegocp7HJO8ij1+GxejZhDFLxm62YgazqpgpybP050TaUtJ4W7REgzrZgvYLjkPsm5TjfqbA5WmLFZrphddsN; 4:7v9ors4fUOUuWiuB9iM+W0d7XFMeFdFjLs1h747RzifMSmDdRt/KCzsyDJUUxoEvPjEX7la2SYviwPkWc3IJk6ff04HfTirOhjc5OgMH8pCn2S4HjskUcD0ZsjLQHni15aowUN2EnJ6RcbJzNiXABXIB+4S+A6mLcTW5T6/ZqDkQZlz2OnCrMFoP159c0UTct+8iE6hy330pOQJO+Whux4gaYPhHRfwNfDptXnmhXGJ1NjVx9mzn1OBaC3iEvO2gqK7aXTxN9sH2dzZT77nwMn5K1v5/HF+wrbMLrTP8zl7HzRyjsql0UUQ0itURfPBWT0+Wsym1g+YkHDW9vfDhR3QPpg/drAHkqLafa9cGAD4= X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(217544274631240); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231021)(100000703101)(100105400095)(6055026)(6041248)(20161123558100)(20161123564025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:PS1PR0601MB1337; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:PS1PR0601MB1337; X-Forefront-PRVS: 0480A51D4A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(39860400002)(346002)(376002)(189002)(199003)(86362001)(50986999)(33646002)(189998001)(6486002)(4326008)(97736004)(6916009)(53936002)(2361001)(6306002)(107886003)(103116003)(6666003)(2351001)(101416001)(106356001)(3846002)(1076002)(6116002)(5660300001)(105586002)(316002)(16586007)(54906003)(305945005)(2906002)(7736002)(8676002)(50466002)(25786009)(50226002)(36756003)(5003940100001)(15760500003)(8936002)(478600001)(68736007)(47776003)(966005)(81166006)(48376002)(16526018)(81156014)(66066001); DIR:OUT; SFP:1102; SCL:1; SRVR:PS1PR0601MB1337; H:RVC-LT-408230.rvc.renesas.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; PS1PR0601MB1337; 23:alSqUuRW4fiBzHqaDhYY+c06hMJAvziPgHVmDB7Ch5IJQkPboEiavTLMkqzjXlyrrXrgeHAwlZhJpgNdtdRz1g5DqP1BeK6SqRdCDc8PzTkjO8yGcDTeh2SrLHpe/CHZKmPtY0u27e+ysGe4jbYeaYkI+tEzLtQaeRcxr5JkUFcytFmdz06IHAUE4uON/sby1R4SrTjgc5AeOW5gyi8OV2FYZZH/i70ZXb2InprLnGSoPekZiEGmRfIRzPHd0qwdnGOXLp2dHapEoPG7I2rC4JqRGMeSK7TR/nIRdXT/oeC5yWxeFzdSxbCTG5KapnouVWqshdkDO0uFPA332sNHjyYqB30IuhnRf265sQbY1vdpX+SzTCoxW1SCMdcXjD8dE7MMxJvR0du0cUhfA5dEmb7uorLOY+2g4qyiVgiZHKdIYrVyIIHnfvaeqE7VL0V8Jvr9OUpJeUZd7zmQV41ReRJw1V3IdBMHuNhh/hI/10O/TIxBz0l5REU1Wi3e2xEi9bO2SiaPVW86E/ydWcDP31J1Kz+3VwkKgEFCztLQNaRLiTeKSr6krKoszLYH73+CS6y2sKdCb1U1Qt0UQE/NhNNehPqn69XP3L9I0Tcr5vWiQHvIgqkoUqOov7MvNCrdMDrhfsYlZIMiCc4cTkusP28gplfdHB+G37X/F4PjHGdMwjHBShBORyaWDw2WJA0KNKZO5p6I6lisT8h7yNy6swGo/Xma+lREMHRrLQEpqxWD6VFFxcQU0b2dZZzDPxhc+CWNKUz7rbl5pGJ40YYTDrCW54T+bGpPe+AZH3H7OWpVlJINTD188BNuqY9PQYPfO3zPNRgvsoYSr32s9nekyI2Wd4Y5Ju3nXOdiovnl4qhQMX/e8n7n+Iqan8KVpgSFpLLOg/Bk26XV4sNbt5Lu1PIORTjKO+Efw7Ho58TL9UFvrj55v7EK9UdxMQpRiwzH5S2hIvVh16qG1So8rCZ0EuoCwmZtRFBWBGlw6j6qFyQnnAWzKLIHY+jAaoFpq4hiOl6Uje9HpjDeXGAFxNYytMOU6ZK04Pn7MLLmuBShRO6fe5G0erdmJNsnZYDbBFmHJn94r/IFAehrXKdoEkzO+Gslv8nDQmQcUijSVabqglsKiZOAzqkqU4yJLdBotDY8MXhBIRnOd71DKoH5VGXoSpMSPybT2qc9JcALpAFRhA8= X-Microsoft-Exchange-Diagnostics: 1; PS1PR0601MB1337; 6:bIEv6zQgHHq9h/G2xbvNsqinB/62V9tnqx+mUnaXicdTl3xNXjfYzvbASCYYRGbD2zuQ7YTPf3/vrwMhwAU3uk84NABPgTRUVeYDMDbK8lLUCvDGr4KZIjaH5ObWl03Ks8YPK+LQcEQT2esMNeBWQHtCxXjHcndTz8WiB6M067ley7T8Eby1ZUpBCsehAMVxbTHhutHf7BBZq5ZDcFKder5gvWph7XqCObFcW3h6YdmRX9f6BNXtqvR4Lik3gzs38sgEaTFLZbSEM0TStS716ZpKmpVAptzVLKqj5NbrMwdoa9zVgoTNolou2dSDN+36zi8vtsjEStgVnR8vZJIdzdTnywa5YRiW+lrsoAbFJpE=; 5:7UwXqX4i8aj3QmaXIduQoi9MlIYFijFae4ZFztwZiSbjGjVzSkO2WbiaLVZNPwu1j7cwFfZrLNCNFo5yEBtwQ/B96rvMAd1E0mnTN7td54EDcRtniNTQZhKEi9H0pasKMFi5p01DMR89npGt8y74/PJuW+16LOyHx9N1DrF0KsQ=; 24:1lcljkJr31WSVB64EdeEaQ18bQ9T4mAneSNSDorXwmH522hBH4c+sRzi6zPmoL3WXc+YnH5LnwEPkqlmCcH91L5IKR6XhfenuzvOwwLo3fc=; 7:W5Ggor4iqKb/6bQK2ToPxLdISLlVsW/c1D4G55Igqp11yVLQN57LJ3UCXSO7MhDvdoPhFrS5mY9ACP7674dNAo3G94KayKPc9VcaY8SjDLs5ynL6OKwPJ6uCbU75e9mjQQUb8kzqcfJPEBwtN7hfuw7unASdiwlnZ+eC4MdGyseMpY0abfAtTX/pEvlSlCwJb/Tt40wQpCRpXGa9X19e4R1ZaJJB91CTkF0vcao8Z4wntAdzrRUqmU2cknjDHjty SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; PS1PR0601MB1337; 20:BTHWuPE9jT4s+WvO6pldYcjrs3jK7HtjIaQNgW/uBx2hWZJXYhcfCWhMhzm8MJITHWjqIqq94fI1dG+mySjzWfIvtfB7fmqctpYCt2h2mrXXeC7Qcl7y/ZtjlddfhWQmIBbztd9V5APIibDJPHxjATPTHCQIcOvZHKSZL32TCeI= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2017 03:10:07.6640 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9fa309ff-c726-4e5d-ea50-08d522686414 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR0601MB1337 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: John Stultz commit 651e4769ba2a9f20c4b8a823ae2727bf7fa9c9f0 upstream. In chasing down issues with EDID probing, I found some duplicated but incomplete logic used to power the chip on and off. This patch refactors the adv7511_power_on/off functions, so they can be used for internal needs. Cc: David Airlie Cc: Archit Taneja Cc: Wolfram Sang Cc: Lars-Peter Clausen Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Cc: stable@vger.kernel.org Signed-off-by: John Stultz Signed-off-by: Archit Taneja Signed-off-by: Thong Ho Signed-off-by: Nhan Nguyen Link: http://patchwork.freedesktop.org/patch/msgid/1484614372-15342-5-git-send-email-john.stultz@linaro.org --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 72939d4..545ceff 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -325,7 +325,7 @@ static void adv7511_set_link_config(struct adv7511 *adv7511, adv7511->rgb = config->input_colorspace == HDMI_COLORSPACE_RGB; } -static void adv7511_power_on(struct adv7511 *adv7511) +static void __adv7511_power_on(struct adv7511 *adv7511) { adv7511->current_edid_segment = -1; @@ -354,6 +354,11 @@ static void adv7511_power_on(struct adv7511 *adv7511) regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2, ADV7511_REG_POWER2_HPD_SRC_MASK, ADV7511_REG_POWER2_HPD_SRC_NONE); +} + +static void adv7511_power_on(struct adv7511 *adv7511) +{ + __adv7511_power_on(adv7511); /* * Most of the registers are reset during power down or when HPD is low. @@ -362,21 +367,23 @@ static void adv7511_power_on(struct adv7511 *adv7511) if (adv7511->type == ADV7533) adv7533_dsi_power_on(adv7511); - adv7511->powered = true; } -static void adv7511_power_off(struct adv7511 *adv7511) +static void __adv7511_power_off(struct adv7511 *adv7511) { /* TODO: setup additional power down modes */ regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER, ADV7511_POWER_POWER_DOWN, ADV7511_POWER_POWER_DOWN); regcache_mark_dirty(adv7511->regmap); +} +static void adv7511_power_off(struct adv7511 *adv7511) +{ + __adv7511_power_off(adv7511); if (adv7511->type == ADV7533) adv7533_dsi_power_off(adv7511); - adv7511->powered = false; }