[v6,1/2] staging: ion: reorder include

Message ID 1509983985-20950-2-git-send-email-benjamin.gaignard@linaro.org
State New
Headers show
Series
  • staging: ion: get one device per heap
Related show

Commit Message

Benjamin Gaignard Nov. 6, 2017, 3:59 p.m.
Put include in alphabetic order

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

---
 drivers/staging/android/ion/ion.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

-- 
2.7.4

Comments

Laura Abbott Nov. 9, 2017, 9:02 p.m. | #1
On 11/06/2017 07:59 AM, Benjamin Gaignard wrote:
> Put include in alphabetic order

> 


Acked-by: Laura Abbott <labbott@redhat.com>


> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

> ---

>   drivers/staging/android/ion/ion.c | 14 +++++++-------

>   1 file changed, 7 insertions(+), 7 deletions(-)

> 

> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c

> index a7d9b0e..fda9756 100644

> --- a/drivers/staging/android/ion/ion.c

> +++ b/drivers/staging/android/ion/ion.c

> @@ -15,28 +15,28 @@

>    *

>    */

>   

> +#include <linux/anon_inodes.h>

> +#include <linux/debugfs.h>

>   #include <linux/device.h>

> +#include <linux/dma-buf.h>

>   #include <linux/err.h>

> +#include <linux/export.h>

>   #include <linux/file.h>

>   #include <linux/freezer.h>

>   #include <linux/fs.h>

> -#include <linux/anon_inodes.h>

> +#include <linux/idr.h>

>   #include <linux/kthread.h>

>   #include <linux/list.h>

>   #include <linux/memblock.h>

>   #include <linux/miscdevice.h>

> -#include <linux/export.h>

>   #include <linux/mm.h>

>   #include <linux/mm_types.h>

>   #include <linux/rbtree.h>

> -#include <linux/slab.h>

> +#include <linux/sched/task.h>

>   #include <linux/seq_file.h>

> +#include <linux/slab.h>

>   #include <linux/uaccess.h>

>   #include <linux/vmalloc.h>

> -#include <linux/debugfs.h>

> -#include <linux/dma-buf.h>

> -#include <linux/idr.h>

> -#include <linux/sched/task.h>

>   

>   #include "ion.h"

>   

>
Greg KH Nov. 28, 2017, 1:20 p.m. | #2
On Mon, Nov 06, 2017 at 04:59:44PM +0100, Benjamin Gaignard wrote:
> Put include in alphabetic order


Why???

That should not matter at all.

I'll take this, but really, ick ick ick ick ick.

Patch

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index a7d9b0e..fda9756 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -15,28 +15,28 @@ 
  *
  */
 
+#include <linux/anon_inodes.h>
+#include <linux/debugfs.h>
 #include <linux/device.h>
+#include <linux/dma-buf.h>
 #include <linux/err.h>
+#include <linux/export.h>
 #include <linux/file.h>
 #include <linux/freezer.h>
 #include <linux/fs.h>
-#include <linux/anon_inodes.h>
+#include <linux/idr.h>
 #include <linux/kthread.h>
 #include <linux/list.h>
 #include <linux/memblock.h>
 #include <linux/miscdevice.h>
-#include <linux/export.h>
 #include <linux/mm.h>
 #include <linux/mm_types.h>
 #include <linux/rbtree.h>
-#include <linux/slab.h>
+#include <linux/sched/task.h>
 #include <linux/seq_file.h>
+#include <linux/slab.h>
 #include <linux/uaccess.h>
 #include <linux/vmalloc.h>
-#include <linux/debugfs.h>
-#include <linux/dma-buf.h>
-#include <linux/idr.h>
-#include <linux/sched/task.h>
 
 #include "ion.h"