[v2,1/2] alpha: osf_sys.c: fix put_tv32 regression

Message ID 20171108150339.1013031-1-arnd@arndb.de
State Accepted
Commit 645a05a72c366529bf7e566b32ec806744883597
Headers show
  • [v2,1/2] alpha: osf_sys.c: fix put_tv32 regression
Related show

Commit Message

Arnd Bergmann Nov. 8, 2017, 3:02 p.m.
There was a typo in the new version of put_tv32() that caused an unguarded
access of a user space pointer, and failed to return the correct result in
gettimeofday(), wait4(), usleep_thread() and old_adjtimex().

This fixes it to give the correct behavior again.

Cc: stable@vger.kernel.org
Fixes: 1cc6c4635e9f ("osf_sys.c: switch handling of timeval32/itimerval32 to copy_{to,from}_user()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

v2: fix incorrect changelog description
 arch/alpha/kernel/osf_sys.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c
index ce3a675c0c4b..75a5c35a2067 100644
--- a/arch/alpha/kernel/osf_sys.c
+++ b/arch/alpha/kernel/osf_sys.c
@@ -964,8 +964,8 @@  static inline long
 put_tv32(struct timeval32 __user *o, struct timeval *i)
 	return copy_to_user(o, &(struct timeval32){
-				.tv_sec = o->tv_sec,
-				.tv_usec = o->tv_usec},
+				.tv_sec = i->tv_sec,
+				.tv_usec = i->tv_usec},
 			    sizeof(struct timeval32));