From patchwork Wed Nov 8 20:49:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Levin, Alexander \(Sasha Levin\)" X-Patchwork-Id: 118337 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp5762689qgn; Wed, 8 Nov 2017 12:51:46 -0800 (PST) X-Google-Smtp-Source: ABhQp+StqFqp1BukJvx2GeB1PIX3KmkoMmzTM7KtyJgMiJHRNxiRmdop4BnWpkGZjeVS8cWbW+1b X-Received: by 10.98.76.147 with SMTP id e19mr1761031pfj.73.1510174306179; Wed, 08 Nov 2017 12:51:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510174306; cv=none; d=google.com; s=arc-20160816; b=yoKwRlPyxeVPyzffR1yFaOgtS0ptMh8m2ADm7u+KXGVTdODdS1lTWAwARp+aFHHTEl 5YFBG0xzVajO9zL5Mhny07KXye0PrsJ0fkAp8isQLhUwW8RJKxFnUsl34UDhRpQU9Nx9 IFmM0YxVyIeaRkeH4IjxGWtPVRBX2fx/9GIXmdl+BBIBT63nG7ZuJZanG4/ONyBCn2iP abDrtTxfLuLzkNeMqR39/4kHBHOKUL/3GY054p4Lxb+fCEBrbBfqjhSpFOt92F65QmO+ NQxz/Z2ZjRoTZ5RSOxBNn8sepdd1h8cbzi3EcrJbKinNwss4p+Iy4DS8P5ziex2SUqoS 4XzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature :dkim-signature:dkim-signature:arc-authentication-results; bh=TcMqPILiZvQ5ZoqARC40FWbpOh5ER961XqyetXLPhyI=; b=ZSJ5yEbb/z4f6AB5VyiDS/3gMK594LqzfEDVK1VnV11ST2w+trSualt5HZ/FEQI9PL C02z1MiFAZuYJ4qZoA2m/xEyzYsZhkB5JkLCFRvqAiA/8gxvNHDtIQ9n4hZCFoZhDKbI Yd1BgNV80a6eJf+Xlb/HTruzIQEj9gLy8oBIrYaxvTVvO+AOBkcQFx+83DBbWsj1lwoO NXVqhmEGULcrH4q/okgvAv1pLTF0Nr9WQzl68FyKuV62zzzo2epjay/vGk2+6Au1stPV mZgRSkGNeaPKwJSr7oW7K+/0ZYtW1cYlc87TsYjI6gQXLNmBNWli3ExqtsMPK+XDRYW+ bg2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@one.verizon.com header.s=corp header.b=FoxwOQUH; dkim=pass header.i=@verizon.com header.s=corp header.b=dK/NNmQu; dkim=pass header.i=@verizon.com header.s=corp header.b=dK/NNmQu; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m1si4607659pls.217.2017.11.08.12.51.45; Wed, 08 Nov 2017 12:51:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@one.verizon.com header.s=corp header.b=FoxwOQUH; dkim=pass header.i=@verizon.com header.s=corp header.b=dK/NNmQu; dkim=pass header.i=@verizon.com header.s=corp header.b=dK/NNmQu; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752510AbdKHUvo (ORCPT + 9 others); Wed, 8 Nov 2017 15:51:44 -0500 Received: from omzsmtpe03.verizonbusiness.com ([199.249.25.208]:17498 "EHLO omzsmtpe03.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbdKHUvn (ORCPT ); Wed, 8 Nov 2017 15:51:43 -0500 X-Greylist: delayed 307 seconds by postgrey-1.27 at vger.kernel.org; Wed, 08 Nov 2017 15:51:42 EST DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=one.verizon.com; i=@one.verizon.com; q=dns/txt; s=corp; t=1510174303; x=1541710303; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2eArfjZiGZeloSintZ5py3lnD5Ucu6QtoO7C2cvineo=; b=FoxwOQUH9/hL33HgCGlr+PIT2tAKhJY8bQUqhTHU49Es8608JTTq/jHZ JNlyazEGlgpbWlOFcE/DXqaufr20k+7Qn3SPslLhuIszT7c6iJlmIFsLo zGIHRtH08eqkd+oaI0wJfdfsTHukqx/oLAeb0bLCGUDSZJrBpK9mfB/fE k=; Received: from unknown (HELO fldsmtpi02.verizon.com) ([166.68.71.144]) by omzsmtpe03.verizonbusiness.com with ESMTP; 08 Nov 2017 20:50:39 +0000 Received: from rogue-10-255-192-101.rogue.vzwcorp.com (HELO apollo.verizonwireless.com) ([10.255.192.101]) by fldsmtpi02.verizon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Nov 2017 20:49:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1510174197; x=1541710197; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2eArfjZiGZeloSintZ5py3lnD5Ucu6QtoO7C2cvineo=; b=dK/NNmQuDUomkMCXn30ai5O/lBgnOo4NBoIlQiAypoB3Ziyvl620KusA CXc2W1Dwl0+7l4ubsG5wsRUaibnN0IPPPanEHNbQpi5CY4IUu4Rb0/O+G b/ggg5e/EwNm2dp5SNliomxIUuRioFQxArGW1MeDuefzGznUkNLEyQHuM 8=; Received: from mariner.tdc.vzwcorp.com (HELO eris.verizonwireless.com) ([10.254.88.84]) by apollo.verizonwireless.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Nov 2017 15:49:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1510174197; x=1541710197; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2eArfjZiGZeloSintZ5py3lnD5Ucu6QtoO7C2cvineo=; b=dK/NNmQuDUomkMCXn30ai5O/lBgnOo4NBoIlQiAypoB3Ziyvl620KusA CXc2W1Dwl0+7l4ubsG5wsRUaibnN0IPPPanEHNbQpi5CY4IUu4Rb0/O+G b/ggg5e/EwNm2dp5SNliomxIUuRioFQxArGW1MeDuefzGznUkNLEyQHuM 8=; X-Host: mariner.tdc.vzwcorp.com Received: from ohtwi1exh003.uswin.ad.vzwcorp.com ([10.144.218.45]) by eris.verizonwireless.com with ESMTP/TLS/AES128-SHA256; 08 Nov 2017 20:49:57 +0000 Received: from tbwexch09apd.uswin.ad.vzwcorp.com (153.114.162.33) by OHTWI1EXH003.uswin.ad.vzwcorp.com (10.144.218.45) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 8 Nov 2017 15:49:57 -0500 Received: from OMZP1LUMXCA18.uswin.ad.vzwcorp.com (144.8.22.196) by tbwexch09apd.uswin.ad.vzwcorp.com (153.114.162.33) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Wed, 8 Nov 2017 15:49:56 -0500 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com (144.8.22.195) by OMZP1LUMXCA18.uswin.ad.vzwcorp.com (144.8.22.196) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Wed, 8 Nov 2017 14:49:56 -0600 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) by OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) with mapi id 15.00.1263.000; Wed, 8 Nov 2017 14:49:56 -0600 From: "Levin, Alexander (Sasha Levin)" To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Roger Quadros , Chanwoo Choi , "Levin, Alexander (Sasha Levin)" Subject: [PATCH AUTOSEL for-4.9 02/53] extcon: palmas: Check the parent instance to prevent the NULL Thread-Topic: [PATCH AUTOSEL for-4.9 02/53] extcon: palmas: Check the parent instance to prevent the NULL Thread-Index: AQHTWNMh2j72wduVWE+OzikA7duxfQ== Date: Wed, 8 Nov 2017 20:49:55 +0000 Message-ID: <20171108204940.27321-2-alexander.levin@verizon.com> References: <20171108204940.27321-1-alexander.levin@verizon.com> In-Reply-To: <20171108204940.27321-1-alexander.levin@verizon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Roger Quadros [ Upstream commit 9fe172b9be532acc23e35ba693700383ab775e66 ] extcon-palmas must be child of palmas and expects parent's drvdata to be valid. Check for non NULL parent drvdata and fail if it is NULL. Not doing so will result in a NULL pointer dereference later in the probe() parent drvdata is NULL (e.g. misplaced extcon-palmas node in device tree). Signed-off-by: Roger Quadros Signed-off-by: Chanwoo Choi Signed-off-by: Sasha Levin --- drivers/extcon/extcon-palmas.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.11.0 diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c index 634ba70782de..a128fd2eb187 100644 --- a/drivers/extcon/extcon-palmas.c +++ b/drivers/extcon/extcon-palmas.c @@ -190,6 +190,11 @@ static int palmas_usb_probe(struct platform_device *pdev) struct palmas_usb *palmas_usb; int status; + if (!palmas) { + dev_err(&pdev->dev, "failed to get valid parent\n"); + return -EINVAL; + } + palmas_usb = devm_kzalloc(&pdev->dev, sizeof(*palmas_usb), GFP_KERNEL); if (!palmas_usb) return -ENOMEM;