diff mbox series

[4/7] perf tests: Set evlist of test__basic_mmap() to !overwrite

Message ID 20171113013809.212417-5-wangnan0@huawei.com
State Accepted
Commit 301d724aa19add1c0cf3ec8cad0d10151d30393f
Headers show
Series perf tools: Clarify overwrite and backward, bugfix | expand

Commit Message

Wang Nan Nov. 13, 2017, 1:38 a.m. UTC 
In this test, a large ring buffer is required so all events can feed into,
so overwrite or not is meaningless.

Change to !overwrite so following commits can remove this argument.

Signed-off-by: Wang Nan <wangnan0@huawei.com>

---
 tools/perf/tests/mmap-basic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.10.1

Comments

Arnaldo Carvalho de Melo Nov. 13, 2017, 6:31 p.m. UTC | #1 
Em Mon, Nov 13, 2017 at 01:38:06AM +0000, Wang Nan escreveu:
> In this test, a large ring buffer is required so all events can feed into,

> so overwrite or not is meaningless.

> 

> Change to !overwrite so following commits can remove this argument.


applied
 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>

> ---

>  tools/perf/tests/mmap-basic.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/tools/perf/tests/mmap-basic.c b/tools/perf/tests/mmap-basic.c

> index bc8a70e..667d696 100644

> --- a/tools/perf/tests/mmap-basic.c

> +++ b/tools/perf/tests/mmap-basic.c

> @@ -93,7 +93,7 @@ int test__basic_mmap(struct test *test __maybe_unused, int subtest __maybe_unuse

>  		expected_nr_events[i] = 1 + rand() % 127;

>  	}

>  

> -	if (perf_evlist__mmap(evlist, 128, true) < 0) {

> +	if (perf_evlist__mmap(evlist, 128, false) < 0) {

>  		pr_debug("failed to mmap events: %d (%s)\n", errno,

>  			 str_error_r(errno, sbuf, sizeof(sbuf)));

>  		goto out_delete_evlist;

> -- 

> 2.10.1
diff mbox series

Patch

diff --git a/tools/perf/tests/mmap-basic.c b/tools/perf/tests/mmap-basic.c
index bc8a70e..667d696 100644
--- a/tools/perf/tests/mmap-basic.c
+++ b/tools/perf/tests/mmap-basic.c
@@ -93,7 +93,7 @@  int test__basic_mmap(struct test *test __maybe_unused, int subtest __maybe_unuse
 		expected_nr_events[i] = 1 + rand() % 127;
 	}
 
-	if (perf_evlist__mmap(evlist, 128, true) < 0) {
+	if (perf_evlist__mmap(evlist, 128, false) < 0) {
 		pr_debug("failed to mmap events: %d (%s)\n", errno,
 			 str_error_r(errno, sbuf, sizeof(sbuf)));
 		goto out_delete_evlist;