[3/7] perf tests: Set evlist of test__sw_clock_freq() to !overwrite

Message ID 20171113013809.212417-4-wangnan0@huawei.com
State New
Headers show
Series
  • perf tools: Clarify overwrite and backward, bugfix
Related show

Commit Message

Wang Nan Nov. 13, 2017, 1:38 a.m.
Unsetting overwrite when calling perf_evlist__mmap is harmless. This commit
passes false to it, makes following commits eliminate the overwrite argument
easier.

Signed-off-by: Wang Nan <wangnan0@huawei.com>

---
 tools/perf/tests/sw-clock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.10.1

Comments

Arnaldo Carvalho de Melo Nov. 13, 2017, 6:31 p.m. | #1
Em Mon, Nov 13, 2017 at 01:38:05AM +0000, Wang Nan escreveu:
> Unsetting overwrite when calling perf_evlist__mmap is harmless. This commit

> passes false to it, makes following commits eliminate the overwrite argument

> easier.


applied
 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>

> ---

>  tools/perf/tests/sw-clock.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/tools/perf/tests/sw-clock.c b/tools/perf/tests/sw-clock.c

> index d88511f..c468e6c 100644

> --- a/tools/perf/tests/sw-clock.c

> +++ b/tools/perf/tests/sw-clock.c

> @@ -77,7 +77,7 @@ static int __test__sw_clock_freq(enum perf_sw_ids clock_id)

>  		goto out_delete_evlist;

>  	}

>  

> -	err = perf_evlist__mmap(evlist, 128, true);

> +	err = perf_evlist__mmap(evlist, 128, false);

>  	if (err < 0) {

>  		pr_debug("failed to mmap event: %d (%s)\n", errno,

>  			 str_error_r(errno, sbuf, sizeof(sbuf)));

> -- 

> 2.10.1

Patch

diff --git a/tools/perf/tests/sw-clock.c b/tools/perf/tests/sw-clock.c
index d88511f..c468e6c 100644
--- a/tools/perf/tests/sw-clock.c
+++ b/tools/perf/tests/sw-clock.c
@@ -77,7 +77,7 @@  static int __test__sw_clock_freq(enum perf_sw_ids clock_id)
 		goto out_delete_evlist;
 	}
 
-	err = perf_evlist__mmap(evlist, 128, true);
+	err = perf_evlist__mmap(evlist, 128, false);
 	if (err < 0) {
 		pr_debug("failed to mmap event: %d (%s)\n", errno,
 			 str_error_r(errno, sbuf, sizeof(sbuf)));