| Message ID | 20171115111932.22507-1-ard.biesheuvel@linaro.org |
|---|---|
| State | Accepted |
| Commit | ca094756267ef53ce3e071a45cc2ad545dbb97da |
| Headers | show |
| Series | [edk2] EmbeddedPkg: add mx66u1g45g nor flash info | expand |
Hi, 2017-11-15 12:19 GMT+01:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>: > From: Pipat Methavanitpong <methavanitpong.pipat@socionext.com> > > Add Macronix MX66U1G45G definition to NorFlashInfoLib > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Pipat Methavanitpong <methavanitpong.pipat@socionext.com> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > index 750f37a0e8..fb26b4f9bc 100644 > --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > @@ -57,6 +57,7 @@ STATIC CONST NOR_FLASH_INFO NorFlashIds[] = { > {L"mx25l51235f", {0xc2, 0x20, 0x1a}, 3, 256, 64 * 1024, 1024, 0}, > {L"mx25l12855e", {0xc2, 0x26, 0x18}, 3, 256, 64 * 1024, 256, 0}, > {L"mx66u51235f", {0xc2, 0x25, 0x3a}, 3, 256, 64 * 1024, 1024, 0}, > + {L"mx66u1g45g", {0xc2, 0x25, 0x3b}, 3, 256, 64 * 1024, 2048, 0}, > {L"mx66l1g45g", {0xc2, 0x20, 0x1b}, 3, 256, 64 * 1024, 2048, 0}, > /* SPANSION */ > {L"s25fl008a", {0x01, 0x02, 0x13}, 3, 256, 64 * 1024, 16, 0}, > -- Reviewed-by: Marcin Wojtas <mw@semihalf.com> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On Wed, Nov 15, 2017 at 11:19:32AM +0000, Ard Biesheuvel wrote: > From: Pipat Methavanitpong <methavanitpong.pipat@socionext.com> > > Add Macronix MX66U1G45G definition to NorFlashInfoLib > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Pipat Methavanitpong <methavanitpong.pipat@socionext.com> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > index 750f37a0e8..fb26b4f9bc 100644 > --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > @@ -57,6 +57,7 @@ STATIC CONST NOR_FLASH_INFO NorFlashIds[] = { > {L"mx25l51235f", {0xc2, 0x20, 0x1a}, 3, 256, 64 * 1024, 1024, 0}, > {L"mx25l12855e", {0xc2, 0x26, 0x18}, 3, 256, 64 * 1024, 256, 0}, > {L"mx66u51235f", {0xc2, 0x25, 0x3a}, 3, 256, 64 * 1024, 1024, 0}, > + {L"mx66u1g45g", {0xc2, 0x25, 0x3b}, 3, 256, 64 * 1024, 2048, 0}, > {L"mx66l1g45g", {0xc2, 0x20, 0x1b}, 3, 256, 64 * 1024, 2048, 0}, Hmm, I'm beginning to think we should have figured out a sorting strategy for this table ... oh well. The values match what QEMU uses, so: Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > /* SPANSION */ > {L"s25fl008a", {0x01, 0x02, 0x13}, 3, 256, 64 * 1024, 16, 0}, > -- > 2.14.1 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 16 November 2017 at 16:24, Leif Lindholm <leif.lindholm@linaro.org> wrote: > On Wed, Nov 15, 2017 at 11:19:32AM +0000, Ard Biesheuvel wrote: >> From: Pipat Methavanitpong <methavanitpong.pipat@socionext.com> >> >> Add Macronix MX66U1G45G definition to NorFlashInfoLib >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Pipat Methavanitpong <methavanitpong.pipat@socionext.com> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> --- >> EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c >> index 750f37a0e8..fb26b4f9bc 100644 >> --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c >> +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c >> @@ -57,6 +57,7 @@ STATIC CONST NOR_FLASH_INFO NorFlashIds[] = { >> {L"mx25l51235f", {0xc2, 0x20, 0x1a}, 3, 256, 64 * 1024, 1024, 0}, >> {L"mx25l12855e", {0xc2, 0x26, 0x18}, 3, 256, 64 * 1024, 256, 0}, >> {L"mx66u51235f", {0xc2, 0x25, 0x3a}, 3, 256, 64 * 1024, 1024, 0}, >> + {L"mx66u1g45g", {0xc2, 0x25, 0x3b}, 3, 256, 64 * 1024, 2048, 0}, >> {L"mx66l1g45g", {0xc2, 0x20, 0x1b}, 3, 256, 64 * 1024, 2048, 0}, > > Hmm, I'm beginning to think we should have figured out a sorting > strategy for this table ... oh well. > > The values match what QEMU uses, so: > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > Pushed as ca094756267e _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c index 750f37a0e8..fb26b4f9bc 100644 --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c @@ -57,6 +57,7 @@ STATIC CONST NOR_FLASH_INFO NorFlashIds[] = { {L"mx25l51235f", {0xc2, 0x20, 0x1a}, 3, 256, 64 * 1024, 1024, 0}, {L"mx25l12855e", {0xc2, 0x26, 0x18}, 3, 256, 64 * 1024, 256, 0}, {L"mx66u51235f", {0xc2, 0x25, 0x3a}, 3, 256, 64 * 1024, 1024, 0}, + {L"mx66u1g45g", {0xc2, 0x25, 0x3b}, 3, 256, 64 * 1024, 2048, 0}, {L"mx66l1g45g", {0xc2, 0x20, 0x1b}, 3, 256, 64 * 1024, 2048, 0}, /* SPANSION */ {L"s25fl008a", {0x01, 0x02, 0x13}, 3, 256, 64 * 1024, 16, 0},