diff mbox

[Branch,~linaro-validation/lava-dispatcher/trunk] Rev 395: workaround bug in python's tarfile implementation

Message ID 20121002025613.15015.69212.launchpad@ackee.canonical.com
State Accepted
Headers show

Commit Message

Andy Doan Oct. 2, 2012, 2:56 a.m. UTC 
------------------------------------------------------------
revno: 395
committer: Andy Doan <andy.doan@linaro.org>
branch nick: lava-dispatcher
timestamp: Mon 2012-10-01 21:53:01 -0500
message:
  workaround bug in python's tarfile implementation
  
  Our version of python has an issue with unicode filenames in a tarball.
  We had old code that just shelled out to "tar -xzf" and that seems like
  the safest bet for the time being.
modified:
  lava_dispatcher/device/master.py


--
lp:lava-dispatcher
https://code.launchpad.net/~linaro-validation/lava-dispatcher/trunk

You are subscribed to branch lp:lava-dispatcher.
To unsubscribe from this branch go to https://code.launchpad.net/~linaro-validation/lava-dispatcher/trunk/+edit-subscription
diff mbox

Patch

=== modified file 'lava_dispatcher/device/master.py'
--- lava_dispatcher/device/master.py	2012-10-01 19:17:31 +0000
+++ lava_dispatcher/device/master.py	2012-10-02 02:53:01 +0000
@@ -24,7 +24,6 @@ 
 import logging
 import os
 import shutil
-import tarfile
 import time
 import traceback
 
@@ -254,8 +253,7 @@ 
                 tfdir = os.path.join(self.scratch_dir, str(time.time()))
                 try:
                     os.mkdir(tfdir)
-                    tar = tarfile.open(tf, 'r:gz')
-                    tar.extractall(tfdir)
+                    logging_system('tar -C %s -xzf %s' % (tfdir, tf))
                     yield tfdir
 
                 finally: