From patchwork Thu Nov 16 19:28:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 119078 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp5976187qgn; Thu, 16 Nov 2017 11:28:27 -0800 (PST) X-Google-Smtp-Source: AGs4zMauRdzIiqqAO9naPl3RxAKlBJ02C00uUzUOt7RgYU/Adq1Fl1PlEnyt4Xb/wAMfZMTE1oRq X-Received: by 10.223.182.19 with SMTP id f19mr2284086wre.81.1510860507321; Thu, 16 Nov 2017 11:28:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510860507; cv=none; d=google.com; s=arc-20160816; b=zkd6Wai7S02sdfEVH16hBhS+Ba/3Brd77KItAKL2NfnqkutrJ9yCKJMcU3H1jgtM/y u7S831gWn1R4YcjJO7ULd31JdU1EyZd2NzsCzpDux2NlOTpKAmyAmX+aUomIIRQzOJlD k1uqDHxkTBsu+smvSewYdaTGeSrAwDwsLJE2vXNsrGZZwlj8mP4JI/HL52ehJA3uS/t3 80J0lP8UUDKNQFvzp7jeMULbHr0UpfVmU4ZLGCJoGXE5f/ARl+IN7GwIDdPRPFJJQRsl ZvN6d+Ty/xHobIORhjndSwrSv9WuxvpUWgIJkYXuqsAN8xhWIreoQlAdYXIS/oR8lCLp wdNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=sdFPhtWX6mfRvgwu5vWJrPSp6mpFNQgAsaiuUZAe200=; b=F02p03B6YFdaJsuhnBjcya91Zagq7EbPSi3MC+OP0BFBQmXbXQ/7MjgDzhfwHteoW/ 1xt6i50ueJi2+Ri/bCUzpmeOfaA/jrEqV2SU0w5dhpKGbbIIp/BqDCPBhDNe/HyCJFCj XnchmExUsXU3rRls3eEwmo5RQFwkDUWbdNFIqDtd/8OntRRYiB30mgynOEzOhKXkwqgy dj79eHkmiH5pyE2S6eRKcfhjk/eYLo3tSdbzm3e859eUdCjW62Tk/5rsrW00LMEeJCI+ GqQONlVI/bWGAN11y+bJtHea8U0Of+XBy+jRXj7GjUx5AG5ukoanMNKPKrs3Zo6Nm/// Swxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=FzlK+zoO; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id j69si1524084wrj.132.2017.11.16.11.28.26; Thu, 16 Nov 2017 11:28:27 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=FzlK+zoO; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 1CB7B2671AB; Thu, 16 Nov 2017 20:28:25 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id F14942671BD; Thu, 16 Nov 2017 20:28:23 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RP_MATCHES_RCVD, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 09CE1266EE4 for ; Thu, 16 Nov 2017 20:28:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=hQ8AAlOWt3kzhyHhoXnaGfYXGxoQPugil4YNXVjhdHM=; b=FzlK+zoObXBT GTIb0AL6Ijf/JkzV5LX1EOQyFSL7PGz/RtCVWWwfLaXRsEp4MFvtYZcrxpsvkCBGxAAUODILmaUDT 2AJfUhFqsMM54+++yGEg5Cs0Tay/cZ3VtqUJfitOsT1kA0EMVMpl6ra7Ecl8+rH9BBZJhiN+sAOWt v5nT4=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1eFPpj-0006HC-Sw; Thu, 16 Nov 2017 19:28:19 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 2C39344005B; Thu, 16 Nov 2017 19:28:18 +0000 (GMT) From: Mark Brown To: Johan Hovold In-Reply-To: <20171113111256.24140-1-johan@kernel.org> Message-Id: <20171116192818.2C39344005B@finisterre.ee.mobilebroadband> Date: Thu, 16 Nov 2017 19:28:18 +0000 (GMT) Cc: alsa-devel@alsa-project.org, Support Opensource , Takashi Iwai , Liam Girdwood , stable , linux-kernel@vger.kernel.org, Peter Ujfalusi , Mark Brown , Adam Thomson Subject: [alsa-devel] Applied "ASoC: da7218: fix fix child-node lookup" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: da7218: fix fix child-node lookup has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From bc6476d6c1edcb9b97621b5131bd169aa81f27db Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Mon, 13 Nov 2017 12:12:55 +0100 Subject: [PATCH] ASoC: da7218: fix fix child-node lookup Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children. To make things worse, the parent codec node was also prematurely freed. Fixes: 4d50934abd22 ("ASoC: da7218: Add da7218 codec driver") Signed-off-by: Johan Hovold Acked-by: Adam Thomson Signed-off-by: Mark Brown Cc: stable --- sound/soc/codecs/da7218.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c index b2d42ec1dcd9..56564ce90cb6 100644 --- a/sound/soc/codecs/da7218.c +++ b/sound/soc/codecs/da7218.c @@ -2520,7 +2520,7 @@ static struct da7218_pdata *da7218_of_to_pdata(struct snd_soc_codec *codec) } if (da7218->dev_id == DA7218_DEV_ID) { - hpldet_np = of_find_node_by_name(np, "da7218_hpldet"); + hpldet_np = of_get_child_by_name(np, "da7218_hpldet"); if (!hpldet_np) return pdata;