[1/3] ARM: dts: exynos: Add CPU performance counters to Exynos4 boards

Message ID 20171123143431.12434-2-m.szyprowski@samsung.com
State New
Headers show
Series
  • Exynos: add CPU performance counters
Related show

Commit Message

Marek Szyprowski Nov. 23, 2017, 2:34 p.m.
Enable support for ARM Performance Monitoring Units available in
Cortex-A9 CPU cores for Exynos4 SoCs (4210 and 4412).

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

---
 arch/arm/boot/dts/exynos4210.dtsi | 6 ++++++
 arch/arm/boot/dts/exynos4412.dtsi | 6 ++++++
 2 files changed, 12 insertions(+)

-- 
2.14.2

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Markus Reichl Dec. 1, 2017, 11:12 a.m. | #1
Hi Marek,

with this patch (linux-next-20171201) I get on odroid-X2

[    0.671862] hw perfevents: no interrupt-affinity property for /pmu, guessing.
[    0.672242] hw perfevents: enabled with armv7_cortex_a9 PMU driver, 7 counters available
[    0.672618] hw perfevents: no interrupt-affinity property for /arm_pmu, guessing.
[    0.672696] genirq: Flags mismatch irq 38. 00010c00 (arm-pmu) vs. 00010c00 (arm-pmu)
[    0.672716] hw perfevents: unable to request IRQ38 for ARM PMU counters
[    0.672733] hw perfevents: /arm_pmu: failed to register PMU devices!
[    0.672761] armv7-pmu: probe of arm_pmu failed with error -16

without it 

[    0.686817] hw perfevents: no interrupt-affinity property for /pmu, guessing.
[    0.687194] hw perfevents: enabled with armv7_cortex_a9 PMU driver, 7 counters available

Looks like arm_pmu in exynos4412.dtsi doubles pmu from exynos4.dtsi.

Gruß,
-- 
Markus Reichl

Am 23.11.2017 um 15:34 schrieb Marek Szyprowski:
> Enable support for ARM Performance Monitoring Units available in

> Cortex-A9 CPU cores for Exynos4 SoCs (4210 and 4412).

> 

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---

>  arch/arm/boot/dts/exynos4210.dtsi | 6 ++++++

>  arch/arm/boot/dts/exynos4412.dtsi | 6 ++++++

>  2 files changed, 12 insertions(+)

> 

> diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi

> index 03dd61f64809..522f3a7ed07f 100644

> --- a/arch/arm/boot/dts/exynos4210.dtsi

> +++ b/arch/arm/boot/dts/exynos4210.dtsi

> @@ -64,6 +64,12 @@

>  		};

>  	};

>  

> +	arm_pmu {

> +		compatible = "arm,cortex-a9-pmu";

> +		interrupt-parent = <&combiner>;

> +		interrupts = <2 2>, <3 2>;

> +	};

> +

>  	sysram: sysram@2020000 {

>  		compatible = "mmio-sram";

>  		reg = <0x02020000 0x20000>;

> diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi

> index b255ac55b1c1..468c2795481c 100644

> --- a/arch/arm/boot/dts/exynos4412.dtsi

> +++ b/arch/arm/boot/dts/exynos4412.dtsi

> @@ -150,6 +150,12 @@

>  		};

>  	};

>  

> +	arm_pmu {

> +		compatible = "arm,cortex-a9-pmu";

> +		interrupt-parent = <&combiner>;

> +		interrupts = <2 2>, <3 2>, <18 2>, <19 2>;

> +	};

> +

>  	sysram@2020000 {

>  		compatible = "mmio-sram";

>  		reg = <0x02020000 0x40000>;

> 

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marek Szyprowski Dec. 4, 2017, 9:49 a.m. | #2
Hi Markus,

On 2017-12-01 12:12, Markus Reichl wrote:
> Hi Marek,

>

> with this patch (linux-next-20171201) I get on odroid-X2

>

> [    0.671862] hw perfevents: no interrupt-affinity property for /pmu, guessing.

> [    0.672242] hw perfevents: enabled with armv7_cortex_a9 PMU driver, 7 counters available

> [    0.672618] hw perfevents: no interrupt-affinity property for /arm_pmu, guessing.

> [    0.672696] genirq: Flags mismatch irq 38. 00010c00 (arm-pmu) vs. 00010c00 (arm-pmu)

> [    0.672716] hw perfevents: unable to request IRQ38 for ARM PMU counters

> [    0.672733] hw perfevents: /arm_pmu: failed to register PMU devices!

> [    0.672761] armv7-pmu: probe of arm_pmu failed with error -16

>

> without it

>

> [    0.686817] hw perfevents: no interrupt-affinity property for /pmu, guessing.

> [    0.687194] hw perfevents: enabled with armv7_cortex_a9 PMU driver, 7 counters available

>

> Looks like arm_pmu in exynos4412.dtsi doubles pmu from exynos4.dtsi.


You are right. I swear that I've checked exynos4 dts before preparing my 
patch
and didn't notice existing ARM PMU node there. This means that my patch 
has to
be reverted/dropped then. Sorry for the noise.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Krzysztof Kozlowski Dec. 4, 2017, 9:57 a.m. | #3
On Mon, Dec 4, 2017 at 10:49 AM, Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> Hi Markus,

>

> On 2017-12-01 12:12, Markus Reichl wrote:

>>

>> Hi Marek,

>>

>> with this patch (linux-next-20171201) I get on odroid-X2

>>

>> [    0.671862] hw perfevents: no interrupt-affinity property for /pmu,

>> guessing.

>> [    0.672242] hw perfevents: enabled with armv7_cortex_a9 PMU driver, 7

>> counters available

>> [    0.672618] hw perfevents: no interrupt-affinity property for /arm_pmu,

>> guessing.

>> [    0.672696] genirq: Flags mismatch irq 38. 00010c00 (arm-pmu) vs.

>> 00010c00 (arm-pmu)

>> [    0.672716] hw perfevents: unable to request IRQ38 for ARM PMU counters

>> [    0.672733] hw perfevents: /arm_pmu: failed to register PMU devices!

>> [    0.672761] armv7-pmu: probe of arm_pmu failed with error -16

>>

>> without it

>>

>> [    0.686817] hw perfevents: no interrupt-affinity property for /pmu,

>> guessing.

>> [    0.687194] hw perfevents: enabled with armv7_cortex_a9 PMU driver, 7

>> counters available

>>

>> Looks like arm_pmu in exynos4412.dtsi doubles pmu from exynos4.dtsi.

>

>

> You are right. I swear that I've checked exynos4 dts before preparing my

> patch

> and didn't notice existing ARM PMU node there. This means that my patch has

> to

> be reverted/dropped then. Sorry for the noise.


No problem, I'll drop it and rebase my tree.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index 03dd61f64809..522f3a7ed07f 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -64,6 +64,12 @@ 
 		};
 	};
 
+	arm_pmu {
+		compatible = "arm,cortex-a9-pmu";
+		interrupt-parent = <&combiner>;
+		interrupts = <2 2>, <3 2>;
+	};
+
 	sysram: sysram@2020000 {
 		compatible = "mmio-sram";
 		reg = <0x02020000 0x20000>;
diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
index b255ac55b1c1..468c2795481c 100644
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -150,6 +150,12 @@ 
 		};
 	};
 
+	arm_pmu {
+		compatible = "arm,cortex-a9-pmu";
+		interrupt-parent = <&combiner>;
+		interrupts = <2 2>, <3 2>, <18 2>, <19 2>;
+	};
+
 	sysram@2020000 {
 		compatible = "mmio-sram";
 		reg = <0x02020000 0x40000>;