From patchwork Tue Oct 2 16:36:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 11958 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 24F8C23EFF for ; Tue, 2 Oct 2012 16:37:27 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id CB8B4A18710 for ; Tue, 2 Oct 2012 16:37:26 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so14608949iej.11 for ; Tue, 02 Oct 2012 09:37:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-provags-id:x-gm-message-state; bh=zg9DEGjVozw2wyUsoxMEtYI7znkpQSVASdNewtIIneY=; b=gjbOvGYJZdc4nBAhhcG4gdEHjCgJhVHUk6OP2TUXCoieAMXrFpGRpCcOgXT9ATduag SOvWxoc54ew139p6OAg2atd1dgHLV62FE+z5q6qZg3zmVBKndJQ7NApun/5JJ2eON8jf o5pI4uR/NXQgarJOZKIPUAa+BjLt/83TQD1NMh+eWv6Ss5v3F1x7ZlrIoeM2ZMP9uKB8 OmhqDlKn7vPaVbvPj423+N/gp5UoW14ADufaPIdiH1Pv/EMUyK+YrLJxKkq9/SIVDnXY /qtxTH4V1s/9/N2c+7M0XrMSkHZdsgOdJI36B+f3E9yCGSL0T6S+D4+rRv8pwrjs2wYy ZFag== Received: by 10.50.155.136 with SMTP id vw8mr8776729igb.28.1349195846540; Tue, 02 Oct 2012 09:37:26 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp92076igc; Tue, 2 Oct 2012 09:37:25 -0700 (PDT) Received: by 10.180.90.201 with SMTP id by9mr23152975wib.5.1349195845079; Tue, 02 Oct 2012 09:37:25 -0700 (PDT) Received: from moutng.kundenserver.de (moutng.kundenserver.de. [212.227.17.8]) by mx.google.com with ESMTPS id d13si1713413wep.125.2012.10.02.09.37.24 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 02 Oct 2012 09:37:25 -0700 (PDT) Received-SPF: neutral (google.com: 212.227.17.8 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) client-ip=212.227.17.8; Authentication-Results: mx.google.com; spf=neutral (google.com: 212.227.17.8 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) smtp.mail=arnd@arndb.de Received: from localhost.localdomain (HSI-KBW-149-172-5-253.hsi13.kabel-badenwuerttemberg.de [149.172.5.253]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0M03oK-1TZmyH34aS-00uRxz; Tue, 02 Oct 2012 18:37:18 +0200 From: Arnd Bergmann To: linux-arm-kernel@infradead.org Cc: arm@kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Russell King Subject: [PATCH 15/17] ARM: rpc: check device_register return code in ecard_probe Date: Tue, 2 Oct 2012 18:36:54 +0200 Message-Id: <1349195816-2225-16-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1349195816-2225-1-git-send-email-arnd@arndb.de> References: <1349195816-2225-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:HnPDrAtnPPHPL5w5XaI4eUxRl10fzGzmEL6ILiX/j0V 3jxuV05J9cm8rFL8cwCiWGfGSzuZt9J0NUPQPPGzHhJ+D4rSSN vbGzapRFx9U1WPuPOJJhHjb4lbSspeeBTLlP21INJUwMNEDUnF qkLp8zy/1uR/pBon9JKoCAF4vbnfcbcWzMyO2EgGuvfSESBWeU wlaTVUq291UTChoL3bLBSOUgUP+9CJuUUbWeZ3oLFXX5QB6rGg EdzG+mRYATVA57euD925fyAGr8KC00W9UHrsWIyjKMWl4qcL6L 0iXH/G2zrwsIZgsub02H9YJUkcctkx/bTRXqtgQrxnKuxR0Xw/ owM+nwoVnF3bHb/Yr/Z1dT3xeTDS6X+pt4bORLfwX7/H8sMJN+ JiQMRJCAmqQyw== X-Gm-Message-State: ALoCoQmgj9iJn6I5Zef/OuuZa/EIFlG4X5+qJACi0oRQd6ZkkaS5N78Dkw3fGZF5vbRcZBg0aS2J device_register is marked __must_check, so we better propagate the error value by returning it from ecard_probe. Without this patch, building rpc_defconfig results in: arch/arm/mach-rpc/ecard.c: In function 'ecard_probe': arch/arm/mach-rpc/ecard.c:963:17: warning: ignoring return value of 'device_register', declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: Arnd Bergmann Cc: Russell King --- arch/arm/mach-rpc/ecard.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-rpc/ecard.c b/arch/arm/mach-rpc/ecard.c index b91bc87..fcb1d59 100644 --- a/arch/arm/mach-rpc/ecard.c +++ b/arch/arm/mach-rpc/ecard.c @@ -960,7 +960,9 @@ static int __init ecard_probe(int slot, unsigned irq, card_type_t type) *ecp = ec; slot_to_expcard[slot] = ec; - device_register(&ec->dev); + rc = device_register(&ec->dev); + if (rc) + goto nodev; return 0;