From patchwork Fri Nov 24 16:24:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 119620 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp2449300qgn; Fri, 24 Nov 2017 08:32:18 -0800 (PST) X-Google-Smtp-Source: AGs4zMZDLUOF0L32OzjnfqwSlcQLpwdAQg/m+2mz5WEG3KWfgo0b61SgUUi7NoFUjMsGm0Dm43tl X-Received: by 10.99.108.66 with SMTP id h63mr28804346pgc.362.1511541138472; Fri, 24 Nov 2017 08:32:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511541138; cv=none; d=google.com; s=arc-20160816; b=h34IlYmv/rKD+v0vgMsrefaCcq3Y3DPDHIICzlpBB1YMRjQLJss0VHusBwyPa2Qtbp nMl9Y+gs/IY5vjrUwcHzcyclpT/HJ91QhJ9DQ7LeQX1Hn/+KZwYv4dEGC+7QGKZt8BUl XgB8qmvmsapv//rU5nFzT2lN3pHLeRGKRGEp9AcRcGaKtNqioQSn/y/ace4pzVOaZ8Ze q5xoj4yyZ8lOtioR/qVFVvft8TyklxS/3scBQaoKsJW1YWSMvONhNDY0zcBiDNBmKkgp lHZWzhiABM+iAFZChHMqabHUkYu9kgT2QP59+RWAWbV6vBTrYq/phz+ucB1sMK6SILb8 e85w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=Lb/4XYaRzM8FiFqJBkY8bK0S8trPJq3DO8Xsz3+fZqg=; b=aYkMdnu3VfIikhmGVYPp7eJIYrn3iJ4oXfKDYSuSyKki5WYeCHXXi4G7CUua1JxuNq KEccrga178t23DmU40fGhDsVUxm84cZMnCr+jRZbk3WhoIiFhzsNThaX0OezNMvL3TK4 DE58n6P3maqDzSX/lODD9r6ikDb5HlBJtcUR/9g32Q9IFwuxXOxMS+0lL5uWbIHdIM1E hqKti+OY+NfWxdlJYAuN+Y0az16aNjKAOrgi5c0zK5Frubk6cwTm9SZeIumPuQoHYYmS Dwg0Ai4J/XIisDnwN4SaOw/IcpQiP8J67ZVbL+QdKh3eMgL+B+AX8weu11E0T2KJPSil 58qQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=T9mPaBm9; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n22si16521539pll.442.2017.11.24.08.32.18; Fri, 24 Nov 2017 08:32:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=T9mPaBm9; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753692AbdKXQcP (ORCPT + 6 others); Fri, 24 Nov 2017 11:32:15 -0500 Received: from conuserg-11.nifty.com ([210.131.2.78]:61428 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753608AbdKXQZ6 (ORCPT ); Fri, 24 Nov 2017 11:25:58 -0500 Received: from grover.sesame (FL1-125-199-20-195.osk.mesh.ad.jp [125.199.20.195]) (authenticated) by conuserg-11.nifty.com with ESMTP id vAOGP9Vp007100; Sat, 25 Nov 2017 01:25:13 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com vAOGP9Vp007100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1511540714; bh=qNDBWcc9eLtyjEBtYQmQYpRZXNOZsO7GQak4tSmLjps=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T9mPaBm9R+UjF/OXwA66E2Qbf5KIVupdjaNjfWZxwBGSzfcBNSHKQcO3OzqWLzvF5 kJFcrycQnwijhfPdjnZo4GSlvzoXWaZSQTWGel3DTLm/mghdKXQnl0dRFeHYPO2C9l pyJRCm30GDphKUqIreYxfC68NS7pXj0mFHnNwKusmqLYqbDxfu20jxajf7F3XmlXC3 sGGGnfcSklYm2GCsChBq40j3ywWOgM+gX6pLg27GBKfF3v2h7YAMpYv9dZV6r7RDDV aZ4b6jfkZgI3AptSjgdRIhjea7bpoBqWtxGFdlLnX7Ozm8vLksBX9tIdu3l4IK17zC Wz9/GVT4F2oEA== X-Nifty-SrcIP: [125.199.20.195] From: Masahiro Yamada To: linux-mmc@vger.kernel.org, Wolfram Sang Cc: Simon Horman , Yoshihiro Shimoda , linux-renesas-soc@vger.kernel.org, Masahiro Yamada , linux-kernel@vger.kernel.org, Ulf Hansson Subject: [PATCH v2 05/22] mmc: tmio: use devm_ioremap_resource() instead of devm_ioremap() Date: Sat, 25 Nov 2017 01:24:40 +0900 Message-Id: <1511540697-27387-6-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511540697-27387-1-git-send-email-yamada.masahiro@socionext.com> References: <1511540697-27387-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The TMIO core misses to call request_mem_region(). devm_ioremap_resource() takes care of it and makes the code cleaner. Signed-off-by: Masahiro Yamada Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- Changes in v2: None drivers/mmc/host/tmio_mmc_core.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c index 12df338..d3b7af9 100644 --- a/drivers/mmc/host/tmio_mmc_core.c +++ b/drivers/mmc/host/tmio_mmc_core.c @@ -1185,8 +1185,9 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host, _host->write16_hook = NULL; res_ctl = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res_ctl) - return -EINVAL; + _host->ctl = devm_ioremap_resource(&pdev->dev, res_ctl); + if (IS_ERR(_host->ctl)) + return PTR_ERR(_host->ctl); ret = mmc_of_parse(mmc); if (ret < 0) @@ -1202,11 +1203,6 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host, if (ret < 0) return ret; - _host->ctl = devm_ioremap(&pdev->dev, - res_ctl->start, resource_size(res_ctl)); - if (!_host->ctl) - return -ENOMEM; - tmio_mmc_ops.card_busy = _host->card_busy; tmio_mmc_ops.start_signal_voltage_switch = _host->start_signal_voltage_switch;