env: enable CONFIG_ENV_IS_IN_EXT4

Message ID 1511799979-3797-1-git-send-email-jorge.ramirez-ortiz@linaro.org
State New
Headers show
Series
  • env: enable CONFIG_ENV_IS_IN_EXT4
Related show

Commit Message

Jorge Ramirez Nov. 27, 2017, 4:26 p.m.
---
 env/Kconfig | 10 ++++++++++
 env/env.c   |  2 ++
 2 files changed, 12 insertions(+)

Comments

Tom Rini Nov. 27, 2017, 4:33 p.m. | #1
On Mon, Nov 27, 2017 at 05:26:19PM +0100, Jorge Ramirez-Ortiz wrote:

Please add a line or two here, thanks.

> ---

>  env/Kconfig | 10 ++++++++++

>  env/env.c   |  2 ++

>  2 files changed, 12 insertions(+)

> 

> diff --git a/env/Kconfig b/env/Kconfig

> index 2477bf8..4387a2c 100644

> --- a/env/Kconfig

> +++ b/env/Kconfig

> @@ -81,6 +81,16 @@ config ENV_IS_IN_FAT

>  	  - CONFIG_FAT_WRITE:

>  	  This must be enabled. Otherwise it cannot save the environment file.

>  

> +config ENV_IS_IN_EXT4

> +	bool "Environment is in a EXT4 filesystem"

> +	depends on !CHAIN_OF_TRUST

> +	select EXT4_WRITE

> +	help

> +	  Define this if you want to use the EXT4 file system for the environment.

> +

> +	  - CONFIG_EXT4_WRITE:

> +	  This must be enabled. Otherwise it cannot save the environment file.


We can remove this bit about needing CONFIG_EXT4_WRITE as we're
expressing this dependency via select above now.  Thanks!

-- 
Tom

Patch

diff --git a/env/Kconfig b/env/Kconfig
index 2477bf8..4387a2c 100644
--- a/env/Kconfig
+++ b/env/Kconfig
@@ -81,6 +81,16 @@  config ENV_IS_IN_FAT
 	  - CONFIG_FAT_WRITE:
 	  This must be enabled. Otherwise it cannot save the environment file.
 
+config ENV_IS_IN_EXT4
+	bool "Environment is in a EXT4 filesystem"
+	depends on !CHAIN_OF_TRUST
+	select EXT4_WRITE
+	help
+	  Define this if you want to use the EXT4 file system for the environment.
+
+	  - CONFIG_EXT4_WRITE:
+	  This must be enabled. Otherwise it cannot save the environment file.
+
 config ENV_IS_IN_FLASH
 	bool "Environment in flash memory"
 	depends on !CHAIN_OF_TRUST
diff --git a/env/env.c b/env/env.c
index 76a5608..7455632 100644
--- a/env/env.c
+++ b/env/env.c
@@ -32,6 +32,8 @@  static enum env_location env_get_default_location(void)
 		return ENVL_EEPROM;
 	else if IS_ENABLED(CONFIG_ENV_IS_IN_FAT)
 		return ENVL_FAT;
+	else if IS_ENABLED(CONFIG_ENV_IS_IN_EXT4)
+		return ENVL_EXT4;
 	else if IS_ENABLED(CONFIG_ENV_IS_IN_FLASH)
 		return ENVL_FLASH;
 	else if IS_ENABLED(CONFIG_ENV_IS_IN_MMC)