[edk2,edk2-platforms] Platform/Hisilicon: drop BdsLib inclusion from HiKey .dsc

Message ID 20171130104631.29600-1-leif.lindholm@linaro.org
State New
Headers show
Series
  • [edk2,edk2-platforms] Platform/Hisilicon: drop BdsLib inclusion from HiKey .dsc
Related show

Commit Message

Leif Lindholm Nov. 30, 2017, 10:46 a.m.
The ArmPkg BdsLib has been dropped from EDK2, and is no longer
required by the Android*Boot applications - so delete the
reference to fix the resulting build failure.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

---
 Platform/Hisilicon/HiKey/HiKey.dsc | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ard Biesheuvel Nov. 30, 2017, 11:13 a.m. | #1
> On 30 Nov 2017, at 10:46, Leif Lindholm <leif.lindholm@linaro.org> wrote:

> 

> The ArmPkg BdsLib has been dropped from EDK2, and is no longer

> required by the Android*Boot applications - so delete the

> reference to fix the resulting build failure.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>


Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


> ---

> Platform/Hisilicon/HiKey/HiKey.dsc | 5 +----

> 1 file changed, 1 insertion(+), 4 deletions(-)

> 

> diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc

> index 97811eb8d9..957e4d4a9e 100644

> --- a/Platform/Hisilicon/HiKey/HiKey.dsc

> +++ b/Platform/Hisilicon/HiKey/HiKey.dsc

> @@ -411,10 +411,7 @@ [Components.common]

>   #

>   # Fastboot

>   #

> -  EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf {

> -    <LibraryClasses>

> -      BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf

> -  }

> +  EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf

> 

> 

>   #

> -- 

> 2.11.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Leif Lindholm Nov. 30, 2017, 12:09 p.m. | #2
On Thu, Nov 30, 2017 at 11:13:49AM +0000, Ard Biesheuvel wrote:
> 

> 

> > On 30 Nov 2017, at 10:46, Leif Lindholm <leif.lindholm@linaro.org> wrote:

> > 

> > The ArmPkg BdsLib has been dropped from EDK2, and is no longer

> > required by the Android*Boot applications - so delete the

> > reference to fix the resulting build failure.

> > 

> > Contributed-under: TianoCore Contribution Agreement 1.1

> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

> 

> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


Thanks, pushed as 53a3ad49a9.

/
    Leif
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
index 97811eb8d9..957e4d4a9e 100644
--- a/Platform/Hisilicon/HiKey/HiKey.dsc
+++ b/Platform/Hisilicon/HiKey/HiKey.dsc
@@ -411,10 +411,7 @@  [Components.common]
   #
   # Fastboot
   #
-  EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf {
-    <LibraryClasses>
-      BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf
-  }
+  EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf
 
 
   #