| Message ID | 20171130135947.25682-1-ard.biesheuvel@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [edk2,edk2-platforms] Platform: remove gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec | expand |
On Thu, Nov 30, 2017 at 01:59:47PM +0000, Ard Biesheuvel wrote: > Remove references to the ArmPlatformPkg PCD PcdSystemMemoryInitializeInSec, > which is only used on PrePeiCore platforms anyway, and which has no effect > whatsoever given that it decides when ArmPlatformInitializeSystemMemory() > is called, which is implemented as an empty function by all these platforms > anyway. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > --- > Platform/ARM/JunoPkg/ArmJuno.dsc | 2 -- > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 1 - > Platform/Hisilicon/D05/D05.dsc | 1 - > Platform/Hisilicon/HiKey/HiKey.dsc | 2 -- > 4 files changed, 6 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc > index 115609180263..2844c91813d4 100644 > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc > @@ -78,8 +78,6 @@ [BuildOptions] > ################################################################################ > > [PcdsFeatureFlag.common] > - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE > - > ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe. > # It could be set FALSE to save size. > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > index b2eb4b14da0b..98513b282fa7 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > @@ -86,7 +86,6 @@ [BuildOptions] > > [PcdsFeatureFlag.common] > gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride|TRUE > - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE > gArmPlatformTokenSpaceGuid.PcdSendSgiToBringUpSecondaryCores|TRUE > > ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe. > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > index 00cf0f20d23f..1daac38e1152 100644 > --- a/Platform/Hisilicon/D05/D05.dsc > +++ b/Platform/Hisilicon/D05/D05.dsc > @@ -113,7 +113,6 @@ [BuildOptions] > [PcdsFeatureFlag.common] > > !if $(EDK2_SKIP_PEICORE) == 1 > - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE > gArmPlatformTokenSpaceGuid.PcdSendSgiToBringUpSecondaryCores|TRUE > !endif > > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc > index 957e4d4a9e4c..8322ab53c020 100644 > --- a/Platform/Hisilicon/HiKey/HiKey.dsc > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc > @@ -192,8 +192,6 @@ [PcdsFeatureFlag.common] > > gEmbeddedTokenSpaceGuid.PcdPrePiProduceMemoryTypeInformationHob|TRUE > > - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE > - > ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe. > # It could be set FALSE to save size. > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|FALSE > -- > 2.11.0 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 30 November 2017 at 14:31, Leif Lindholm <leif.lindholm@linaro.org> wrote: > On Thu, Nov 30, 2017 at 01:59:47PM +0000, Ard Biesheuvel wrote: >> Remove references to the ArmPlatformPkg PCD PcdSystemMemoryInitializeInSec, >> which is only used on PrePeiCore platforms anyway, and which has no effect >> whatsoever given that it decides when ArmPlatformInitializeSystemMemory() >> is called, which is implemented as an empty function by all these platforms >> anyway. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > Thanks. Pushed as 362fe44d406313eb1f5e7d0e92182d3cf484f5d5 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc index 115609180263..2844c91813d4 100644 --- a/Platform/ARM/JunoPkg/ArmJuno.dsc +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc @@ -78,8 +78,6 @@ [BuildOptions] ################################################################################ [PcdsFeatureFlag.common] - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE - ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe. # It could be set FALSE to save size. gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc index b2eb4b14da0b..98513b282fa7 100644 --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc @@ -86,7 +86,6 @@ [BuildOptions] [PcdsFeatureFlag.common] gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride|TRUE - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE gArmPlatformTokenSpaceGuid.PcdSendSgiToBringUpSecondaryCores|TRUE ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe. diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc index 00cf0f20d23f..1daac38e1152 100644 --- a/Platform/Hisilicon/D05/D05.dsc +++ b/Platform/Hisilicon/D05/D05.dsc @@ -113,7 +113,6 @@ [BuildOptions] [PcdsFeatureFlag.common] !if $(EDK2_SKIP_PEICORE) == 1 - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE gArmPlatformTokenSpaceGuid.PcdSendSgiToBringUpSecondaryCores|TRUE !endif diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc index 957e4d4a9e4c..8322ab53c020 100644 --- a/Platform/Hisilicon/HiKey/HiKey.dsc +++ b/Platform/Hisilicon/HiKey/HiKey.dsc @@ -192,8 +192,6 @@ [PcdsFeatureFlag.common] gEmbeddedTokenSpaceGuid.PcdPrePiProduceMemoryTypeInformationHob|TRUE - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE - ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe. # It could be set FALSE to save size. gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|FALSE
Remove references to the ArmPlatformPkg PCD PcdSystemMemoryInitializeInSec, which is only used on PrePeiCore platforms anyway, and which has no effect whatsoever given that it decides when ArmPlatformInitializeSystemMemory() is called, which is implemented as an empty function by all these platforms anyway. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- Platform/ARM/JunoPkg/ArmJuno.dsc | 2 -- Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 1 - Platform/Hisilicon/D05/D05.dsc | 1 - Platform/Hisilicon/HiKey/HiKey.dsc | 2 -- 4 files changed, 6 deletions(-) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel