diff mbox series

[v4,09/10] ARM: dtsi: axp81x: add GPIO DT node

Message ID af90c57ebf97c8f5504a4b5b1dad3638bedadfef.1512135804.git-series.quentin.schulz@free-electrons.com
State New
Headers show
Series add pinmuxing support for pins in AXP209 and AXP813 PMICs | expand

Commit Message

Quentin Schulz Dec. 1, 2017, 1:44 p.m. UTC
This adds DT node for the GPIO/pinctrl part present in AXP813/AXP818.

Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>

---
 arch/arm/boot/dts/axp81x.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
git-series 0.9.1

Comments

Linus Walleij Dec. 2, 2017, 3:58 p.m. UTC | #1
On Fri, Dec 1, 2017 at 2:44 PM, Quentin Schulz
<quentin.schulz@free-electrons.com> wrote:

> This adds DT node for the GPIO/pinctrl part present in AXP813/AXP818.

>

> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>


Acked-by: Linus Walleij <linus.walleij@linaro.org>


Please apply this through ARM SoC.

Yours,
Linus Walleij
Maxime Ripard Dec. 5, 2017, 9:39 a.m. UTC | #2
Hi,

On Tue, Dec 05, 2017 at 05:24:47PM +0800, Chen-Yu Tsai wrote:
> On Fri, Dec 1, 2017 at 9:44 PM, Quentin Schulz

> <quentin.schulz@free-electrons.com> wrote:

> > This adds DT node for the GPIO/pinctrl part present in AXP813/AXP818.

> >

> > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>

> > ---

> >  arch/arm/boot/dts/axp81x.dtsi | 6 ++++++

> >  1 file changed, 6 insertions(+)

> >

> > diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi

> > index 73b761f..0ef959d 100644

> > --- a/arch/arm/boot/dts/axp81x.dtsi

> > +++ b/arch/arm/boot/dts/axp81x.dtsi

> > @@ -48,6 +48,12 @@

> >         interrupt-controller;

> >         #interrupt-cells = <1>;

> >

> > +       axp_gpio: axp-gpio {

> > +               compatible = "x-powers,axp813-gpio";

> > +               gpio-controller;

> > +               #gpio-cells = <2>;

> 

> What about interrupt-controller for directly referenced interrupts from

> the GPIO pins?


There's a bit more to it to enable interrupts. You would probably need
to set up a chained interrupt controller in the GPIO driver, and in
the DTS with a interrupt-parent and interrupts properties pointing to
the AXP device itself.

> Otherwise,

> 

> Acked-by: Chen-Yu Tsai <wens@csie.org>


Applied 9 and 10, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi
index 73b761f..0ef959d 100644
--- a/arch/arm/boot/dts/axp81x.dtsi
+++ b/arch/arm/boot/dts/axp81x.dtsi
@@ -48,6 +48,12 @@ 
 	interrupt-controller;
 	#interrupt-cells = <1>;
 
+	axp_gpio: axp-gpio {
+		compatible = "x-powers,axp813-gpio";
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
 	regulators {
 		/* Default work frequency for buck regulators */
 		x-powers,dcdc-freq = <3000>;