From patchwork Wed Dec 6 09:50:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 120799 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp6843126qgn; Wed, 6 Dec 2017 01:52:39 -0800 (PST) X-Google-Smtp-Source: AGs4zMZqCy5mQBcm29a7EU3RRa7kZsM9UyZHKKaJmrLRIFf20nG46c32MrNMrtI8Og8Tm3znSVJV X-Received: by 10.101.69.203 with SMTP id m11mr19919663pgr.200.1512553959680; Wed, 06 Dec 2017 01:52:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512553959; cv=none; d=google.com; s=arc-20160816; b=tiltC0Jw2AHuAVdrjFfU+X4WAHRFiDiFMXymOUsXVQwrT8I4AnVChcpMMMHqLDmP+b moish4bK0WLewJS1TtZZgqbDJMpdHE04LIlAAPDHJpiUIht93oQl0eSXbE5wfUBkWGYj SKS9yS9Nvq9y906Z8lHFzFzG+CDZaJjg5GAr8MjEo98FsqtkZGxayR6gqucEkf0h8R1V 0gEMEe7TkdmHpd/Ks+i/Aw9EuR04GpQwJqT6wd8+qOVS9VTvbi8tqgmSRyQAblX7HMzJ e6XLq57esla5j2neAHKipx1dJGy0L4ECtpADICNfJPfeImn/hiJ3QXL4ZoGwjkvwxGbD vYyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=midNgekMa2Lq4p3qtyxHOuQn7YdyqrXE4PqHF3qcN8o=; b=AD1dNZGiC9YYcctsuaD51iRo7uaBcHD+h/VtRAnmtnkO4vLZtDSSvC6B1QZU7WGyOw bdu+wLdzmiGHBP2JNK6sdtGmupbFY/ysHKccQL6L/y3Lq84tQddYTyeBvKTlYr7hx1W2 sUPDCNNskqHR/qOp10Z05/9fF/zHu1CmnPIjEcEUG2ztXiDtOMpKH6EHswmpIyTo5wtV YHK3AevhlCTJtuZ07YYkJJXab5SeQ4JYBYt8NlBIlKEwv75AiPaeS65HwnbgJnnCz0j1 VlfrvkReh2BikXlKm4Jn4nw2xvZ84ievkpPFZUvNdDc6QzedxiE6hCQ8/WsXoubakmvo YZtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TudhQJ7n; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t84si1774477pfg.252.2017.12.06.01.52.39; Wed, 06 Dec 2017 01:52:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TudhQJ7n; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754309AbdLFJwi (ORCPT + 2 others); Wed, 6 Dec 2017 04:52:38 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:46655 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754698AbdLFJwd (ORCPT ); Wed, 6 Dec 2017 04:52:33 -0500 Received: by mail-wr0-f194.google.com with SMTP id x49so3187389wrb.13 for ; Wed, 06 Dec 2017 01:52:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=S6eGmIOm2TZW5xNeiq7Se/wcuDrOUrmbhQXQeSJhCvI=; b=TudhQJ7n4rxzj5VCntl0uAZ1rGIah/mZrS1fpE/GQDNHuJdjUKHnJOeM98ttK7KllI R19mSs7cvRUCBZR7rVP+qeDslS8hui1HZ/+0jf5PVrOdgHXg7LTpXsEREsv37XCL1Et1 jyf/AcAWZ+7lipLxXJ9OKcZjUDHXlv0xP7DyY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=S6eGmIOm2TZW5xNeiq7Se/wcuDrOUrmbhQXQeSJhCvI=; b=RBfZ5ex9A+UWiu2z/sFVIoPkH5lDAuFy/DoLJ4veEskEoCNAj1FfJrHHU58L+mnWXE P910khM/yl/RT3D8wNj3fRTQT4Fb2erT8jKkyLcpwmOIotEkrX+VHMkNA4JuJBRRbJJr e6gt9sBgLLcua+rnXUSk3ltQDuO2kYg9ci8Wk2rwv+8BydVXUm9adl3JYSyEjkS6PcwJ 8FJWDQ5prjAXhNxZDgkXwHk+u7XHzoNx2XAxb3NfSMbUzK71lwmILldsnaQV+IxZK+ZE yW6weEJFEV+6isamF/0vQj0j1ujVEBvRMV6Z5QUhJUXM9DG2Vy8DYQS8EyVBNZQzMiDP 0mCw== X-Gm-Message-State: AJaThX6F2kUJu+GR4eHfahe+9Y0O0yVIYdE1xd+uPeREhJMPFgL7QKfg pgkoA1PrAvRzalosF7+YAvU7ywaA3XU= X-Received: by 10.223.134.76 with SMTP id 12mr20551063wrw.137.1512553951746; Wed, 06 Dec 2017 01:52:31 -0800 (PST) Received: from localhost.localdomain ([105.150.171.234]) by smtp.gmail.com with ESMTPSA id w133sm2543113wmg.9.2017.12.06.01.52.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Dec 2017 01:52:30 -0800 (PST) From: Ard Biesheuvel To: linux-efi@vger.kernel.org, Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" Cc: Dave Young , Ard Biesheuvel , linux-kernel@vger.kernel.org, Matt Fleming Subject: [PATCH 3/3] efi: add comment to avoid future expanding of sysfs systab Date: Wed, 6 Dec 2017 09:50:10 +0000 Message-Id: <20171206095010.24170-4-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171206095010.24170-1-ard.biesheuvel@linaro.org> References: <20171206095010.24170-1-ard.biesheuvel@linaro.org> Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org From: Dave Young /sys/firmware/efi/systab shows several different values, it breaks sysfs one file one value design. But since there are already userspace tools depend on it eg. kexec-tools so add code comment to alert future expanding of this file. Signed-off-by: Dave Young Reviewed-by: Greg Kroah-Hartman Cc: Matt Fleming Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/efi.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index c3eefa126e3b..557a47829d03 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -109,6 +109,8 @@ struct kobject *efi_kobj; /* * Let's not leave out systab information that snuck into * the efivars driver + * Note, do not add more fields in systab sysfs file as it breaks sysfs + * one value per file rule! */ static ssize_t systab_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)