From patchwork Wed Dec 6 09:50:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 120800 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp6843326qgn; Wed, 6 Dec 2017 01:52:56 -0800 (PST) X-Google-Smtp-Source: AGs4zMYTrOEyHcFv4UWp/3fSx5PG5dPfn77BWRxDcRtFgzZuoK9kTf1P4/sBGchq60R7GxkkLAlO X-Received: by 10.84.130.34 with SMTP id 31mr21578921plc.67.1512553976270; Wed, 06 Dec 2017 01:52:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512553976; cv=none; d=google.com; s=arc-20160816; b=ZOjGuLb7fef1vHdY/0L5W3jU6xOCr//aAJRq0QCB2di8fxZoDLhaJTVNPjHSjIXPLO gIQuXDRvk5/RUuC2chAhHuiniyWTVl5H7Kfxp8RIcAs+lWM/3IiovweMoCh55MssO3Vg WFGOTMTdN9jP7IiInFceEK7ZKymukIO+/Lo0YDQZVHurMk7atoIyXQ0kANb05rgDZ77B XaE9fvNTEU4nKjs/nIZz+nGwStgq42hKcPjhyTO9pTQ9Smi9YQ0MbFhznGmDACOAjtcs tzj1M4iY3mCA7XmDMBPXKinQgxU8Ee1aDEqT6orXDcwX+PO2WrZWDB3MpLFdlYrtLbls ozxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=jKhK4+1lUNNss6VUqblmU2Kv9gUAtWpAg+dmrxq7YbI=; b=ylXMwCz5aPKIS4txXyEyG5VO9h8jOlS/vujmphkAzsl+1RK6AYuDCu8mtuOs30CWWJ oEwomiMWHFB2xhl7T1yL9wpKgwoLhVEA0DLUl8aQdXd69qdkQDd88dFNrCB+2u0kY+GE n090bAtLUEy7mJBRh+Lu02iOwLO1ENtn3hwoZlzLI3BsV3EUyIOf/UDUNIfKO/j/7ufn N06jEdHAi8kk1B1HaYcazh4Gbxw6qHUICngCMtFY0NKiPYNFOjK3F3RsZ37KlZci1EI8 AFO3XxS+DxASky57m4qQLs+gkU/htXQhLyPAqykeJ5Sc3rQw0hQf+d9B+Uyemu/BD23C d4LA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Y+kexoQK; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t84si1774477pfg.252.2017.12.06.01.52.56; Wed, 06 Dec 2017 01:52:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Y+kexoQK; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751444AbdLFJwz (ORCPT + 2 others); Wed, 6 Dec 2017 04:52:55 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34543 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752084AbdLFJwa (ORCPT ); Wed, 6 Dec 2017 04:52:30 -0500 Received: by mail-wr0-f196.google.com with SMTP id y21so3218982wrc.1 for ; Wed, 06 Dec 2017 01:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tJpilBSvQoQM5bfglG36S2+5eYq/BZDnfaTqzLWAWG0=; b=Y+kexoQKJsLNxVCFtyzMh2wnTNlEhJuMd4VF7HPBvOZgKgU7EnJObxvsK2s7gCUT+5 3jJR2FpAFOWb+3K023ToRt+qgXwV4PbHkQQJv3tlT0OgNQmH+xfy1/p12DmUrIp48T9P W3E3ZDlNgutXdgwBkIksMl8ryfOtU2ItHQ/c8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tJpilBSvQoQM5bfglG36S2+5eYq/BZDnfaTqzLWAWG0=; b=Cjrp4kaiCmaltVIYSm6YhzOyIwXdP6ILM4npCQ65mt4Sc7umelgUoIVLvPDf74Px8p 2fbDXSKFrTHAom/6ISPBYxYsWwxCzEZznv7Q9Aury1TmwyEbEdXPt+oaYaf9M+sy7GpH l9vdNIeIRoTQtbAvpnfxthYbISnFvG7SrhEHoJPZXpkBGEH6rAZIBDrnETCCRIeZoXX+ ObVFZlfZiPQujN83QHkh87id2rQB+4oRd0tMMF4I4mHYtw+NJi2jJEsGBM+M/maWAIXt lprS3rOBJfl6XA+1sdPjvFDJFTWwt1UY3U4wxQp+eAQGkYfU8iPBjvBl84zcdKC0BNOI Kwjg== X-Gm-Message-State: AJaThX45tzERaPeGF8gFM2RbPm8oT6Pe5Wq/d3boIR4Ulds57XSfIvf0 TS63mpV8rCK5YC1L9uK5YbGwXBMNc4E= X-Received: by 10.223.181.132 with SMTP id c4mr17875943wre.42.1512553948795; Wed, 06 Dec 2017 01:52:28 -0800 (PST) Received: from localhost.localdomain ([105.150.171.234]) by smtp.gmail.com with ESMTPSA id w133sm2543113wmg.9.2017.12.06.01.52.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Dec 2017 01:52:27 -0800 (PST) From: Ard Biesheuvel To: linux-efi@vger.kernel.org, Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" Cc: Pan Bian , Ard Biesheuvel , linux-kernel@vger.kernel.org, Matt Fleming , stable@vger.kernel.org Subject: [PATCH 2/3] efi/esrt: use memunmap rather kfree to free the remapping Date: Wed, 6 Dec 2017 09:50:09 +0000 Message-Id: <20171206095010.24170-3-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171206095010.24170-1-ard.biesheuvel@linaro.org> References: <20171206095010.24170-1-ard.biesheuvel@linaro.org> Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org From: Pan Bian The remapping result of memremap should be freed with memunmap, not kfree. Signed-off-by: Pan Bian Cc: Matt Fleming Cc: Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/esrt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c index 7aae2483fcb9..c47e0c6ec00f 100644 --- a/drivers/firmware/efi/esrt.c +++ b/drivers/firmware/efi/esrt.c @@ -428,7 +428,7 @@ static int __init esrt_sysfs_init(void) err_remove_esrt: kobject_put(esrt_kobj); err: - kfree(esrt); + memunmap(esrt); esrt = NULL; return error; }