From patchwork Thu Dec 7 09:45:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 120945 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp8138037qgn; Thu, 7 Dec 2017 01:45:33 -0800 (PST) X-Google-Smtp-Source: AGs4zMaPw8Hut03zQxrhLe90lnKg9X9V3zkUhuUjzU53aUD3W12PdwiaLapZRySocNlc8E2XDqTN X-Received: by 10.159.197.5 with SMTP id bj5mr25625742plb.219.1512639933654; Thu, 07 Dec 2017 01:45:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512639933; cv=none; d=google.com; s=arc-20160816; b=atBXH9iPfj207HNKS6WCrNRj/cC168eVnGVzQGGAR72LMM84X+gEq3NTC8maKnPRWf 7URrl/YmpGd2kykUuFo7vfCbGpNPNWJ3nWAHmzkXd9fScxpjBV8pf6H4O7hu9xjnygih tQB3N2vaxePkiA08mZLInMMnyto9xZmZm6mrFK47WheLOkF+caOLytsqXaQYAoWmaE68 xmM3zj+uYAXCmYEhpWpQccJvge9ybBpzfxPKtjGK81yyUOAnK8wTPYbcS5mvSpGLkN67 LU64eC1tp6/7CRxWfZ2jqumkcWBv7rHErCE71TBXHpMncUmLIiDByGj+uaUSXcZRCv+v re9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=1NE185+YaY1DLyl7P6bHKo/5ylNZzsfb7GLHfUqsfRA=; b=iTgFZ+rZExkxW/J+p180e5aP6EuwD3EOqGJEckzuD0BBQvWFmfqL+M17QNgdc+JqOL 6RyFyVE3Ofd4M4mDBaubOEWRZojFcFmBJHlsc4V40KbifeKgvfvqZqwakPFla73H8nsN wMPfv3KRQ7fr5ZmM2oKtq118s+/IAnRgMasVXHJ82D3ZFCQzt5OWejmoR1htlg6eMRMN kZvD2DbMd9AukB1x7HGMYkjAgb8zRbPyH1bzp0pU9hJ571ffckML6jfImLj3nzd2A1ok /8HvKjae4N9Apvi4mLelqWQPisTJuJ6h0ubCgJQgzHhRJx3uGGKpg00YhZOmqjPe3wBs Ji7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LOzZZQJV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w3si3449363pge.245.2017.12.07.01.45.33; Thu, 07 Dec 2017 01:45:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LOzZZQJV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234AbdLGJpb (ORCPT + 20 others); Thu, 7 Dec 2017 04:45:31 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:41816 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750886AbdLGJp3 (ORCPT ); Thu, 7 Dec 2017 04:45:29 -0500 Received: by mail-pg0-f65.google.com with SMTP id o2so4096172pgc.8 for ; Thu, 07 Dec 2017 01:45:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1NE185+YaY1DLyl7P6bHKo/5ylNZzsfb7GLHfUqsfRA=; b=LOzZZQJVVbTLYB4O/bZ4R7c4oZOT/UP1Pmp5QE0NgTQi1hKa5QxGef0BbmdhvlYI9r 9WPvCx10ZPSPduHa7at14/CLWz2+RRw/0CFCKmeBz7di0eCAUIDYTj1Xfnsy79E3pCUo AmPCQXEwwuR7iiks0e0cJ7M6k355GxtYPwmyA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1NE185+YaY1DLyl7P6bHKo/5ylNZzsfb7GLHfUqsfRA=; b=AhOJi5wtki6Igmh/rmEPKQn9JV+SRErq7CGg3j3tOw+o8UlvjVpxesGtOveNalZH9t clcUiGTqCke1xDMAg/NUsIh5P0nNP5Wrax2hOXgiagd4TsvzcG14dJLmYhxXhzExRcEB 2P6MslCDiuOeVaVork1SI89p2wXRmf8BmswsmbXh/YjkAEUwiMDZNZ4CJyktQbEJtLF2 xdLL0G7pKi4qFRcIG7Rml7Iqz5ItfGWvDlg7N1BY76tAbnx3JrGLgVdGQvs7zz4u4Lt0 1SfLU0w/Gmkgr894VEZgkNCMDBFW3U9SdeapTNPKY+c9o/ThtUyAGVIRt22siz1eIBNo qoZA== X-Gm-Message-State: AJaThX4ylxkRIRnHX+lKVWK2nUQtJUUNmtxbzY5Oe36LkOHSnvypySdn EhkHynKJr0zZM94rMVtJuhQ3Kg== X-Received: by 10.99.146.18 with SMTP id o18mr24674733pgd.380.1512639929469; Thu, 07 Dec 2017 01:45:29 -0800 (PST) Received: from localhost ([117.223.196.91]) by smtp.gmail.com with ESMTPSA id p77sm10048678pfd.132.2017.12.07.01.45.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Dec 2017 01:45:28 -0800 (PST) From: Viresh Kumar To: Rafael Wysocki , mroos@linux.ee Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , "4 . 14+" , linux-kernel@vger.kernel.org Subject: [PATCH V2] cpufreq: longhaul: Revert transition_delay_us to 200 ms Date: Thu, 7 Dec 2017 15:15:19 +0530 Message-Id: <4985fe0a825edcd4b5a13f4c42e4d5b8f49d25ff.1512639844.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The commit e948bc8fbee0 ("cpufreq: Cap the default transition delay value to 10 ms") caused a regression on EPIA-M min-ITX computer where shutdown or reboot hangs occasionally with a print message like: longhaul: Warning: Timeout while waiting for idle PCI bus cpufreq: __target_index: Failed to change cpu frequency: -16 This probably happens because the cpufreq governor tries to change the frequency of the CPU faster than allowed by the hardware. Before the above commit, the default transition delay was set to 200 ms for a transition_latency of 200000 ns. Lets revert back to that transition delay value to fix it. Note that several other transition delay values were tested like 20 ms and 30 ms and none of them have resolved system hang issue completely. Fixes: e948bc8fbee0 ("cpufreq: Cap the default transition delay value to 10 ms") Cc: 4.14+ # 4.14+ Reported-by: Meelis Roos Suggested-by: Rafael J. Wysocki Signed-off-by: Viresh Kumar --- V1->V2: - s/20 ms/200 ms. drivers/cpufreq/longhaul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.1 diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c index c46a12df40dd..5faa37c5b091 100644 --- a/drivers/cpufreq/longhaul.c +++ b/drivers/cpufreq/longhaul.c @@ -894,7 +894,7 @@ static int longhaul_cpu_init(struct cpufreq_policy *policy) if ((longhaul_version != TYPE_LONGHAUL_V1) && (scale_voltage != 0)) longhaul_setup_voltagescaling(); - policy->cpuinfo.transition_latency = 200000; /* nsec */ + policy->transition_delay_us = 200000; /* usec */ return cpufreq_table_validate_and_show(policy, longhaul_table); }