clk: qcom: gcc-msm8996: always enable aggre0_noc gdsc

Message ID 20171207141618.4694-1-srinivas.kandagatla@linaro.org
State New
Headers show
Series
  • clk: qcom: gcc-msm8996: always enable aggre0_noc gdsc
Related show

Commit Message

Srinivas Kandagatla Dec. 7, 2017, 2:16 p.m.
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>


bus clks which depend on this gdsc are marked as critical,
so this patch flags this gdsc ALWAYS_ON so that bus clks status
does not get stuck at on or off.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

---
 drivers/clk/qcom/gcc-msm8996.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.15.0

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Stephen Boyd Dec. 7, 2017, 10:54 p.m. | #1
On 12/07, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> 

> bus clks which depend on this gdsc are marked as critical,

> so this patch flags this gdsc ALWAYS_ON so that bus clks status

> does not get stuck at on or off.

> 

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> ---

>  drivers/clk/qcom/gcc-msm8996.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/clk/qcom/gcc-msm8996.c b/drivers/clk/qcom/gcc-msm8996.c

> index 0146d8853488..b2be77469693 100644

> --- a/drivers/clk/qcom/gcc-msm8996.c

> +++ b/drivers/clk/qcom/gcc-msm8996.c

> @@ -3101,7 +3101,7 @@ static struct gdsc aggre0_noc_gdsc = {

>  		.name = "aggre0_noc",

>  	},

>  	.pwrsts = PWRSTS_OFF_ON,

> -	.flags = VOTABLE,

> +	.flags = VOTABLE | ALWAYS_ON,


I dont think this flag has been added yet. Probably this needs to
be folded into the other series?


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Srinivas Kandagatla Dec. 7, 2017, 11:30 p.m. | #2
On 07/12/17 22:54, Stephen Boyd wrote:
>>   	.pwrsts = PWRSTS_OFF_ON,

>> -	.flags = VOTABLE,

>> +	.flags = VOTABLE | ALWAYS_ON,

> I dont think this flag has been added yet. Probably this needs to

> be folded into the other series?

I agree, I will wait for Rajendras patches to land in or I can request 
Rajendra to fold this into his series.




thanks,
srini
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/clk/qcom/gcc-msm8996.c b/drivers/clk/qcom/gcc-msm8996.c
index 0146d8853488..b2be77469693 100644
--- a/drivers/clk/qcom/gcc-msm8996.c
+++ b/drivers/clk/qcom/gcc-msm8996.c
@@ -3101,7 +3101,7 @@  static struct gdsc aggre0_noc_gdsc = {
 		.name = "aggre0_noc",
 	},
 	.pwrsts = PWRSTS_OFF_ON,
-	.flags = VOTABLE,
+	.flags = VOTABLE | ALWAYS_ON,
 };
 
 static struct gdsc hlos1_vote_aggre0_noc_gdsc = {