From patchwork Thu Dec 7 15:45:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Levin, Alexander \(Sasha Levin\)" X-Patchwork-Id: 121039 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp8678391qgn; Thu, 7 Dec 2017 10:05:56 -0800 (PST) X-Google-Smtp-Source: AGs4zMZkOT3EI/y1DbWIZyWMigCnGNkkMEkjKGYw5DZIBB89vqBK7qrChIFtzjHCOjleyGgtz2Iw X-Received: by 10.159.254.12 with SMTP id r12mr27633922pls.218.1512669956875; Thu, 07 Dec 2017 10:05:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512669956; cv=none; d=google.com; s=arc-20160816; b=oDj0pqX971i0RDbNEuN6Gz3PkDjSN30Kt/Lpiu2bCECgAPWKPPOZdBasMDUKNBVC8c F1RIVrpnFjp53CUHW9nH5YGXnCBwUfFT4Io76xbqyYo+vFC5bhEzPsHMWCHzTTl3pdEH SGc9XJ8Bh7pNzifoUeHoaRctjL2Ob7k0Wc05iUE6HOkp7PIjd2Ddu8Jcj4nKiqIV/tet yXWcdj2uBPy28S9ZPa1YBxe1SaGF7sjRP5W1V3o6RF/usTKLL52c5D70/9lrwtktYe9x ccYa8igFVY909GZLxW0vqSwhiE5Awo3kxbqwcdlkM+FW/+RJs880Ryn5K+99a6+IA37X u27Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:to:cc:from:dkim-signature :dkim-signature:dkim-signature:arc-authentication-results; bh=SzOMVy4p3VfwXXu4HCUPgWZKPnQ1pjqdxWciK8tDV3Q=; b=P6swOrQf2CqVaqaGgeurCLM7bHWNlUO1QTJpxozf4Ul99FXJ+xBsHSd3FzuTdKVoH5 5FHb2MyUAdQP29i5DcEvHu7W8AM0qGiBxiS+gv66QXJrMmI8cxSEgjWSGUt7fmaITzsP PRabKY7/K4sgL5hyiDZirsfqq8aFY4azeCghoVrbFR42igD9/x/z1Tdunz6kObMZAklu oIP5gV3k/RoEJtu070y0eAhVHgcfuq4tjX3L3RiHrjAdkptYWJ9QxmMBX3gjwL72dwTR 4gG+bdOGO/Dnlqg0aUIYrmkRpwMsdCBX2D52b2MDYg3W9eQCZV6cKVxcTVQO2AlUMZ+R nFKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@verizon.com header.s=corp header.b=VkS/Y+Ws; dkim=fail header.i=@verizon.com header.s=corp header.b=IFx5TKb4; dkim=fail header.i=@verizon.com header.s=corp header.b=p3Cgpm3i; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m8si4465574pfi.343.2017.12.07.10.05.56; Thu, 07 Dec 2017 10:05:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@verizon.com header.s=corp header.b=VkS/Y+Ws; dkim=fail header.i=@verizon.com header.s=corp header.b=IFx5TKb4; dkim=fail header.i=@verizon.com header.s=corp header.b=p3Cgpm3i; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754286AbdLGSFz (ORCPT + 10 others); Thu, 7 Dec 2017 13:05:55 -0500 Received: from fldsmtpe03.verizon.com ([140.108.26.142]:3964 "EHLO fldsmtpe03.verizon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755472AbdLGPrH (ORCPT ); Thu, 7 Dec 2017 10:47:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1512661627; x=1544197627; h=from:cc:to:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AT1r/LjsaO8rcBb8BWz8zEuWRcVp5qZlBpSbUr5bI8s=; b=VkS/Y+WspYiFUpZ5/dT/yPYUlTBxqYoBPuxoZmTa/hqOCyVYNOxcULQC +ZCc/PlENZOnsa5MeOHmkWrbZSJWvEYbC984s3DUH6mHN6z5DFoDSEgpP 9vK1HGXsYdQmaoLlB6gY+M3Et1VKJusBEEg8rhhR1MXY5SPhpMwhtE/hC c=; Received: from unknown (HELO fldsmtpi02.verizon.com) ([166.68.71.144]) by fldsmtpe03.verizon.com with ESMTP; 07 Dec 2017 15:47:03 +0000 Received: from rogue-10-255-192-101.rogue.vzwcorp.com (HELO apollo.verizonwireless.com) ([10.255.192.101]) by fldsmtpi02.verizon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 07 Dec 2017 15:46:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1512661592; x=1544197592; h=from:cc:to:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AT1r/LjsaO8rcBb8BWz8zEuWRcVp5qZlBpSbUr5bI8s=; b=IFx5TKb4Hg2bYyZLhGso+bLrzQU/f7L6dK6KAGUbz7xNaH9/kOYFhXch fd2CAisooMDE9RbdZLKSRzLKw7/gRdFbEaTyMXxBrL8Te177QaAcf1jqm 0xqwKZ3vt/G5calAGQ/mtHMw35Kd5z2n8BZZrAy+jPz1p0/KCp0ODHpHi 0=; Received: from pioneer.tdc.vzwcorp.com (HELO eris.verizonwireless.com) ([10.254.88.34]) by apollo.verizonwireless.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 07 Dec 2017 10:46:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1512661592; x=1544197592; h=to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:from:cc; bh=AT1r/LjsaO8rcBb8BWz8zEuWRcVp5qZlBpSbUr5bI8s=; b=p3Cgpm3irXSZJfsT6SD0y1fdfTK9ubSDqOOz97C7WcFaM8vgWBR0BFWQ P1MuhCs0eZXN0xbQ468uZLFjPtPCSPZOa7hJEmvBFnROtuHVdiFDJh2id 5jkmCK4ZJygEkwcyn/A66WaLrxZgWEEqQ6iVfyu5sFJcsdrm8OrttHIHX M=; From: alexander.levin@verizon.com Cc: Kishon Vijay Abraham I , Bjorn Helgaas , alexander.levin@verizon.com X-Host: pioneer.tdc.vzwcorp.com Received: from ohtwi1exh003.uswin.ad.vzwcorp.com ([10.144.218.45]) by eris.verizonwireless.com with ESMTP/TLS/AES128-SHA256; 07 Dec 2017 15:46:32 +0000 Received: from tbwexch09apd.uswin.ad.vzwcorp.com (153.114.162.33) by OHTWI1EXH003.uswin.ad.vzwcorp.com (10.144.218.45) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 7 Dec 2017 10:46:32 -0500 Received: from OMZP1LUMXCA19.uswin.ad.vzwcorp.com (144.8.22.197) by tbwexch09apd.uswin.ad.vzwcorp.com (153.114.162.33) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Thu, 7 Dec 2017 10:46:32 -0500 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com (144.8.22.195) by OMZP1LUMXCA19.uswin.ad.vzwcorp.com (144.8.22.197) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Thu, 7 Dec 2017 09:46:30 -0600 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) by OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) with mapi id 15.00.1263.000; Thu, 7 Dec 2017 09:46:31 -0600 To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: [PATCH AUTOSEL for 4.14 052/135] misc: pci_endpoint_test: Fix failure path return values in probe Thread-Topic: [PATCH AUTOSEL for 4.14 052/135] misc: pci_endpoint_test: Fix failure path return values in probe Thread-Index: AQHTb3JwRNdyJATqQUqACMesp3J1Og== Date: Thu, 7 Dec 2017 15:45:42 +0000 Message-ID: <20171207154513.4154-52-alexander.levin@verizon.com> References: <20171207154513.4154-1-alexander.levin@verizon.com> In-Reply-To: <20171207154513.4154-1-alexander.levin@verizon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Kishon Vijay Abraham I [ Upstream commit 80068c93688f6143100859c4856f895801c1a1d9 ] Return value of pci_endpoint_test_probe is not set properly in a couple of failure cases. Fix it here. Signed-off-by: Kishon Vijay Abraham I Signed-off-by: Bjorn Helgaas Signed-off-by: Sasha Levin --- drivers/misc/pci_endpoint_test.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.11.0 diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c index deb203026496..e787a63a321a 100644 --- a/drivers/misc/pci_endpoint_test.c +++ b/drivers/misc/pci_endpoint_test.c @@ -533,6 +533,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev, test->base = test->bar[test_reg_bar]; if (!test->base) { + err = -ENOMEM; dev_err(dev, "Cannot perform PCI test without BAR%d\n", test_reg_bar); goto err_iounmap; @@ -542,6 +543,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev, id = ida_simple_get(&pci_endpoint_test_ida, 0, 0, GFP_KERNEL); if (id < 0) { + err = id; dev_err(dev, "unable to get id\n"); goto err_iounmap; }