[RESEND,v2] dt: bindings: as3645a: Fix the example node

Message ID 20171208155514.7696-1-dmurphy@ti.com
State New
Headers show
Series
  • [RESEND,v2] dt: bindings: as3645a: Fix the example node
Related show

Commit Message

Dan Murphy Dec. 8, 2017, 3:55 p.m.
Fix the address-cells and size-cells example node
to reflect to the correct representation.

Signed-off-by: Dan Murphy <dmurphy@ti.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

---

v2 - Moved compatible to be first in the node - https://patchwork.kernel.org/patch/10092937/

 Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.15.0.124.g7668cbc60

Comments

Dan Murphy Dec. 8, 2017, 3:56 p.m. | #1
Resent to include DT maintainers

On 12/08/2017 09:55 AM, Dan Murphy wrote:
> Fix the address-cells and size-cells example node

> to reflect to the correct representation.

> 

> Signed-off-by: Dan Murphy <dmurphy@ti.com>

> Acked-by: Pavel Machek <pavel@ucw.cz>

> ---

> 

> v2 - Moved compatible to be first in the node - https://patchwork.kernel.org/patch/10092937/

> 

>  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---

>  1 file changed, 3 insertions(+), 3 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt

> index fdc40e354a64..fc7f5f9f234c 100644

> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt

> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt

> @@ -59,10 +59,10 @@ Example

>  =======

>  

>  	as3645a@30 {


Rob

Here is an example of the device name being part of the node name.

Should this be changed as well to leds@30?

Dan

> -		#address-cells: 1

> -		#size-cells: 0

> -		reg = <0x30>;

>  		compatible = "ams,as3645a";

> +		#address-cells = <1>;

> +		#size-cells = <0>;

> +		reg = <0x30>;

>  		flash@0 {

>  			reg = <0x0>;

>  			flash-timeout-us = <150000>;

> 



-- 
------------------
Dan Murphy
Rob Herring Dec. 15, 2017, 8:26 p.m. | #2
On Fri, Dec 08, 2017 at 09:56:18AM -0600, Dan Murphy wrote:
> Resent to include DT maintainers

> 

> On 12/08/2017 09:55 AM, Dan Murphy wrote:

> > Fix the address-cells and size-cells example node

> > to reflect to the correct representation.

> > 

> > Signed-off-by: Dan Murphy <dmurphy@ti.com>

> > Acked-by: Pavel Machek <pavel@ucw.cz>

> > ---

> > 

> > v2 - Moved compatible to be first in the node - https://patchwork.kernel.org/patch/10092937/

> > 

> >  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---

> >  1 file changed, 3 insertions(+), 3 deletions(-)

> > 

> > diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt

> > index fdc40e354a64..fc7f5f9f234c 100644

> > --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt

> > +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt

> > @@ -59,10 +59,10 @@ Example

> >  =======

> >  

> >  	as3645a@30 {

> 

> Rob

> 

> Here is an example of the device name being part of the node name.

> 

> Should this be changed as well to leds@30?


Yes, but I misspoke earlier and it should be "led-controller@30"

That can be a separate patch though, so for this one:

Reviewed-by: Rob Herring <robh@kernel.org>

Patch

diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
index fdc40e354a64..fc7f5f9f234c 100644
--- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
+++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
@@ -59,10 +59,10 @@  Example
 =======
 
 	as3645a@30 {
-		#address-cells: 1
-		#size-cells: 0
-		reg = <0x30>;
 		compatible = "ams,as3645a";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <0x30>;
 		flash@0 {
 			reg = <0x0>;
 			flash-timeout-us = <150000>;