Applied "ASoC: nuc900: Fix a loop timeout test" to the asoc tree

Message ID E1eOMyC-0004dm-GN@debutante
State New
Headers show
  • Applied "ASoC: nuc900: Fix a loop timeout test" to the asoc tree
Related show

Commit Message

Mark Brown Dec. 11, 2017, 12:14 p.m.
The patch

   ASoC: nuc900: Fix a loop timeout test

has been applied to the asoc tree at 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.


From 65a12b3aafed5fc59f4ce41b22b752b1729e6701 Mon Sep 17 00:00:00 2001
From: Dan Carpenter <>

Date: Sat, 9 Dec 2017 14:52:28 +0300
Subject: [PATCH] ASoC: nuc900: Fix a loop timeout test

We should be finishing the loop with timeout set to zero but because
this is a post-op we finish with timeout == -1.

Fixes: 1082e2703a2d ("ASoC: NUC900/audio: add nuc900 audio driver support")
Signed-off-by: Dan Carpenter <>

Signed-off-by: Mark Brown <>

 sound/soc/nuc900/nuc900-ac97.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


Alsa-devel mailing list


diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
index 71fce7c85c93..81b09d740ed9 100644
--- a/sound/soc/nuc900/nuc900-ac97.c
+++ b/sound/soc/nuc900/nuc900-ac97.c
@@ -67,7 +67,7 @@  static unsigned short nuc900_ac97_read(struct snd_ac97 *ac97,
 	/* polling the AC_R_FINISH */
 	while (!(AUDIO_READ(nuc900_audio->mmio + ACTL_ACCON) & AC_R_FINISH)
-								&& timeout--)
+								&& --timeout)
 	if (!timeout) {
@@ -121,7 +121,7 @@  static void nuc900_ac97_write(struct snd_ac97 *ac97, unsigned short reg,
 	/* polling the AC_W_FINISH */
 	while ((AUDIO_READ(nuc900_audio->mmio + ACTL_ACCON) & AC_W_FINISH)
-								&& timeout--)
+								&& --timeout)
 	if (!timeout)