From patchwork Mon Dec 11 19:07:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 121454 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp3170429qgn; Mon, 11 Dec 2017 11:11:00 -0800 (PST) X-Google-Smtp-Source: ACJfBou8jf3d8pVolVTj9tR67rHGWzJtCWkHjQNXx8NjaKSc9YA0NlSO3M52kKqFx7/nsNkET8Ke X-Received: by 10.98.87.142 with SMTP id i14mr1313880pfj.212.1513019460487; Mon, 11 Dec 2017 11:11:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513019460; cv=none; d=google.com; s=arc-20160816; b=nZORAPlqka0Ovkw3BjICTaTMQ1+3Ll1h0zxSIeg7LbqcI8bTGf8lkobz0UpfSKOPVq zfhB0kyHMugXR9zi2yXa+5zTZirzfuO2iNMIeZluhwRAOOWCuonGIw4BhP8iA92E2m8Z UJHRnrPJ2w9A7elex/3Cf1pbGJmQ5BoYgSaq1VxHlT1x8vNv0H+ulvKgCpkfz4I+h4IN bbeughyGRIsGZwrqXI80VvBfSdfVNaqKJvu2JnOALJuzkcCFDavxY67o1iG+sIhRnyX6 mW2EvBQzpyereGkcjMIPDaFb8ijjNncVRE2OPmMpWXxd2Qk+wQcbEr8VHdeOUg672a6e QIfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:to:from:delivered-to :sender:list-help:list-post:list-archive:list-subscribe :list-unsubscribe:list-id:precedence:mailing-list:dkim-signature :domainkey-signature:arc-authentication-results; bh=LuUi+moPndPT4N7Zk4+fgNS7AH0XNQzu4dhDSpxK7r4=; b=PUYvH7TaP31us78d+Iq60sijox5rJJxhXM1SbR9NITH3sj8YRxGWBbI8hFr2E67a7v HDCSfisvI0PgQlPqL2dX0Cdmi1Vmvx0UvE+srI+iouScyi81m966/cU8SUNI/GH86wkp DsmRf7Xoz63ZcuE4wacpOZJAzKH1rsTBjaWI4uA3IBlx1bDIaBzKApRp1CeBiKCaq7In YVi1HwRvT64k8XVJNgRVLA2IPsDaLsyV5iUtaiLtxmu4QygDnRUSXj8yExdobG1YKNqd zKITD6vR82MjU1voU0zBc4SHwv/+6kCpMiMWDviZgdmmDru+N70TG5I9nSc/wKVrnB7w OV9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=Cew4XbY6; spf=pass (google.com: domain of libc-alpha-return-88031-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=libc-alpha-return-88031-patch=linaro.org@sourceware.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id l59si10327765plb.743.2017.12.11.11.11.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Dec 2017 11:11:00 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-return-88031-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=Cew4XbY6; spf=pass (google.com: domain of libc-alpha-return-88031-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=libc-alpha-return-88031-patch=linaro.org@sourceware.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=cSbmHuPv70tNbHI/kw585lF3kpPc4yB xK13XwxWwcu5pMx0sTRg1pDKGLown8qMgdAWIUAd9yF7f+ffFLdZ2taMhJU6zNVS dmAEc2NdahA3BrJxzLO3mmsoalLHyKbgQiRVCO0ys6+LVWbeXPcoobIRU5Ybi+ZH SxI4bwL/6NaE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=Rbc2DlgLIN3dng+vNcC3h6PoObk=; b=Cew4X bY6Bfs3+5BTmrtgvE80TUd+vc/zMyqUORpvdoxCYT+ygLA18zwBc+N3pCOEbRX0q 74XLQeT8YPmuIxpaRraMwKrAkKAMNUMMdKwVKd6H4n5TlEtjWBJT8Fsvdfs01bFd HacVDep160xI0I39mMSueuZ6pNDlV6hMVhRZjs= Received: (qmail 43032 invoked by alias); 11 Dec 2017 19:07:40 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 42987 invoked by uid 89); 11 Dec 2017 19:07:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f193.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=LuUi+moPndPT4N7Zk4+fgNS7AH0XNQzu4dhDSpxK7r4=; b=mhxPqkDj69rXwC+YoYvh+zpFlFwdlz+utNHkphug32zkHSa0Q2t2Ml9KQxK2zIaMx1 U+Q/0vFpgxHzhFw8mORriZs0deWdPne0q6K/cA0kamybGIGkaUWEEpdc/i/fYCIFYl0b 12a1IR5yR+rXa/3y5iS8lMgAJt+MMSZR4K/+HMg+hRToMu/8j56yOZ78KQntpFepAEyX X9+Arp21nGG04a7e8P2vIJbf1avDqCyi8x//QwKWMAC7VbwJIZGZ8fG0LUeDS4vsTe3k pICqLCMHOt0f6a0ROq1fF3YZrlunPsgQsiKb49z4ieFz6CtRQZEena6heb49jMs40ccy iv4g== X-Gm-Message-State: AKGB3mIznT1iSWqlScfjIw5mplcoLgN7a0JH0iUh6GR5qxqULtsu7qPy Io8/8GhhJ7kVjBJ6WzKyhV69gbLP34w= X-Received: by 10.200.57.133 with SMTP id v5mr2088962qte.30.1513019255906; Mon, 11 Dec 2017 11:07:35 -0800 (PST) From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH 17/19] nptl: sh: Fix Race conditions in pthread cancellation (BZ#12683) Date: Mon, 11 Dec 2017 17:07:01 -0200 Message-Id: <1513019223-7603-18-git-send-email-adhemerval.zanella@linaro.org> In-Reply-To: <1513019223-7603-1-git-send-email-adhemerval.zanella@linaro.org> References: <1513019223-7603-1-git-send-email-adhemerval.zanella@linaro.org> This patch adds the sh modifications required for the BZ#12683. It basically adds the required ucontext_get_pc function and a cancellable syscall wrapper. SH requires an arch-specific syscall_cancel because the INTERNAL_SYSCALL_NCS adds the required or instruction to workaround a hardware bug [1]. The implementation were based on on default C version built with GCC 6.2.1. Checked against a build and make check run-built-tests=no for sh4-linux-gnu. * sysdeps/unix/sysv/linux/sh/syscall_cancel.S: New file. * sysdeps/unix/sysv/linux/sh/sigcontextinfo.h (ucontext_get_pc): New function. [1] http://documentation.renesas.com/eng/products/mpumcu/tu/tnsh7456ae.pdf Signed-off-by: Adhemerval Zanella --- ChangeLog | 5 ++ sysdeps/sh/sysdep.h | 1 + sysdeps/unix/sysv/linux/sh/sigcontextinfo.h | 11 +++ sysdeps/unix/sysv/linux/sh/syscall_cancel.S | 125 ++++++++++++++++++++++++++++ 4 files changed, 142 insertions(+) create mode 100644 sysdeps/unix/sysv/linux/sh/syscall_cancel.S -- 2.7.4 diff --git a/sysdeps/sh/sysdep.h b/sysdeps/sh/sysdep.h index 939c931..4208da9 100644 --- a/sysdeps/sh/sysdep.h +++ b/sysdeps/sh/sysdep.h @@ -24,6 +24,7 @@ #define ALIGNARG(log2) log2 #define ASM_SIZE_DIRECTIVE(name) .size name,.-name +#define L(label) .L##label #ifdef SHARED #define PLTJMP(_x) _x##@PLT diff --git a/sysdeps/unix/sysv/linux/sh/sigcontextinfo.h b/sysdeps/unix/sysv/linux/sh/sigcontextinfo.h index 546f23b..3520286 100644 --- a/sysdeps/unix/sysv/linux/sh/sigcontextinfo.h +++ b/sysdeps/unix/sysv/linux/sh/sigcontextinfo.h @@ -16,6 +16,9 @@ License along with the GNU C Library; if not, see . */ +#ifndef _SIGCONTEXTINFO_H +#define _SIGCONTEXTINFO_H + #define SIGCONTEXT int _a2, int _a3, int _a4, struct sigcontext #define SIGCONTEXT_EXTRA_ARGS _a2, _a3, _a4, @@ -24,3 +27,11 @@ #define GET_STACK(ctx) ((void *) ctx.sc_regs[15]) #define CALL_SIGHANDLER(handler, signo, ctx) \ (handler)((signo), SIGCONTEXT_EXTRA_ARGS (ctx)) + +static inline uintptr_t +ucontext_get_pc (const ucontext_t *uc) +{ + return uc->uc_mcontext.pc; +} + +#endif /* _SIGCONTEXTINFO_H */ diff --git a/sysdeps/unix/sysv/linux/sh/syscall_cancel.S b/sysdeps/unix/sysv/linux/sh/syscall_cancel.S new file mode 100644 index 0000000..02a050d --- /dev/null +++ b/sysdeps/unix/sysv/linux/sh/syscall_cancel.S @@ -0,0 +1,125 @@ +/* Cancellable syscall wrapper. Linux/sh version. + Copyright (C) 2017 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include + +/* long int __syscall_cancel_arch (int *cancelhandling, + long int nr, + long int arg1, + long int arg2, + long int arg3, + long int arg4, + long int arg5, + long int arg6) */ + +ENTRY (__syscall_cancel_arch) + +#ifdef SHARED + mov.l r12,@-r15 + cfi_def_cfa_offset (4) + cfi_offset (12, -4) + mova L(GT),r0 + mov.l L(GT),r12 + sts.l pr,@-r15 + cfi_def_cfa_offset (8) + cfi_offset (17, -8) + add r0,r12 +#else + sts.l pr,@-r15 + cfi_def_cfa_offset (4) + cfi_offset (17, -4) +#endif + + .globl __syscall_cancel_arch_start +__syscall_cancel_arch_start: + + /* if (*cancelhandling & CANCELED_BITMASK) + __syscall_do_cancel() */ + mov.l @r4,r0 + tst #4,r0 + bf/s 1f + + /* Issue a 6 argument syscall. */ + mov r5,r3 + mov r6,r4 + mov r7,r5 +#ifdef SHARED + mov.l @(8,r15),r6 + mov.l @(12,r15),r7 + mov.l @(16,r15),r0 + mov.l @(20,r15),r1 +#else + mov.l @(4,r15),r6 + mov.l @(8,r15),r7 + mov.l @(12,r15),r0 + mov.l @(16,r15),r1 +#endif + trapa #0x16 + +/* The additional or is a workaround for a hardware issue: + http://documentation.renesas.com/eng/products/mpumcu/tu/tnsh7456ae.pdf */ + .globl __syscall_cancel_arch_end +__syscall_cancel_arch_end: + + or r0,r0 + or r0,r0 + or r0,r0 + or r0,r0 + or r0,r0 + + lds.l @r15+,pr + cfi_remember_state + cfi_restore (17) +#ifdef SHARED + cfi_def_cfa_offset (4) + rts + mov.l @r15+,r12 + cfi_def_cfa_offset (0) + cfi_restore (12) + .align 1 +1: + cfi_restore_state + mov.l L(SC),r1 + bsrf r1 +L(M): + nop + + .align 2 +L(GT): + .long _GLOBAL_OFFSET_TABLE_ +L(SC): + .long __syscall_do_cancel-(L(M)+2) +#else + cfi_def_cfa_offset (0) + rts + nop + + .align 1 +1: + cfi_restore_state + mov.l 2f,r1 + jsr @r1 + nop + + .align 2 +2: + .long __syscall_do_cancel +#endif + +END (__syscall_cancel_arch) +libc_hidden_def (__syscall_cancel_arch)