leds: as3645a: Fix checkpatch warnings

Message ID 20171212215011.30066-1-dmurphy@ti.com
State New
Headers show
Series
  • leds: as3645a: Fix checkpatch warnings
Related show

Commit Message

Dan Murphy Dec. 12, 2017, 9:50 p.m.
Fix two checkpatch warnings for 80 char
length and for a quoted string across multiple
line warnings.

Signed-off-by: Dan Murphy <dmurphy@ti.com>

---
 drivers/leds/leds-as3645a.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

-- 
2.15.0.124.g7668cbc60

Comments

Pavel Machek Dec. 13, 2017, 12:56 p.m. | #1
On Tue 2017-12-12 15:50:11, Dan Murphy wrote:
> Fix two checkpatch warnings for 80 char

> length and for a quoted string across multiple

> line warnings.

> 

> Signed-off-by: Dan Murphy <dmurphy@ti.com>


Acked-by: Pavel Machek <pavel@ucw.cz>


> ---

>  drivers/leds/leds-as3645a.c | 7 ++++---

>  1 file changed, 4 insertions(+), 3 deletions(-)

> 

> diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c

> index 9a257f969300..f883616d9e60 100644

> --- a/drivers/leds/leds-as3645a.c

> +++ b/drivers/leds/leds-as3645a.c

> @@ -360,7 +360,8 @@ static int as3645a_set_flash_brightness(struct led_classdev_flash *fled,

>  {

>  	struct as3645a *flash = fled_to_as3645a(fled);

>  

> -	flash->flash_current = as3645a_current_to_reg(flash, true, brightness_ua);

> +	flash->flash_current = as3645a_current_to_reg(flash, true,

> +						      brightness_ua);

>  

>  	return as3645a_set_current(flash);

>  }

> @@ -455,8 +456,8 @@ static int as3645a_detect(struct as3645a *flash)

>  

>  	/* Verify the chip model and version. */

>  	if (model != 0x01 || rfu != 0x00) {

> -		dev_err(dev, "AS3645A not detected "

> -			"(model %d rfu %d)\n", model, rfu);

> +		dev_err(dev, "AS3645A not detected (model %d rfu %d)\n",

> +			model, rfu);

>  		return -ENODEV;

>  	}

>  



(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Pavel Machek Dec. 14, 2017, 10:49 p.m. | #2
On Wed 2017-12-13 21:29:29, Jacek Anaszewski wrote:
> Hi Dan,

> 

> checkpatch.pl doesn't want to be mentioned in the patch subject :-)

> 

> "WARNING: A patch subject line should describe the change not the tool

> that found it"


That is pretty stupid rule. Everyone and their dog knows what
"checkpatch fixes" are.
									
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Patch

diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
index 9a257f969300..f883616d9e60 100644
--- a/drivers/leds/leds-as3645a.c
+++ b/drivers/leds/leds-as3645a.c
@@ -360,7 +360,8 @@  static int as3645a_set_flash_brightness(struct led_classdev_flash *fled,
 {
 	struct as3645a *flash = fled_to_as3645a(fled);
 
-	flash->flash_current = as3645a_current_to_reg(flash, true, brightness_ua);
+	flash->flash_current = as3645a_current_to_reg(flash, true,
+						      brightness_ua);
 
 	return as3645a_set_current(flash);
 }
@@ -455,8 +456,8 @@  static int as3645a_detect(struct as3645a *flash)
 
 	/* Verify the chip model and version. */
 	if (model != 0x01 || rfu != 0x00) {
-		dev_err(dev, "AS3645A not detected "
-			"(model %d rfu %d)\n", model, rfu);
+		dev_err(dev, "AS3645A not detected (model %d rfu %d)\n",
+			model, rfu);
 		return -ENODEV;
 	}