From patchwork Wed Dec 13 01:59:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Levin, Alexander \(Sasha Levin\)" X-Patchwork-Id: 121707 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp4895906qgn; Tue, 12 Dec 2017 18:13:41 -0800 (PST) X-Google-Smtp-Source: ACJfBov/fptYCAnx8oHgOYtJWq1e3OGqCoqObd3oaevaMuuFCeH31PLQxuTsLelCaphYoPdIAiBD X-Received: by 10.99.168.67 with SMTP id i3mr3857612pgp.330.1513131221003; Tue, 12 Dec 2017 18:13:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513131220; cv=none; d=google.com; s=arc-20160816; b=S0s1lRBNwjWfQxCP5mq+8qxJzOEgvctNPL5aafKkWYTgiYKo7kYNPU9sy3MhaK4j46 +eNMhQSO10yv5I5kAjdI4D3rqHeChMB6xyKufBeA3dZgNcLlSp4PbsFjgmOQVj/MatT4 UL93Afj8bWNKXiUHs4+vN2NvnY7JIVnfmO4/YaPkr3tY6HX4O125hzWSOoyUR3pO7Q8Q gSWP5Kf1bboFjeLAWnaMjVieSMkb/1tK7mLq2MzDOr7KuXRWGss4pjzR/bFTLjMQcBzf xPuuAiVfHDLVx5WZXhmiVfjfmd9eor+ps/qU9jxDgP9wW94uxCSvm7RXNjMnCI2pJxXJ W1Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:to:cc:from:dkim-signature :dkim-signature:dkim-signature:arc-authentication-results; bh=VKcUfz1ia4idFefQJWoqYNcdD2GkcOFdjbdLY19FhQU=; b=c1p55WpOx81uOqKE74m75lBvYI7VD5An7vRhNmb9SCw5EUjH18+KKs1Fi0VFNvUAqR ePbjezMQ+mlIDyp2Xfy3tiQtliz/XjLyDqcgki34qWTkePMUbZlC9r73aQcKXmxxcMpa cIpM5mmtJtNoSCmEv8Bs825RbmiTySv4Us7Fmc7Jxpwy+LmotgZUD31vzPWDfnTnfWB7 8m1IA0sLqSwHTzPPsVyxyLcKTs1ipbwFdlnRU7Outyo8rU2NUQE3ndg+0n9FrR/TDp9R rh+fP4VTfhQtBjJFMAK1BsrJkZvqb/Mw3cEtpidV6js0wypam2fPjLiSArJa9MSiVHFg PcbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@verizon.com header.s=corp header.b=MNMZJQj7; dkim=fail header.i=@verizon.com header.s=corp header.b=hCky0M5u; dkim=fail header.i=@verizon.com header.s=corp header.b=TBUGmkDj; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n59si432706plb.673.2017.12.12.18.13.40; Tue, 12 Dec 2017 18:13:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@verizon.com header.s=corp header.b=MNMZJQj7; dkim=fail header.i=@verizon.com header.s=corp header.b=hCky0M5u; dkim=fail header.i=@verizon.com header.s=corp header.b=TBUGmkDj; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753575AbdLMCNi (ORCPT + 10 others); Tue, 12 Dec 2017 21:13:38 -0500 Received: from omzsmtpe03.verizonbusiness.com ([199.249.25.208]:39443 "EHLO omzsmtpe03.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753723AbdLMCBK (ORCPT ); Tue, 12 Dec 2017 21:01:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1513130469; x=1544666469; h=from:cc:to:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=heb6R2cmPQc+YGUc/+76JrfPTAdHAoRZI990hDokSHs=; b=MNMZJQj7Ti4k0L6haQgl9p+biFJ8S7BK5pEomuVA/dzWveJzrvCaXWhE 5UwYgbynl5dwq1w3Ti8lhfJmk+zbre3w13exBRy82e5cnFHza5ExbdrZR WErQMwzSe3cisH0KFKlL5Wqb/AjKEGG9kn3lA09u5/DBtjpgbdJ8MUJ52 8=; Received: from unknown (HELO fldsmtpi01.verizon.com) ([166.68.71.143]) by omzsmtpe03.verizonbusiness.com with ESMTP; 13 Dec 2017 02:01:04 +0000 Received: from rogue-10-255-192-101.rogue.vzwcorp.com (HELO atlantis.verizonwireless.com) ([10.255.192.101]) by fldsmtpi01.verizon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 13 Dec 2017 02:01:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1513130463; x=1544666463; h=from:cc:to:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=heb6R2cmPQc+YGUc/+76JrfPTAdHAoRZI990hDokSHs=; b=hCky0M5u7sXWMnRVh3xdo5FpCGw5wKCWvRz3SwXcRctQYPGpu/1N/UAe 2ghnCxDILZ5+KaCnGUcbtCfZriNV4ZClc8pa44HxuyFfHyZykfg6mhCmm LZXquqLsnILP0TY9+kdewuoU5UTIdb8Iu1Y05+k+PpQnGICnJ/Jgfj3OF Y=; Received: from mariner.tdc.vzwcorp.com (HELO eris.verizonwireless.com) ([10.254.88.84]) by atlantis.verizonwireless.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 12 Dec 2017 21:01:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1513130463; x=1544666463; h=to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:from:cc; bh=heb6R2cmPQc+YGUc/+76JrfPTAdHAoRZI990hDokSHs=; b=TBUGmkDjca+VwByxUtK08+C6KRTLv2X6QPZQA+lJ+pDUf39ruWnNNAeq YxJYQPdnI/cU1+Ki9s4Cptnor0snptJkaB/Tnhu90XlVD+R88Ii7nOWLg I460xkxCVwsJQnHpHl2nbpRcwSTAbX2+kvjmTNgB9QopDbaEloITDpKX3 A=; From: alexander.levin@verizon.com Cc: Arnd Bergmann , Guenter Roeck , alexander.levin@verizon.com X-Host: mariner.tdc.vzwcorp.com Received: from ohtwi1exh003.uswin.ad.vzwcorp.com ([10.144.218.45]) by eris.verizonwireless.com with ESMTP/TLS/AES128-SHA256; 13 Dec 2017 02:01:03 +0000 Received: from tbwexch15apd.uswin.ad.vzwcorp.com (153.114.162.39) by OHTWI1EXH003.uswin.ad.vzwcorp.com (10.144.218.45) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 12 Dec 2017 21:01:03 -0500 Received: from OMZP1LUMXCA13.uswin.ad.vzwcorp.com (144.8.22.188) by tbwexch15apd.uswin.ad.vzwcorp.com (153.114.162.39) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Tue, 12 Dec 2017 21:01:02 -0500 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com (144.8.22.195) by OMZP1LUMXCA13.uswin.ad.vzwcorp.com (144.8.22.188) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Tue, 12 Dec 2017 20:01:01 -0600 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) by OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) with mapi id 15.00.1263.000; Tue, 12 Dec 2017 20:01:01 -0600 To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: [PATCH AUTOSEL for 3.18 13/40] hwmon: (asus_atk0110) fix uninitialized data access Thread-Topic: [PATCH AUTOSEL for 3.18 13/40] hwmon: (asus_atk0110) fix uninitialized data access Thread-Index: AQHTc7X5naq9eIQP1kC1GWlHinjn4A== Date: Wed, 13 Dec 2017 01:59:14 +0000 Message-ID: <20171213015905.7059-13-alexander.levin@verizon.com> References: <20171213015905.7059-1-alexander.levin@verizon.com> In-Reply-To: <20171213015905.7059-1-alexander.levin@verizon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit a2125d02443e9a4e68bcfd9f8004fa23239e8329 ] The latest gcc-7 snapshot adds a warning to point out that when atk_read_value_old or atk_read_value_new fails, we copy uninitialized data into sensor->cached_value: drivers/hwmon/asus_atk0110.c: In function 'atk_input_show': drivers/hwmon/asus_atk0110.c:651:26: error: 'value' may be used uninitialized in this function [-Werror=maybe-uninitialized] Adding an error check avoids this. All versions of the driver are affected. Fixes: 2c03d07ad54d ("hwmon: Add Asus ATK0110 support") Signed-off-by: Arnd Bergmann Reviewed-by: Luca Tettamanti Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/asus_atk0110.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.11.0 diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c index cccef87963e0..975c43d446f8 100644 --- a/drivers/hwmon/asus_atk0110.c +++ b/drivers/hwmon/asus_atk0110.c @@ -646,6 +646,9 @@ static int atk_read_value(struct atk_sensor_data *sensor, u64 *value) else err = atk_read_value_new(sensor, value); + if (err) + return err; + sensor->is_valid = true; sensor->last_updated = jiffies; sensor->cached_value = *value;