[01/18] net/dpaa: fix coverity reported issues

Message ID 1513166759-13466-2-git-send-email-hemant.agrawal@nxp.com
State New
Headers show
Series
  • DPAA PMD improvements
Related show

Commit Message

Hemant Agrawal Dec. 13, 2017, 12:05 p.m.
Fixes: 05ba55bc2b1a ("net/dpaa: add packet dump for debugging")
Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup")
Cc: stable@dpdk.org

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

---
 drivers/net/dpaa/dpaa_ethdev.c | 6 +++---
 drivers/net/dpaa/dpaa_rxtx.c   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.7.4

Comments

Ferruh Yigit Jan. 9, 2018, 10:46 a.m. | #1
On 12/13/2017 12:05 PM, Hemant Agrawal wrote:
> Fixes: 05ba55bc2b1a ("net/dpaa: add packet dump for debugging")

> Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup")

> Cc: stable@dpdk.org>

> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>


Hi Hemant,

fix coverity issues is not very helpful as commit title, can you please document
what really fixed.

And there is a special format for coverity fixes:

"

    Coverity issue: ......
    Fixes: ............ ("...")
    Cc: stable@dpdk.org [if required]

    Signed-off-by: ....

"

There are samples in git history. It seems this format is not documented and
Marko will help to document it.
Hemant Agrawal Jan. 9, 2018, 1:29 p.m. | #2
On 1/9/2018 4:16 PM, Ferruh Yigit wrote:
> On 12/13/2017 12:05 PM, Hemant Agrawal wrote:

>> Fixes: 05ba55bc2b1a ("net/dpaa: add packet dump for debugging")

>> Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup")

>> Cc: stable@dpdk.org>

>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

>

> Hi Hemant,

>

> fix coverity issues is not very helpful as commit title, can you please document

> what really fixed.

>

> And there is a special format for coverity fixes:

>

> "

>

>     Coverity issue: ......

>     Fixes: ............ ("...")

>     Cc: stable@dpdk.org [if required]

>

>     Signed-off-by: ....

> "

>

> There are samples in git history. It seems this format is not documented and

> Marko will help to document it.

>

Hi Ferruh,
	thanks for the review. Please ignore v2, I will fix it in v3.

Regards,
Hemant

Patch

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index cf5a2ec..3023302 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -723,7 +723,7 @@  static int dpaa_fc_set_default(struct dpaa_if *dpaa_intf)
 static int dpaa_rx_queue_init(struct qman_fq *fq,
 			      uint32_t fqid)
 {
-	struct qm_mcc_initfq opts;
+	struct qm_mcc_initfq opts = {0};
 	int ret;
 
 	PMD_INIT_FUNC_TRACE();
@@ -769,7 +769,7 @@  static int dpaa_rx_queue_init(struct qman_fq *fq,
 static int dpaa_tx_queue_init(struct qman_fq *fq,
 			      struct fman_if *fman_intf)
 {
-	struct qm_mcc_initfq opts;
+	struct qm_mcc_initfq opts = {0};
 	int ret;
 
 	PMD_INIT_FUNC_TRACE();
@@ -800,7 +800,7 @@  static int dpaa_tx_queue_init(struct qman_fq *fq,
 /* Initialise a DEBUG FQ ([rt]x_error, rx_default). */
 static int dpaa_debug_queue_init(struct qman_fq *fq, uint32_t fqid)
 {
-	struct qm_mcc_initfq opts;
+	struct qm_mcc_initfq opts = {0};
 	int ret;
 
 	PMD_INIT_FUNC_TRACE();
diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c
index 41e57f2..771e141 100644
--- a/drivers/net/dpaa/dpaa_rxtx.c
+++ b/drivers/net/dpaa/dpaa_rxtx.c
@@ -665,7 +665,7 @@  tx_on_external_pool(struct qman_fq *txq, struct rte_mbuf *mbuf,
 		return 1;
 	}
 
-	DPAA_MBUF_TO_CONTIG_FD(mbuf, fd_arr, dpaa_intf->bp_info->bpid);
+	DPAA_MBUF_TO_CONTIG_FD(dmable_mbuf, fd_arr, dpaa_intf->bp_info->bpid);
 
 	return 0;
 }