[v2,7/8] db410c: configs: increase max kernel size

Message ID 1513258020-23589-8-git-send-email-jorge.ramirez-ortiz@linaro.org
State New
Headers show
Series
  • [v2,1/8] env: enable accessing the environment in an EXT4 partition
Related show

Commit Message

Jorge Ramirez Dec. 14, 2017, 1:26 p.m.
the kernel fails to boot when it goes over the limit.

Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
---
 include/configs/dragonboard410c.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Dec. 18, 2017, 7:31 p.m. | #1
On Thu, Dec 14, 2017 at 02:26:59PM +0100, Jorge Ramirez-Ortiz wrote:

> the kernel fails to boot when it goes over the limit.

> 

> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>

> ---

>  include/configs/dragonboard410c.h | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/include/configs/dragonboard410c.h b/include/configs/dragonboard410c.h

> index d2447b2..fdfac27 100644

> --- a/include/configs/dragonboard410c.h

> +++ b/include/configs/dragonboard410c.h

> @@ -23,7 +23,7 @@

>  #define CONFIG_SYS_TEXT_BASE		0x80080000

>  #define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x7fff0)

>  #define CONFIG_SYS_LOAD_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x80000)

> -#define CONFIG_SYS_BOOTM_LEN		0x1000000 /* 16MB max kernel size */

> +#define CONFIG_SYS_BOOTM_LEN		0x1400000 /* 20MB max kernel size */


This small of a size tweak is just begging to be hit within a year.  Can
we raise this to something closer to the aarch64 limit for an Image?  Or
if not, 32 or 64MB?

-- 
Tom
Jorge Ramirez Dec. 18, 2017, 8:09 p.m. | #2
On 12/18/2017 08:31 PM, Tom Rini wrote:
> On Thu, Dec 14, 2017 at 02:26:59PM +0100, Jorge Ramirez-Ortiz wrote:
>
>> the kernel fails to boot when it goes over the limit.
>>
>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>> ---
>>   include/configs/dragonboard410c.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/dragonboard410c.h b/include/configs/dragonboard410c.h
>> index d2447b2..fdfac27 100644
>> --- a/include/configs/dragonboard410c.h
>> +++ b/include/configs/dragonboard410c.h
>> @@ -23,7 +23,7 @@
>>   #define CONFIG_SYS_TEXT_BASE		0x80080000
>>   #define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x7fff0)
>>   #define CONFIG_SYS_LOAD_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x80000)
>> -#define CONFIG_SYS_BOOTM_LEN		0x1000000 /* 16MB max kernel size */
>> +#define CONFIG_SYS_BOOTM_LEN		0x1400000 /* 20MB max kernel size */
> This small of a size tweak is just begging to be hit within a year.  Can
> we raise this to something closer to the aarch64 limit for an Image?  Or
> if not, 32 or 64MB?

yeah I just picked 0x1400000 since that is what I used in poplar as well 
but sure, I'll set it to 64MB like rockchip and other platforms.


>

Patch

diff --git a/include/configs/dragonboard410c.h b/include/configs/dragonboard410c.h
index d2447b2..fdfac27 100644
--- a/include/configs/dragonboard410c.h
+++ b/include/configs/dragonboard410c.h
@@ -23,7 +23,7 @@ 
 #define CONFIG_SYS_TEXT_BASE		0x80080000
 #define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x7fff0)
 #define CONFIG_SYS_LOAD_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x80000)
-#define CONFIG_SYS_BOOTM_LEN		0x1000000 /* 16MB max kernel size */
+#define CONFIG_SYS_BOOTM_LEN		0x1400000 /* 20MB max kernel size */
 
 /* UART */