[RESEND,v2,13/15] dt-bindings: sound: qcom: Add devicetree bindings for apq8096

Message ID 20171214173402.19074-14-srinivas.kandagatla@linaro.org
State New
Headers show
Series
  • ASoC: qcom: Add support to QDSP6 based audio
Related show

Commit Message

Srinivas Kandagatla Dec. 14, 2017, 5:34 p.m.
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>


Add devicetree bindings documentation file for Qualcomm apq8096 sound card.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

---
 .../devicetree/bindings/sound/qcom,apq8096.txt     | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,apq8096.txt

-- 
2.15.0

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rob Herring Dec. 16, 2017, 5:44 p.m. | #1
On Thu, Dec 14, 2017 at 05:34:00PM +0000, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> 

> Add devicetree bindings documentation file for Qualcomm apq8096 sound card.

> 

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> ---

>  .../devicetree/bindings/sound/qcom,apq8096.txt     | 22 ++++++++++++++++++++++

>  1 file changed, 22 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/sound/qcom,apq8096.txt

> 

> diff --git a/Documentation/devicetree/bindings/sound/qcom,apq8096.txt b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt

> new file mode 100644

> index 000000000000..27b511dab533

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt

> @@ -0,0 +1,22 @@

> +* Qualcomm Technologies APQ8096 ASoC sound card driver

> +

> +This binding describes the APQ8096 sound card, which uses qdsp for audio.

> +

> +- compatible:

> +	Usage: required

> +	Value type: <stringlist>

> +	Definition: must be "qcom,apq8096-sndcard"

> +

> +- qcom,audio-routing:

> +	Usage: Optional

> +	Value type: <stringlist>

> +	Definition:  A list of the connections between audio components.

> +		  Each entry is a pair of strings, the first being the

> +		  connection's sink, the second being the connection's

> +		  source. Valid names could be power supplies, MicBias

> +		  of codec and the jacks on the board:

> +Example:

> +	sound {

> +		compatible	= "qcom,snd-apq8096";

> +		qcom,model = "DB820c";


Not documented, but just use "model".

This doesn't look complete. No codec, etc.?

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bjorn Andersson Jan. 3, 2018, 12:28 a.m. | #2
On Thu 14 Dec 09:34 PST 2017, srinivas.kandagatla@linaro.org wrote:

> +++ b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt


Wouldn't it be possible to describe all(?) qdsp based machines in this
one document? I.e. should we name it a little bit more generic?

> @@ -0,0 +1,22 @@

> +* Qualcomm Technologies APQ8096 ASoC sound card driver

> +

> +This binding describes the APQ8096 sound card, which uses qdsp for audio.

> +

> +- compatible:

> +	Usage: required

> +	Value type: <stringlist>

> +	Definition: must be "qcom,apq8096-sndcard"

> +

> +- qcom,audio-routing:

> +	Usage: Optional

> +	Value type: <stringlist>

> +	Definition:  A list of the connections between audio components.


Double space before A

> +		  Each entry is a pair of strings, the first being the

> +		  connection's sink, the second being the connection's

> +		  source. Valid names could be power supplies, MicBias

> +		  of codec and the jacks on the board:

> +Example:

> +	sound {

> +		compatible	= "qcom,snd-apq8096";


Indentation

> +		qcom,model = "DB820c";

> +	};


Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/devicetree/bindings/sound/qcom,apq8096.txt b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt
new file mode 100644
index 000000000000..27b511dab533
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt
@@ -0,0 +1,22 @@ 
+* Qualcomm Technologies APQ8096 ASoC sound card driver
+
+This binding describes the APQ8096 sound card, which uses qdsp for audio.
+
+- compatible:
+	Usage: required
+	Value type: <stringlist>
+	Definition: must be "qcom,apq8096-sndcard"
+
+- qcom,audio-routing:
+	Usage: Optional
+	Value type: <stringlist>
+	Definition:  A list of the connections between audio components.
+		  Each entry is a pair of strings, the first being the
+		  connection's sink, the second being the connection's
+		  source. Valid names could be power supplies, MicBias
+		  of codec and the jacks on the board:
+Example:
+	sound {
+		compatible	= "qcom,snd-apq8096";
+		qcom,model = "DB820c";
+	};