[05/11] cmd: misc: Disable by default on sunXi

Message ID 20171221124030.23721-6-maxime.ripard@free-electrons.com
State Superseded
Headers show
Series
  • sunxi: arm64 binary size fixes
Related show

Commit Message

Maxime Ripard Dec. 21, 2017, 12:40 p.m.
The sunXi arm64 build has overflown, leading to the main U-boot binary
overwriting the environment when flashing the new image, or even worse,
overwriting itself when we're calling saveenv.

Disable this command that is not critical until we can adress the issue
properly.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

André Przywara Dec. 21, 2017, 2:50 p.m. | #1
Hi,

On 21/12/17 12:40, Maxime Ripard wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
> 
> Disable this command that is not critical until we can adress the issue
> properly.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Are there any scripts relying on "sleep"? For some kind of fabricated
timeout, maybe? But I guess users would enable them in that case, so:

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre.

> ---
>  cmd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 098fbe6fc90a..ca6d3956bd10 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1130,6 +1130,7 @@ config CMD_GETTIME
>  # TODO: rename to CMD_SLEEP
>  config CMD_MISC
>  	bool "sleep"
> +	default n if ARCH_SUNXI
>  	default y
>  	help
>  	  Delay execution for some time
>
Jagan Teki Jan. 10, 2018, 6:22 a.m. | #2
On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
>
> Disable this command that is not critical until we can adress the issue
> properly.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---

Applied to u-boot-sunxi/master

Patch

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 098fbe6fc90a..ca6d3956bd10 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1130,6 +1130,7 @@  config CMD_GETTIME
 # TODO: rename to CMD_SLEEP
 config CMD_MISC
 	bool "sleep"
+	default n if ARCH_SUNXI
 	default y
 	help
 	  Delay execution for some time