[06/11] video: bpp8: Disable by default on sunXi

Message ID 20171221124030.23721-7-maxime.ripard@free-electrons.com
State Superseded
Headers show
Series
  • sunxi: arm64 binary size fixes
Related show

Commit Message

Maxime Ripard Dec. 21, 2017, 12:40 p.m.
The sunXi arm64 build has overflown, leading to the main U-boot binary
overwriting the environment when flashing the new image, or even worse,
overwriting itself when we're calling saveenv.

Disable this command that is not critical until we can adress the issue
properly.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 drivers/video/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

André Przywara Dec. 21, 2017, 2:37 p.m. | #1
Hi,

On 21/12/17 12:40, Maxime Ripard wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
> 
> Disable this command that is not critical until we can adress the issue
> properly.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Actually that is useful for sunxi in any case, since we hardcode
VIDEO_BPP32 in sunxi_de2.c.

Cheers,
Andre.

> ---
>  drivers/video/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 45a105db06ae..a267c9acfecb 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -38,6 +38,7 @@ config BACKLIGHT_GPIO
>  config VIDEO_BPP8
>  	bool "Support 8-bit-per-pixel displays"
>  	depends on DM_VIDEO
> +	default n if ARCH_SUNXI
>  	default y if DM_VIDEO
>  	help
>  	  Support drawing text and bitmaps onto a 8-bit-per-pixel display.


>
Anatolij Gustschin Dec. 21, 2017, 4:01 p.m. | #2
On Thu, 21 Dec 2017 13:40:25 +0100
Maxime Ripard maxime.ripard@free-electrons.com wrote:

> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
> 
> Disable this command that is not critical until we can adress the issue
> properly.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Reviewed-by: Anatolij Gustschin <agust@denx.de>
Jagan Teki Jan. 10, 2018, 6:23 a.m. | #3
On Thu, Dec 21, 2017 at 9:31 PM, Anatolij Gustschin <agust@denx.de> wrote:
> On Thu, 21 Dec 2017 13:40:25 +0100
> Maxime Ripard maxime.ripard@free-electrons.com wrote:
>
>> The sunXi arm64 build has overflown, leading to the main U-boot binary
>> overwriting the environment when flashing the new image, or even worse,
>> overwriting itself when we're calling saveenv.
>>
>> Disable this command that is not critical until we can adress the issue
>> properly.
>>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Reviewed-by: Anatolij Gustschin <agust@denx.de>

Applied to u-boot-sunxi/master

Patch

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 45a105db06ae..a267c9acfecb 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -38,6 +38,7 @@  config BACKLIGHT_GPIO
 config VIDEO_BPP8
 	bool "Support 8-bit-per-pixel displays"
 	depends on DM_VIDEO
+	default n if ARCH_SUNXI
 	default y if DM_VIDEO
 	help
 	  Support drawing text and bitmaps onto a 8-bit-per-pixel display.