From patchwork Wed Dec 27 15:41:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 122802 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2329298qgn; Wed, 27 Dec 2017 07:41:53 -0800 (PST) X-Google-Smtp-Source: ACJfBotWx9jbHZcIp0E2UQpNjiv/QElgWwrDMpY7SwhcaqjsaMRsEMz7I9/x15GsN+SgjT6Ff3Wv X-Received: by 10.99.62.133 with SMTP id l127mr25241408pga.376.1514389313706; Wed, 27 Dec 2017 07:41:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1514389313; cv=none; d=google.com; s=arc-20160816; b=QXqHECn76FRKF2TAi4z7Rw0vZ499eUawYjamj7gjEeS8C4IDugu4egT00QJFPiGSq9 X8kd1eQh8ZoKBgUAvUqJvsFEuomsyl/os4r2D8Iv/PdOZRyMhFH77Rbh3VS6Y2DvsSDP 3EEQvW5qK4cYIx/MYTOF3HDnPgjYiboZCejf+T5tfYGUwufhc6L5nHzcQcGrCULirurt LI0zdWqkHsh2f2+V1HjDMesgtP6vHl31THsJ7SM6euBIkeCi5G7Bo8FZ68XQlsZ5JWim RVuZG9OX6aylkQfNZlqXhkThnfB+VRFA26lTdinXnq3idARrRXYVTDFRkBpLXWRowYs2 SDDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=sj1XqsudO/nC/dQfV3czNWGZ3WuMN5dlKq9K+qnX7qQ=; b=WbW2YWIcmoVRoDegWPIDZlgNzvo75ZVbNMVweRRjMdFEAwWdqkjv0Mxvy6dJelSWLV MhjmZMRsOBi63nZOmJGub0WAs2rnyxzR+dCnIj31rUwCK8solco89X+uGrbcLhU7AO9s PooOcK60vZYwL4I+x89mdbNB2CAq6dOgb14sF3hJrgdrJ0u8Ebm+8rm/+sJgSLILAmzB 5VqPi2U5A9YWzPsOk5sNeZZNfryVuDJ/mm4Hz9dSYzstH5uTFZavJEw7XM197uL0ojct SA2PRoGIbUKWGShLp5Do6MbH4jQw8POgWUzVHDKgXEb3sE8Iih0wPoDDTst/7CMK0C+0 YGtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qjAB502d; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g9si25106619plk.420.2017.12.27.07.41.53; Wed, 27 Dec 2017 07:41:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qjAB502d; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751781AbdL0Plw (ORCPT + 10 others); Wed, 27 Dec 2017 10:41:52 -0500 Received: from mail-pl0-f65.google.com ([209.85.160.65]:46802 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbdL0Plv (ORCPT ); Wed, 27 Dec 2017 10:41:51 -0500 Received: by mail-pl0-f65.google.com with SMTP id i6so19596350plt.13 for ; Wed, 27 Dec 2017 07:41:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=sj1XqsudO/nC/dQfV3czNWGZ3WuMN5dlKq9K+qnX7qQ=; b=qjAB502dOpevnD/Z6/CCNp3pWrfU5girWa9/I1iW1ziYTYJLtXQbyjp/FUVbipHMo8 L7Dv/okarw6+g7Zs+LntyLd4+Zr82pRkDDqlSZFI7x2Owbd99c9dkjr84Lddq2p/Ys1c OCHEahkPlNlQ6bHcgDMsSpicEuezxgoDodTtr/XuWJV8X/PMcJdRBwWXoV3dK/eA/soU hKw9qzXRNcDnj8Mrh/BCbXwDtTs+tM7akXS1BCewaeJuThNRMvSCX7Yc6QU2oOXb8DSm 1X7ppO6SIN5Otc53mJpmFOVdXohlhoMkmCzscnCuTzIGbIMyzq2spYRN+0oJ3/h5yIF0 twHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=sj1XqsudO/nC/dQfV3czNWGZ3WuMN5dlKq9K+qnX7qQ=; b=TiHwLC6ksX38+AG4HUngH094QbXScF8MreTlSbi8uXj85eOmpMJeZUDo39j2EwkSQj jzZE6ydyIgRyhvcAsmnF9xidwB0H/6TJhVNpC1KP5xBObVmzalw3mdxtHbL/AfCDGfEf mVU50hYTOw/SSdBcU7A5kY03Xg/S9bixrizWyFWDpw6SDhMurzWQsNczLOt+2L3/etfF n5T8L38gHaKJi3ZdfU8H/4tWKkZNcdY4m+YH9lYW5UEJ5LwZ7l/VQWDIQwyF8eBxkyOL vcR/yobdZrFRDzt5cTDe1D1VP/kG1lqU3de9ZktCZnilirPMmoabOgKNvnGymay+/kVA IJ6Q== X-Gm-Message-State: AKGB3mIw/LWYO7j/JRsBz2+9nBmI5ZJ3pq01Z96MyE2p3h2XDFOQmbPC XTXvqW0ZZshwyuhvr77/XMV3EZg= X-Received: by 10.84.248.68 with SMTP id e4mr28652331pln.0.1514389311142; Wed, 27 Dec 2017 07:41:51 -0800 (PST) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id r13sm69458813pfl.157.2017.12.27.07.41.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Dec 2017 07:41:50 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 57B7D3AE; Wed, 27 Dec 2017 09:41:48 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 671A8300081; Wed, 27 Dec 2017 09:41:47 -0600 (CST) From: minyard@acm.org To: stable@vger.kernel.org Cc: Corey Minyard , Sasha Levin Subject: [PATCH] Revert "ipmi_si: fix memory leak on new_smi" Date: Wed, 27 Dec 2017 09:41:44 -0600 Message-Id: <1514389304-27870-1-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Corey Minyard This reverts commit c97e41076a298dbc4e910c33048e553658388eed. A backport was requested of c0a32fe13cd32 "ipmi_si: fix memory leak on new_smi", but the backport shouldn't have been done. This change needs to be reverted, as it can result in an oops and the previous code is correct. Reverts: c97e41076a29 ("ipmi_si: fix memory leak on new_smi") Link: https://bbs.archlinux.org/viewtopic.php?pid=1757130#p1757130 Reported-by: Neil Romig Cc: Sasha Levin Signed-off-by: Corey Minyard --- This is for 4.14 stable tree only. In hindsight, I should scrutinize stable kernel requests from others in the IPMI tree. Sorry about that. drivers/char/ipmi/ipmi_si_intf.c | 1 - 1 file changed, 1 deletion(-) -- 2.7.4 diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index e1cbb78..c04aa11 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -3469,7 +3469,6 @@ static int add_smi(struct smi_info *new_smi) ipmi_addr_src_to_str(new_smi->addr_source), si_to_str[new_smi->si_type]); rv = -EBUSY; - kfree(new_smi); goto out_err; } }