From patchwork Tue Jan 2 18:10:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 123194 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp9253334qgn; Tue, 2 Jan 2018 10:11:05 -0800 (PST) X-Google-Smtp-Source: ACJfBovk0xk1VIQseTJOXRWoPTP79UGTMwUqplrU/hXP1OUMa5OXKalpqyxuFojcxGeJq6f5SJyw X-Received: by 10.159.198.1 with SMTP id f1mr45852397plo.450.1514916665203; Tue, 02 Jan 2018 10:11:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1514916665; cv=none; d=google.com; s=arc-20160816; b=Qiyl2zuy+eNFrmiWkJ7KSW2ueuhAlJISFfHr0VCr8+hUfkSJdg+TTryAYDi6VIv7kU fsRgAfF2KdI6Ht7hH8uLzh4Jl65aRpss2LvNm52fkzcXi32VEIuI7hNPI++COh71em8I yKWoTam629G4GW2rA+gnrM+SH5Iukjbxq1hoZsTSqQW0OUzkHS8mkcuWzEZtV+3kdCid hiC3eEbx7sVnPe5qwFeW67A+AY8dlvBsPsL5DVZlOGk59uMtCjA93eahLDpWUVf1FL9f p1oIlNfhu9gYHQmk0XQ4/Brty9ButeD/zWAKa6G+BN9Q+MJXfbv6mS2FxroOUgolL/BX KcZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=LOS6qPCDYXjb+pJilC4l2A23cDqTHpdBBU2ggoiGoFE=; b=NaagIbiisHJukZ7gKWRyGhv/FqmKPZlo6dJerwd3nFyqIVmQsA3AXq/hVmwLxyltw0 pCtT3UtW9kr2EUFNkie8AywK7WGs86r8qUQInqk5kxHgB/i/J0QardigMgWKRy7vjpjF s8f9YEoRP9+Gt33xjyoXrCFmy3Je6Nyp3UM1QxS5V8iwD6EJlAGeqoHEOijXExNpMPab YDgraAFVWoXX6bsrHpVeMyV6yvjYWlRd+gXKhQZDZSqYLY4eotrAS6vm/tevVjYycFwB VLiQPjOJemCajENDwJYNtJo2O5dAF850GN+1ntTIo4WzEs4dbVLrQ6fEycav6xbCm7G4 C3aA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Yw6PgYoN; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si33959766ply.166.2018.01.02.10.11.04; Tue, 02 Jan 2018 10:11:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Yw6PgYoN; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751034AbeABSLE (ORCPT + 2 others); Tue, 2 Jan 2018 13:11:04 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:46568 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbeABSLC (ORCPT ); Tue, 2 Jan 2018 13:11:02 -0500 Received: by mail-wm0-f67.google.com with SMTP id r78so62839260wme.5 for ; Tue, 02 Jan 2018 10:11:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xp1elusisRVDeN7DQpjK1u4KD5rJ0GDj8DU23g21t0g=; b=Yw6PgYoNXb/sW0TJYEZDsituZfwDysJQhSA2TJjm0Q/vYFDZ9abUVqD7c/J3ilt9w/ wVxFefzdfiidegSVprWE5piKfEPF2d5CDIuQDo3Usl7Yp+oUDnOTNQ7sFn4H+bo0MXzv 8aluzSfCfQsJFGo/H2A3DT+OUtQ9V4P/b280U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xp1elusisRVDeN7DQpjK1u4KD5rJ0GDj8DU23g21t0g=; b=IIXt9ZbK8ENXwI+JDTYqvfljAIwJo5TrMmDTn1tS+KV8MJ9Abtu52FFw2sOHdKoSoE ZkPlC8hXEZ2mm3h8aFLntxQJ/DxzJRnMv4vVJt4LLYJC2tEjuVRNWbfaZAo+NKVcapyr 7qUeNX8e2qlJMcLQO2zjQ4Af8wm/mFqoxk0IsjokmnzGGJHHx32CoYtvgh2gAOupTUve gNI4NC/g114+DRCpRk2IqHIp5l+l9dO/yJNVZz1An9BLbJs5WyRkdT4OS785/27GrLDr DKHERc3rYCFnphZ20+dRfVIf+swxNc1hksDm/wL99MMgBIp0gbzyd7rvf1eh1WrJH/mr Xqvw== X-Gm-Message-State: AKGB3mKXV4mRfGt8yRiaYucOAy5dM+XzFQvEP4lUcU0KZ7d/We65neR2 MKpllFpQeauoGa3bpsp/U9j06u6j0ws= X-Received: by 10.28.152.74 with SMTP id a71mr33686597wme.22.1514916661351; Tue, 02 Jan 2018 10:11:01 -0800 (PST) Received: from localhost.localdomain ([160.89.138.198]) by smtp.gmail.com with ESMTPSA id f5sm16496643wrh.24.2018.01.02.10.10.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Jan 2018 10:11:00 -0800 (PST) From: Ard Biesheuvel To: linux-efi@vger.kernel.org, Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" Cc: Ard Biesheuvel , linux-kernel@vger.kernel.org, Arvind Yadav , Matt Fleming , Stephen Boyd , Tyler Baicar , Vasyl Gomonovych Subject: [PATCH 1/5] efi/capsule-loader: pr_err() strings should end with newlines Date: Tue, 2 Jan 2018 18:10:38 +0000 Message-Id: <20180102181042.19074-2-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180102181042.19074-1-ard.biesheuvel@linaro.org> References: <20180102181042.19074-1-ard.biesheuvel@linaro.org> Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org From: Arvind Yadav pr_err() messages should terminated with a new-line to avoid other messages being concatenated onto the end. Signed-off-by: Arvind Yadav Signed-off-by: Matt Fleming Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/capsule-loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/firmware/efi/capsule-loader.c b/drivers/firmware/efi/capsule-loader.c index ec8ac5c4dd84..51d2874942a2 100644 --- a/drivers/firmware/efi/capsule-loader.c +++ b/drivers/firmware/efi/capsule-loader.c @@ -49,7 +49,7 @@ int __efi_capsule_setup_info(struct capsule_info *cap_info) pages_needed = ALIGN(cap_info->total_size, PAGE_SIZE) / PAGE_SIZE; if (pages_needed == 0) { - pr_err("invalid capsule size"); + pr_err("invalid capsule size\n"); return -EINVAL; }