[v2] libfdt: remove unnecessary include directive from <linux/libfdt.h>

Message ID 1515294136-19427-1-git-send-email-yamada.masahiro@socionext.com
State New
Headers show
Series
  • [v2] libfdt: remove unnecessary include directive from <linux/libfdt.h>
Related show

Commit Message

Masahiro Yamada Jan. 7, 2018, 3:02 a.m.
<linux/libfdt.h> is a wrapper of scripts/dtc/libfdt/libfdt.h
It should not do more than its job.  In fact, libfdt.h depends
on fdt.h, and scripts/dtc/libfdt/libfdt.h includes fdt.h already.
Trust the work in the upstream DTC project.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

Changes in v2:
  - Rephrase commit-log a bit (remove ../../)

 include/linux/libfdt.h | 1 -
 1 file changed, 1 deletion(-)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rob Herring Jan. 11, 2018, 8:39 p.m. | #1
On Sun, Jan 07, 2018 at 12:02:16PM +0900, Masahiro Yamada wrote:
> <linux/libfdt.h> is a wrapper of scripts/dtc/libfdt/libfdt.h

> It should not do more than its job.  In fact, libfdt.h depends

> on fdt.h, and scripts/dtc/libfdt/libfdt.h includes fdt.h already.

> Trust the work in the upstream DTC project.

> 

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> ---

> 

> Changes in v2:

>   - Rephrase commit-log a bit (remove ../../)

> 

>  include/linux/libfdt.h | 1 -

>  1 file changed, 1 deletion(-)


Applied, thanks.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/linux/libfdt.h b/include/linux/libfdt.h
index 27ba06e..90ed4eb 100644
--- a/include/linux/libfdt.h
+++ b/include/linux/libfdt.h
@@ -3,7 +3,6 @@ 
 #define _INCLUDE_LIBFDT_H_
 
 #include <linux/libfdt_env.h>
-#include "../../scripts/dtc/libfdt/fdt.h"
 #include "../../scripts/dtc/libfdt/libfdt.h"
 
 #endif /* _INCLUDE_LIBFDT_H_ */