perf: depend on native versions of bison and flex

Message ID 1515560940-118797-1-git-send-email-denis@denix.org
State New
Headers show
Series
  • perf: depend on native versions of bison and flex
Related show

Commit Message

Denys Dmytriyenko Jan. 10, 2018, 5:09 a.m.
From: Denys Dmytriyenko <denys@ti.com>


Explicitly depend on bison-native and flex-native for deterministic builds,
as those are required for the build:

| Makefile.config:129: *** Error: flex is missing on this system, please install it.  Stop.
| Makefile.perf:205: recipe for target 'sub-make' failed
| make[1]: *** [sub-make] Error 2
| Makefile:68: recipe for target 'all' failed
| make: *** [all] Error 2

| Makefile.config:133: *** Error: bison is missing on this system, please install it.  Stop.
| Makefile.perf:205: recipe for target 'sub-make' failed
| make[1]: *** [sub-make] Error 2
| Makefile:68: recipe for target 'all' failed
| make: *** [all] Error 2

In most cases, those dependencies come indirectly via toolchain dependencies,
specifically binutils-cross, which pulls both bison-native and flex-native.
Different setups, such as with external toolchain, would expose this problem,
since correct dependency is not marked explicitly.

The change is build-tested on all qemu architectures.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>

---
 meta/recipes-kernel/perf/perf.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index b79b973..bb943ec 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -26,7 +26,7 @@  DEPENDS = " \
     virtual/${MLPREFIX}libc \
     ${MLPREFIX}elfutils \
     ${MLPREFIX}binutils \
-    bison flex xz \
+    bison-native flex-native xz \
     xmlto-native \
     asciidoc-native \
 "