| Message ID | 1515567374-12722-5-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/6] kconfig: do not call check_conf() for olddefconfig | expand |
On Wed, Jan 10, 2018 at 7:56 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > check_conf() never increments conf_cnt for listnewconfig, so conf_cnt > is always zero. > > In other words, conf_cnt is not zero, "input_mode != listnewconfig" > is met. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > scripts/kconfig/conf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c > index 693cd5f..1d2ed3e 100644 > --- a/scripts/kconfig/conf.c > +++ b/scripts/kconfig/conf.c > @@ -669,7 +669,7 @@ int main(int ac, char **av) > do { > conf_cnt = 0; > check_conf(&rootmenu); > - } while (conf_cnt && input_mode != listnewconfig); > + } while (conf_cnt); > break; > case alldefconfig: > case defconfig: > -- > 2.7.4 > Acked-by: Ulf Magnusson <ulfalizer@gmail.com> Cheers, Ulf
diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c index 693cd5f..1d2ed3e 100644 --- a/scripts/kconfig/conf.c +++ b/scripts/kconfig/conf.c @@ -669,7 +669,7 @@ int main(int ac, char **av) do { conf_cnt = 0; check_conf(&rootmenu); - } while (conf_cnt && input_mode != listnewconfig); + } while (conf_cnt); break; case alldefconfig: case defconfig:
check_conf() never increments conf_cnt for listnewconfig, so conf_cnt is always zero. In other words, conf_cnt is not zero, "input_mode != listnewconfig" is met. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- scripts/kconfig/conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4