[RFC] gcc: add flex-native explicit dependency

Message ID 1515569943-89393-1-git-send-email-denis@denix.org
State New
Headers show
Series
  • [RFC] gcc: add flex-native explicit dependency
Related show

Commit Message

Denys Dmytriyenko Jan. 10, 2018, 7:39 a.m.
From: Denys Dmytriyenko <denys@ti.com>


It seems flex is required to build gcc:

| .../work-shared/gcc-7.2.0-r0/gcc-7.2.0/missing: line 81: flex: command not found
| WARNING: 'flex' is missing on your system.
|          You should only need it if you modified a '.l' file.
|          You may want to install the Fast Lexical Analyzer package:
|          <http://flex.sourceforge.net/>
| Makefile:2799: recipe for target 'gengtype-lex.c' failed
| make[1]: [gengtype-lex.c] Error 127 (ignored)

Normally this is handled indirectly throught binutils-cross dependency
pulling in flex-native implicitly. For deterministic builds, this should
be specified explicitly.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>

---
RFC: Not sure if versioned .inc is the best place to spefice DEPENDS on flex-native

 meta/recipes-devtools/gcc/gcc-6.3.inc | 2 +-
 meta/recipes-devtools/gcc/gcc-7.2.inc | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.7.4

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Denys Dmytriyenko Jan. 10, 2018, 8:14 p.m. | #1
Oh, this is against rocko, which should be fine for RFC, but I'll rebase for 
master soon...


On Wed, Jan 10, 2018 at 02:39:03AM -0500, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko <denys@ti.com>

> 

> It seems flex is required to build gcc:

> 

> | .../work-shared/gcc-7.2.0-r0/gcc-7.2.0/missing: line 81: flex: command not found

> | WARNING: 'flex' is missing on your system.

> |          You should only need it if you modified a '.l' file.

> |          You may want to install the Fast Lexical Analyzer package:

> |          <http://flex.sourceforge.net/>

> | Makefile:2799: recipe for target 'gengtype-lex.c' failed

> | make[1]: [gengtype-lex.c] Error 127 (ignored)

> 

> Normally this is handled indirectly throught binutils-cross dependency

> pulling in flex-native implicitly. For deterministic builds, this should

> be specified explicitly.

> 

> Signed-off-by: Denys Dmytriyenko <denys@ti.com>

> ---

> RFC: Not sure if versioned .inc is the best place to spefice DEPENDS on flex-native

> 

>  meta/recipes-devtools/gcc/gcc-6.3.inc | 2 +-

>  meta/recipes-devtools/gcc/gcc-7.2.inc | 2 +-

>  2 files changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/meta/recipes-devtools/gcc/gcc-6.3.inc b/meta/recipes-devtools/gcc/gcc-6.3.inc

> index e569e02..39aca13 100644

> --- a/meta/recipes-devtools/gcc/gcc-6.3.inc

> +++ b/meta/recipes-devtools/gcc/gcc-6.3.inc

> @@ -10,7 +10,7 @@ BINV = "6.3.0"

>  

>  FILESEXTRAPATHS =. "${FILE_DIRNAME}/gcc-6.3:${FILE_DIRNAME}/gcc-6.3/backport:"

>  

> -DEPENDS =+ "mpfr gmp libmpc zlib"

> +DEPENDS =+ "mpfr gmp libmpc zlib flex-native"

>  NATIVEDEPS = "mpfr-native gmp-native libmpc-native zlib-native"

>  

>  LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"

> diff --git a/meta/recipes-devtools/gcc/gcc-7.2.inc b/meta/recipes-devtools/gcc/gcc-7.2.inc

> index 1d40cba..d1fb6de 100644

> --- a/meta/recipes-devtools/gcc/gcc-7.2.inc

> +++ b/meta/recipes-devtools/gcc/gcc-7.2.inc

> @@ -10,7 +10,7 @@ BINV = "7.2.0"

>  

>  FILESEXTRAPATHS =. "${FILE_DIRNAME}/gcc-7.2:${FILE_DIRNAME}/gcc-7.2/backport:"

>  

> -DEPENDS =+ "mpfr gmp libmpc zlib"

> +DEPENDS =+ "mpfr gmp libmpc zlib flex-native"

>  NATIVEDEPS = "mpfr-native gmp-native libmpc-native zlib-native"

>  

>  LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"

> -- 

> 2.7.4

> 

> -- 

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-devtools/gcc/gcc-6.3.inc b/meta/recipes-devtools/gcc/gcc-6.3.inc
index e569e02..39aca13 100644
--- a/meta/recipes-devtools/gcc/gcc-6.3.inc
+++ b/meta/recipes-devtools/gcc/gcc-6.3.inc
@@ -10,7 +10,7 @@  BINV = "6.3.0"
 
 FILESEXTRAPATHS =. "${FILE_DIRNAME}/gcc-6.3:${FILE_DIRNAME}/gcc-6.3/backport:"
 
-DEPENDS =+ "mpfr gmp libmpc zlib"
+DEPENDS =+ "mpfr gmp libmpc zlib flex-native"
 NATIVEDEPS = "mpfr-native gmp-native libmpc-native zlib-native"
 
 LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
diff --git a/meta/recipes-devtools/gcc/gcc-7.2.inc b/meta/recipes-devtools/gcc/gcc-7.2.inc
index 1d40cba..d1fb6de 100644
--- a/meta/recipes-devtools/gcc/gcc-7.2.inc
+++ b/meta/recipes-devtools/gcc/gcc-7.2.inc
@@ -10,7 +10,7 @@  BINV = "7.2.0"
 
 FILESEXTRAPATHS =. "${FILE_DIRNAME}/gcc-7.2:${FILE_DIRNAME}/gcc-7.2/backport:"
 
-DEPENDS =+ "mpfr gmp libmpc zlib"
+DEPENDS =+ "mpfr gmp libmpc zlib flex-native"
 NATIVEDEPS = "mpfr-native gmp-native libmpc-native zlib-native"
 
 LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"