[oe,meta-qt5,rocko] qtwebengine: explicitly depend on bison-native

Message ID 1515635126-19293-1-git-send-email-denis@denix.org
State New
Headers show
Series
  • [oe,meta-qt5,rocko] qtwebengine: explicitly depend on bison-native
Related show

Commit Message

Denys Dmytriyenko Jan. 11, 2018, 1:45 a.m.
From: Denys Dmytriyenko <denys@ti.com>


QtWebEngine uses bison during the build. While normally bison-native gets
staged into sysroot indirectly by the toolchain via binutils-cross, it's
better to have the dependency listed explicitly for deterministic builds.
Otherwise, when using an external toolchain, it fails like this:

| FAILED: gen/blink/core/XPathGrammar.cpp gen/blink/core/XPathGrammar.h
| .../qtwebengine/5.9.3+...-r0/recipe-sysroot-native/usr/bin/python-native/python2
|    ../../../../git/src/3rdparty/chromium/third_party/WebKit/Source/build/scripts/rule_bison.py
|    ../../../../git/src/3rdparty/chromium/third_party/WebKit/Source/core/xml/XPathGrammar.y gen/blink/core bison
| Traceback (most recent call last):
|   File "../../../../git/src/3rdparty/chromium/third_party/WebKit/Source/build/scripts/rule_bison.py", line 83, in <module>
|     returnCode = subprocess.call([bisonExe, '-d', '-p', prefix, inputFile, '-o', outputCpp])
|   File ".../qtwebengine/5.9.3+...-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py", line 168, in call
|     return Popen(*popenargs, **kwargs).wait()
|   File ".../qtwebengine/5.9.3+...-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py", line 390, in __init__
|     errread, errwrite)
|   File ".../qtwebengine/5.9.3+...-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py", line 1024, in _execute_child
|     raise child_exception
| OSError: [Errno 2] No such file or directory

Signed-off-by: Denys Dmytriyenko <denys@ti.com>

---
 recipes-qt/qt5/qtwebengine_git.bb | 1 +
 1 file changed, 1 insertion(+)

-- 
2.7.4

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Martin Jansa Jan. 15, 2018, 6 p.m. | #1
Using the same e-mail thread for both patches for master and rocko, caused
the one for master being automatically marked as superseded by the rocko
one, see:
https://patchwork.openembedded.org/patch/147192/

This is a system generated Comment: Patch 147192 was automatically
marked as superseded by patch 147193.

I don't know if there is something we can change in patchwork to be
less stupid (other than replacing it with something more clever like
gerrit). This time I've noticed that there was patch for master as
well in the e-mail client, but looking just on patchwork I wouldn't
have noticed at all, not sure how many other patches are lost like
this.


On Thu, Jan 11, 2018 at 2:45 AM, Denys Dmytriyenko <denis@denix.org> wrote:

> From: Denys Dmytriyenko <denys@ti.com>

>

> QtWebEngine uses bison during the build. While normally bison-native gets

> staged into sysroot indirectly by the toolchain via binutils-cross, it's

> better to have the dependency listed explicitly for deterministic builds.

> Otherwise, when using an external toolchain, it fails like this:

>

> | FAILED: gen/blink/core/XPathGrammar.cpp gen/blink/core/XPathGrammar.h

> | .../qtwebengine/5.9.3+...-r0/recipe-sysroot-native/usr/bin/

> python-native/python2

> |    ../../../../git/src/3rdparty/chromium/third_party/WebKit/

> Source/build/scripts/rule_bison.py

> |    ../../../../git/src/3rdparty/chromium/third_party/WebKit/Source/core/xml/XPathGrammar.y

> gen/blink/core bison

> | Traceback (most recent call last):

> |   File "../../../../git/src/3rdparty/chromium/third_party/WebKit/

> Source/build/scripts/rule_bison.py", line 83, in <module>

> |     returnCode = subprocess.call([bisonExe, '-d', '-p', prefix,

> inputFile, '-o', outputCpp])

> |   File ".../qtwebengine/5.9.3+...-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py",

> line 168, in call

> |     return Popen(*popenargs, **kwargs).wait()

> |   File ".../qtwebengine/5.9.3+...-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py",

> line 390, in __init__

> |     errread, errwrite)

> |   File ".../qtwebengine/5.9.3+...-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py",

> line 1024, in _execute_child

> |     raise child_exception

> | OSError: [Errno 2] No such file or directory

>

> Signed-off-by: Denys Dmytriyenko <denys@ti.com>

> ---

>  recipes-qt/qt5/qtwebengine_git.bb | 1 +

>  1 file changed, 1 insertion(+)

>

> diff --git a/recipes-qt/qt5/qtwebengine_git.bb b/recipes-qt/qt5/

> qtwebengine_git.bb

> index 1f53e4a..ed179de 100644

> --- a/recipes-qt/qt5/qtwebengine_git.bb

> +++ b/recipes-qt/qt5/qtwebengine_git.bb

> @@ -15,6 +15,7 @@ LIC_FILES_CHKSUM = " \

>  DEPENDS += " \

>      ninja-native \

>      yasm-native \

> +    bison-native \

>      qtwebchannel \

>      qtbase qtdeclarative qtxmlpatterns qtquickcontrols qtquickcontrols2 \

>      qtlocation \

> --

> 2.7.4

>

> --

> _______________________________________________

> Openembedded-devel mailing list

> Openembedded-devel@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

>

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Denys Dmytriyenko Jan. 15, 2018, 6:12 p.m. | #2
On Mon, Jan 15, 2018 at 07:00:09PM +0100, Martin Jansa wrote:
> Using the same e-mail thread for both patches for master and rocko, caused


Actually, both patches were sent completely separate and independent of each 
other. They were not in a single thread - i.e. none of them had In-Reply-To: 
and References: fields set for threading. So Patchwork must have done all the 
guessing entirely by the contents...


> the one for master being automatically marked as superseded by the rocko

> one, see:

> https://patchwork.openembedded.org/patch/147192/

> 

> This is a system generated Comment: Patch 147192 was automatically

> marked as superseded by patch 147193.

> 

> I don't know if there is something we can change in patchwork to be

> less stupid (other than replacing it with something more clever like

> gerrit). This time I've noticed that there was patch for master as

> well in the e-mail client, but looking just on patchwork I wouldn't

> have noticed at all, not sure how many other patches are lost like

> this.

> 

> 

> On Thu, Jan 11, 2018 at 2:45 AM, Denys Dmytriyenko <denis@denix.org> wrote:

> 

> > From: Denys Dmytriyenko <denys@ti.com>

> >

> > QtWebEngine uses bison during the build. While normally bison-native gets

> > staged into sysroot indirectly by the toolchain via binutils-cross, it's

> > better to have the dependency listed explicitly for deterministic builds.

> > Otherwise, when using an external toolchain, it fails like this:

> >

> > | FAILED: gen/blink/core/XPathGrammar.cpp gen/blink/core/XPathGrammar.h

> > | .../qtwebengine/5.9.3+...-r0/recipe-sysroot-native/usr/bin/

> > python-native/python2

> > |    ../../../../git/src/3rdparty/chromium/third_party/WebKit/

> > Source/build/scripts/rule_bison.py

> > |    ../../../../git/src/3rdparty/chromium/third_party/WebKit/Source/core/xml/XPathGrammar.y

> > gen/blink/core bison

> > | Traceback (most recent call last):

> > |   File "../../../../git/src/3rdparty/chromium/third_party/WebKit/

> > Source/build/scripts/rule_bison.py", line 83, in <module>

> > |     returnCode = subprocess.call([bisonExe, '-d', '-p', prefix,

> > inputFile, '-o', outputCpp])

> > |   File ".../qtwebengine/5.9.3+...-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py",

> > line 168, in call

> > |     return Popen(*popenargs, **kwargs).wait()

> > |   File ".../qtwebengine/5.9.3+...-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py",

> > line 390, in __init__

> > |     errread, errwrite)

> > |   File ".../qtwebengine/5.9.3+...-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py",

> > line 1024, in _execute_child

> > |     raise child_exception

> > | OSError: [Errno 2] No such file or directory

> >

> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>

> > ---

> >  recipes-qt/qt5/qtwebengine_git.bb | 1 +

> >  1 file changed, 1 insertion(+)

> >

> > diff --git a/recipes-qt/qt5/qtwebengine_git.bb b/recipes-qt/qt5/

> > qtwebengine_git.bb

> > index 1f53e4a..ed179de 100644

> > --- a/recipes-qt/qt5/qtwebengine_git.bb

> > +++ b/recipes-qt/qt5/qtwebengine_git.bb

> > @@ -15,6 +15,7 @@ LIC_FILES_CHKSUM = " \

> >  DEPENDS += " \

> >      ninja-native \

> >      yasm-native \

> > +    bison-native \

> >      qtwebchannel \

> >      qtbase qtdeclarative qtxmlpatterns qtquickcontrols qtquickcontrols2 \

> >      qtlocation \

> > --

> > 2.7.4

> >

> > --

> > _______________________________________________

> > Openembedded-devel mailing list

> > Openembedded-devel@lists.openembedded.org

> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel

> >

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch

diff --git a/recipes-qt/qt5/qtwebengine_git.bb b/recipes-qt/qt5/qtwebengine_git.bb
index 1f53e4a..ed179de 100644
--- a/recipes-qt/qt5/qtwebengine_git.bb
+++ b/recipes-qt/qt5/qtwebengine_git.bb
@@ -15,6 +15,7 @@  LIC_FILES_CHKSUM = " \
 DEPENDS += " \
     ninja-native \
     yasm-native \
+    bison-native \
     qtwebchannel \
     qtbase qtdeclarative qtxmlpatterns qtquickcontrols qtquickcontrols2 \
     qtlocation \