| Message ID | 20180112155033.3694504-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 9be9d04b28e75b52f83e3e10ee529a1ec992a2c0 |
| Headers | show |
| Series | netfilter: nf_tables: flow_offload depends on flow_table | expand |
On Fri, Jan 12, 2018 at 04:50:26PM +0100, Arnd Bergmann wrote: > Without CONFIG_NF_FLOW_TABLE, the new nft_flow_offload module produces > a link error: > > net/netfilter/nft_flow_offload.o: In function `nft_flow_offload_iterate_cleanup': > nft_flow_offload.c:(.text+0xb0): undefined reference to `nf_flow_table_iterate' > net/netfilter/nft_flow_offload.o: In function `flow_offload_iterate_cleanup': > nft_flow_offload.c:(.text+0x160): undefined reference to `flow_offload_dead' > net/netfilter/nft_flow_offload.o: In function `nft_flow_offload_eval': > nft_flow_offload.c:(.text+0xc4c): undefined reference to `flow_offload_alloc' > nft_flow_offload.c:(.text+0xc64): undefined reference to `flow_offload_add' > nft_flow_offload.c:(.text+0xc94): undefined reference to `flow_offload_free' > > This adds a Kconfig dependency for it. Applied, thanks Arnd.
diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index ea447826e127..9019fa98003d 100644 --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig @@ -506,7 +506,7 @@ config NFT_CT connection tracking information such as the flow state. config NFT_FLOW_OFFLOAD - depends on NF_CONNTRACK + depends on NF_CONNTRACK && NF_FLOW_TABLE tristate "Netfilter nf_tables hardware flow offload module" help This option adds the "flow_offload" expression that you can use to
Without CONFIG_NF_FLOW_TABLE, the new nft_flow_offload module produces a link error: net/netfilter/nft_flow_offload.o: In function `nft_flow_offload_iterate_cleanup': nft_flow_offload.c:(.text+0xb0): undefined reference to `nf_flow_table_iterate' net/netfilter/nft_flow_offload.o: In function `flow_offload_iterate_cleanup': nft_flow_offload.c:(.text+0x160): undefined reference to `flow_offload_dead' net/netfilter/nft_flow_offload.o: In function `nft_flow_offload_eval': nft_flow_offload.c:(.text+0xc4c): undefined reference to `flow_offload_alloc' nft_flow_offload.c:(.text+0xc64): undefined reference to `flow_offload_add' nft_flow_offload.c:(.text+0xc94): undefined reference to `flow_offload_free' This adds a Kconfig dependency for it. Fixes: a3c90f7a2323 ("netfilter: nf_tables: flow offload expression") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- net/netfilter/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0