[v2,04/15] env: Make the env save message a bit more explicit

Message ID fb4570e173ecc41955abab25b17568fb23825e70.1516094113.git-series.maxime.ripard@free-electrons.com
State Superseded
Headers show
  • env: Multiple env support and env transition for sunxi
Related show

Commit Message

Maxime Ripard Jan. 16, 2018, 9:16 a.m.
Since we'll soon have support for multiple environments, the environment
saving message might end up being printed multiple times if the higher
priority environment cannot be used.

That might confuse the user, so let's make it explicit if the operation
failed or not.

Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
 env/env.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


diff --git a/env/env.c b/env/env.c
index 4dc39b384c1e..afffab4c002a 100644
--- a/env/env.c
+++ b/env/env.c
@@ -144,8 +144,9 @@  int env_save(void)
 		if (!drv->save)
-		printf("Saving Environment to %s...\n", drv->name);
+		printf("Saving Environment to %s... ", drv->name);
 		ret = drv->save();
+		printf("%s\n", ret ? "Failed" : "OK");
 		if (!ret)
 			return 0;