From patchwork Tue Jan 16 09:16:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2,04/15] env: Make the env save message a bit more explicit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 124640 Message-Id: To: Tom Rini Cc: Andre Przywara , agraf@suse.de, u-boot@lists.denx.de, Maxime Ripard , Jagan Teki Date: Tue, 16 Jan 2018 10:16:40 +0100 From: Maxime Ripard List-Id: U-Boot discussion Since we'll soon have support for multiple environments, the environment saving message might end up being printed multiple times if the higher priority environment cannot be used. That might confuse the user, so let's make it explicit if the operation failed or not. Reviewed-by: Andre Przywara Reviewed-by: Lukasz Majewski Reviewed-by: Simon Glass Signed-off-by: Maxime Ripard --- env/env.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/env/env.c b/env/env.c index 4dc39b384c1e..afffab4c002a 100644 --- a/env/env.c +++ b/env/env.c @@ -144,8 +144,9 @@ int env_save(void) if (!drv->save) continue; - printf("Saving Environment to %s...\n", drv->name); + printf("Saving Environment to %s... ", drv->name); ret = drv->save(); + printf("%s\n", ret ? "Failed" : "OK"); if (!ret) return 0;