From patchwork Tue Jan 16 09:16:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 124640 Delivered-To: patch@linaro.org Received: by 10.46.64.148 with SMTP id r20csp948338lje; Tue, 16 Jan 2018 01:23:55 -0800 (PST) X-Google-Smtp-Source: ACJfBosaxxcruOXSnlFgpqejeMSh5iXLiw8E7vNCPPfH5bWneqnxS23KHP4+p/Hhe5t/CC+xhAwZ X-Received: by 10.80.214.8 with SMTP id x8mr5713495edi.129.1516094635338; Tue, 16 Jan 2018 01:23:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516094635; cv=none; d=google.com; s=arc-20160816; b=cPCrENpkk8TNz889kn8PT56NyVMjel6y8/chPNcZwhlaqy/LeIScNAkei1iMGylI7m qBbi2VuZMVLjoRpjDgolv/fZXbSPNJO5C8ESMyZwZsBceUqfiAiUkKJy8bMbiRdGQmw4 30tjP2pMH9CArhG5DQJQaMZ5CDuwxvkRzTpP6xePi0AFtetfLoSwn9EDoP4JNOkSUM+Y 09PabNUxqrN8CPEMOt5ZegYtsaPYZC3sakrMZvr3eeyQ9j1TvcWgZ9NTxfWf1LN14twi 9oZwHsQdfRYIHp4VYiMn+l8IC9G3pIWNEC1RFSkGodCZEHceVEjDiORYCtoslHWfNR77 uQWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:references :in-reply-to:message-id:date:to:from:arc-authentication-results; bh=h5bMrjVcFIXkceh6xGD5AAwl8Yu15XhKfEtA2eBKh+I=; b=go+sse1Wu0DheYDv5KQI88QOitZ/mF86Mx+p+Javhw4ydQ3Ys/lJgSjsooW6lZFD7V e8y/g8d168YFH4qUOxvV/dsdVbn/SdkYc3IQw9gH6SsA2j1vDNOmMhp/Rj3PoyFZr6yW ceWgGYl79unEuQwu3H4iRFcMZvJtq18jtY38P8CEOJVtuZukcMAqdoTs5FFnclKBp59o 1Eax9GIa0pWgBiknrxm+LjfEKOgmuErKNfzTyWDEjir/Jz6WFkI8ig8xm3Sx0kVcHR7j syQKmo+Tya3aMPi4svkGFyXcRFrX0w2RTOLYTNGN5koG9+9IKbFa5rvjwp7rMxlnkCtK qY+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id d38si133881ede.268.2018.01.16.01.23.55; Tue, 16 Jan 2018 01:23:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by lists.denx.de (Postfix, from userid 105) id DD64BC21DEF; Tue, 16 Jan 2018 09:19:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 2E799C21E51; Tue, 16 Jan 2018 09:17:10 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 13004C21E43; Tue, 16 Jan 2018 09:17:00 +0000 (UTC) Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by lists.denx.de (Postfix) with ESMTP id 50ABEC21DD9 for ; Tue, 16 Jan 2018 09:16:56 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 110) id 2CF23208B9; Tue, 16 Jan 2018 10:16:55 +0100 (CET) Received: from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.free-electrons.com (Postfix) with ESMTPSA id EC12B20725; Tue, 16 Jan 2018 10:16:54 +0100 (CET) From: Maxime Ripard To: Tom Rini Date: Tue, 16 Jan 2018 10:16:40 +0100 Message-Id: X-Mailer: git-send-email 2.14.3 In-Reply-To: References: In-Reply-To: References: Cc: Andre Przywara , agraf@suse.de, u-boot@lists.denx.de, Maxime Ripard , Jagan Teki Subject: [U-Boot] [PATCH v2 04/15] env: Make the env save message a bit more explicit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Since we'll soon have support for multiple environments, the environment saving message might end up being printed multiple times if the higher priority environment cannot be used. That might confuse the user, so let's make it explicit if the operation failed or not. Reviewed-by: Andre Przywara Reviewed-by: Lukasz Majewski Reviewed-by: Simon Glass Signed-off-by: Maxime Ripard --- env/env.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/env/env.c b/env/env.c index 4dc39b384c1e..afffab4c002a 100644 --- a/env/env.c +++ b/env/env.c @@ -144,8 +144,9 @@ int env_save(void) if (!drv->save) continue; - printf("Saving Environment to %s...\n", drv->name); + printf("Saving Environment to %s... ", drv->name); ret = drv->save(); + printf("%s\n", ret ? "Failed" : "OK"); if (!ret) return 0;