| Message ID | 1516248823-22790-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 312ee68752faaa553499775d2c191ff7a883826f |
| Headers | show |
| Series | kconfig: announce removal of oldnoconfig if used | expand |
On Thu, Jan 18, 2018 at 5:13 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > The 'oldnoconfig' is really confusing due to its counter-intuitive name. > It was renamed by commit fb16d8912db5 ("kconfig: replace 'oldnoconfig' > with 'olddefconfig', and keep the old name as an alias"). > > The 'oldnoconfig' has been kept as an alias for enough period of time, > and finally I am planning to remove it. Meanwhile, the following > message will be displayed if oldnoconfig is used. > > WARNING: "oldnoconfig" target will be removed after Linux 4.19 > Please use "olddefconfig" instead. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > scripts/kconfig/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile > index 61cdc5e..9a349bd 100644 > --- a/scripts/kconfig/Makefile > +++ b/scripts/kconfig/Makefile > @@ -92,6 +92,8 @@ PHONY += oldnoconfig savedefconfig defconfig > # on its behavior (sets new symbols to their default value but not 'n') with the > # counter-intuitive name. > oldnoconfig: olddefconfig > + @echo " WARNING: \"oldnoconfig\" target will be removed after Linux 4.19" > + @echo " Please use \"olddefconfig\" instead." > > savedefconfig: $(obj)/conf > $< $(silent) --$@=defconfig $(Kconfig) > -- > 2.7.4 > Reviewed-by: Ulf Magnusson <ulfalizer@gmail.com> Maybe it could be extended to "Please use \"olddefconfig\" instead, which is an alias", to make it extra clear. Guessing "no" is from the fact that bool/tristate symbols with no user value default to n unless they're selected or have an active default. Confusing name still. Cheers, Ulf
2018-01-18 20:56 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>: > On Thu, Jan 18, 2018 at 5:13 AM, Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: >> The 'oldnoconfig' is really confusing due to its counter-intuitive name. >> It was renamed by commit fb16d8912db5 ("kconfig: replace 'oldnoconfig' >> with 'olddefconfig', and keep the old name as an alias"). >> >> The 'oldnoconfig' has been kept as an alias for enough period of time, >> and finally I am planning to remove it. Meanwhile, the following >> message will be displayed if oldnoconfig is used. >> >> WARNING: "oldnoconfig" target will be removed after Linux 4.19 >> Please use "olddefconfig" instead. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> --- >> >> scripts/kconfig/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile >> index 61cdc5e..9a349bd 100644 >> --- a/scripts/kconfig/Makefile >> +++ b/scripts/kconfig/Makefile >> @@ -92,6 +92,8 @@ PHONY += oldnoconfig savedefconfig defconfig >> # on its behavior (sets new symbols to their default value but not 'n') with the >> # counter-intuitive name. >> oldnoconfig: olddefconfig >> + @echo " WARNING: \"oldnoconfig\" target will be removed after Linux 4.19" >> + @echo " Please use \"olddefconfig\" instead." >> >> savedefconfig: $(obj)/conf >> $< $(silent) --$@=defconfig $(Kconfig) >> -- >> 2.7.4 >> > > Reviewed-by: Ulf Magnusson <ulfalizer@gmail.com> > > Maybe it could be extended to "Please use \"olddefconfig\" instead, > which is an alias", to make it extra clear. I did so, and applied to linux-kbuild/kconfig. Thanks! -- Best Regards Masahiro Yamada
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile index 61cdc5e..9a349bd 100644 --- a/scripts/kconfig/Makefile +++ b/scripts/kconfig/Makefile @@ -92,6 +92,8 @@ PHONY += oldnoconfig savedefconfig defconfig # on its behavior (sets new symbols to their default value but not 'n') with the # counter-intuitive name. oldnoconfig: olddefconfig + @echo " WARNING: \"oldnoconfig\" target will be removed after Linux 4.19" + @echo " Please use \"olddefconfig\" instead." savedefconfig: $(obj)/conf $< $(silent) --$@=defconfig $(Kconfig)
The 'oldnoconfig' is really confusing due to its counter-intuitive name. It was renamed by commit fb16d8912db5 ("kconfig: replace 'oldnoconfig' with 'olddefconfig', and keep the old name as an alias"). The 'oldnoconfig' has been kept as an alias for enough period of time, and finally I am planning to remove it. Meanwhile, the following message will be displayed if oldnoconfig is used. WARNING: "oldnoconfig" target will be removed after Linux 4.19 Please use "olddefconfig" instead. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- scripts/kconfig/Makefile | 2 ++ 1 file changed, 2 insertions(+) -- 2.7.4