diff mbox series

Keep the native terminal active when enabling gfxterm

Message ID 20180118185726.GA29273@xps13.dannf
State Accepted
Commit 52ef7b23f528ce844716661d586497a177e80d5b
Headers show
Series Keep the native terminal active when enabling gfxterm | expand

Commit Message

dann frazier Jan. 18, 2018, 6:57 p.m. UTC 
grub-mkconfig will set GRUB_TERMINAL_OUTPUT to "gfxterm" unless the user
has overridden it. On EFI systems, this will stop output from going to the
default "console" terminal. When the EFI fw console is configured to output to
both serial and video, this will cause GRUB to only display on video - while
continuing to accept input from both video and serial.

Instead of switching from "console" to "gfxterm", let's output to both.
---
 util/grub.d/00_header.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.15.1


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Comments

Daniel Kiper Jan. 18, 2018, 11:05 p.m. UTC | #1 
On Thu, Jan 18, 2018 at 11:57:26AM -0700, dann frazier wrote:
> grub-mkconfig will set GRUB_TERMINAL_OUTPUT to "gfxterm" unless the user

> has overridden it. On EFI systems, this will stop output from going to the

> default "console" terminal. When the EFI fw console is configured to output to

> both serial and video, this will cause GRUB to only display on video - while

> continuing to accept input from both video and serial.

>

> Instead of switching from "console" to "gfxterm", let's output to both.


Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>


If there are no objections I will apply this next week.

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
Daniel Kiper Jan. 29, 2018, 12:17 p.m. UTC | #2 
On Fri, Jan 19, 2018 at 12:05:10AM +0100, Daniel Kiper wrote:
> On Thu, Jan 18, 2018 at 11:57:26AM -0700, dann frazier wrote:

> > grub-mkconfig will set GRUB_TERMINAL_OUTPUT to "gfxterm" unless the user

> > has overridden it. On EFI systems, this will stop output from going to the

> > default "console" terminal. When the EFI fw console is configured to output to

> > both serial and video, this will cause GRUB to only display on video - while

> > continuing to accept input from both video and serial.

> >

> > Instead of switching from "console" to "gfxterm", let's output to both.

>

> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

>

> If there are no objections I will apply this next week.


Applied!

Thanks,

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
diff mbox series

Patch

diff --git a/util/grub.d/00_header.in b/util/grub.d/00_header.in
index 93a90233e..8d46fc973 100644
--- a/util/grub.d/00_header.in
+++ b/util/grub.d/00_header.in
@@ -221,7 +221,7 @@  case x${GRUB_TERMINAL_OUTPUT} in
   ;;
   x*)
     cat << EOF
-terminal_output ${GRUB_TERMINAL_OUTPUT}
+terminal_output --append ${GRUB_TERMINAL_OUTPUT}
 EOF
   ;;
 esac