efi: arm: stop printing addresses of virtual mappings

Message ID 20180119122619.16023-1-ard.biesheuvel@linaro.org
State Accepted
Commit 1832e64162ffbbbdf7230401298550f2b624351b
Headers show
Series
  • efi: arm: stop printing addresses of virtual mappings
Related show

Commit Message

Ard Biesheuvel Jan. 19, 2018, 12:26 p.m.
With the recent %p -> %px changes, we now get something like this in
the kernel boot log on ARM/arm64 EFI systems:

     Remapping and enabling EFI services.
       EFI remap 0x00000087fb830000 =>         (ptrval)
       EFI remap 0x00000087fbdb0000 =>         (ptrval)
       EFI remap 0x00000087fffc0000 =>         (ptrval)

The physical addresses of the UEFI runtime regions will also be
printed when booting with the efi=debug command line option, and the
virtual addresses can be inspected via /sys/kernel/debug/efi_page_tables
(if enabled). So let's just remove the lines above.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 drivers/firmware/efi/arm-runtime.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Leif Lindholm Jan. 19, 2018, 2:38 p.m. | #1
On Fri, Jan 19, 2018 at 12:26:19PM +0000, Ard Biesheuvel wrote:
> With the recent %p -> %px changes, we now get something like this in

> the kernel boot log on ARM/arm64 EFI systems:

> 

>      Remapping and enabling EFI services.

>        EFI remap 0x00000087fb830000 =>         (ptrval)

>        EFI remap 0x00000087fbdb0000 =>         (ptrval)

>        EFI remap 0x00000087fffc0000 =>         (ptrval)

> 

> The physical addresses of the UEFI runtime regions will also be

> printed when booting with the efi=debug command line option, and the

> virtual addresses can be inspected via /sys/kernel/debug/efi_page_tables

> (if enabled). So let's just remove the lines above.


As long as the efi=debug functionality is kept, I have no issue with this.
Acked-by: Leif Lindholm <leif.lindholm@linaro.org>


> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  drivers/firmware/efi/arm-runtime.c | 5 +----

>  1 file changed, 1 insertion(+), 4 deletions(-)

> 

> diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c

> index 1cc41c3d6315..5d4c8b661548 100644

> --- a/drivers/firmware/efi/arm-runtime.c

> +++ b/drivers/firmware/efi/arm-runtime.c

> @@ -80,10 +80,7 @@ static bool __init efi_virtmap_init(void)

>  			return false;

>  

>  		ret = efi_create_mapping(&efi_mm, md);

> -		if  (!ret) {

> -			pr_info("  EFI remap %pa => %p\n",

> -				&phys, (void *)(unsigned long)md->virt_addr);

> -		} else {

> +		if (ret) {

>  			pr_warn("  EFI remap %pa: failed to create mapping (%d)\n",

>  				&phys, ret);

>  			return false;

> -- 

> 2.11.0

> 

--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c
index 1cc41c3d6315..5d4c8b661548 100644
--- a/drivers/firmware/efi/arm-runtime.c
+++ b/drivers/firmware/efi/arm-runtime.c
@@ -80,10 +80,7 @@  static bool __init efi_virtmap_init(void)
 			return false;
 
 		ret = efi_create_mapping(&efi_mm, md);
-		if  (!ret) {
-			pr_info("  EFI remap %pa => %p\n",
-				&phys, (void *)(unsigned long)md->virt_addr);
-		} else {
+		if (ret) {
 			pr_warn("  EFI remap %pa: failed to create mapping (%d)\n",
 				&phys, ret);
 			return false;